-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update crates to digest v0.10 #217
Conversation
59bf09a
to
34553de
Compare
FYI, I just merged Tiger in #229, so you'll probably want to rebase |
Our bitcoin lib need to be compiled in Wasm, 0.9.0 can't work now... I try 0.10 is ok, hoping this pr could be merged soon... |
0.9 versions should work fine on WASM. If it's a problem with our crates, can you please open an issue with a description and reproduction steps? |
16fd1b6
to
1f75d09
Compare
faa4ba1
to
29038d3
Compare
d89101d
to
bcf9698
Compare
4e2abaf
to
4deb284
Compare
BTW I wonder if we should synchronize all hasher crate versions to v0.10. It would make it much easier to see at a single glance which trait version a crate implements, but it would mean we will have a discontinuity in minor versions for some crates, e.g. |
39e587d
to
37e29b1
Compare
Depends on RustCrypto/traits#819.
Notable changes:
ripemd160
,ripemd256
, andripemd320
merged intoripemd
.groestl
crate using (public domain) code from the NIST submission as a reference. Now the crate has an acceptable performance (~100 MB/s vs ~1 MB/s). It can be improved even further by utilizing AES-NI and SIMD in general, but I don't plan to work on it myself.fsb
improvements.sha2
,streebog
, andshabal
are implemented in terms of theVariableOutputCore
trait. For example,Sha512VarCore
implements it, but supports initialization only for 4 sizes and its variants are defined as:Closes #67
Closes #317
Closes #330