Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump crypto-mac from 0.8.0 to 0.10.0 #198

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 16, 2020

Bumps crypto-mac from 0.8.0 to 0.10.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 16, 2020
@dependabot dependabot bot force-pushed the dependabot/cargo/crypto-mac-0.10.0 branch from 6232789 to c1c30bd Compare October 26, 2020 18:35
@tarcieri
Copy link
Member

@newpavlov this is definitely a weird error for a crypto-mac version bump:

---- blake2s_mac stdout ----
thread 'blake2s_mac' panicked at '
Failed test №0: whole message
key:	[21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
input:	[9, 189, 230, 241, 82, 33, 141, 201, 44, 65, 215, 244, 83, 135, 230, 62, 88, 105, 216, 7, 236, 112, 184, 33, 64, 93, 189, 136, 75, 127, 207, 75]
error: test failed, to rerun pass '--test mac'
tag:	[33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48]
', blake2/tests/mac.rs:6:1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- blake2b_mac stdout ----
thread 'blake2b_mac' panicked at 'called `Result::unwrap()` on an `Err` value: InvalidVlq', /home/runner/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/blobby-0.3.0/src/lib.rs:124:46


failures:
    blake2b_mac
    blake2s_mac

@newpavlov
Copy link
Member

newpavlov commented Oct 29, 2020

crypto-mac v0.8 uses blobby v0.2, crypto-mac v0.10 uses blobby v0.3, so format of test files is different. We probably should postpone this change until RustCrypto/traits#262 is resolved and thus digest v0.10 is released.

@newpavlov
Copy link
Member

Closing it in favor of #217.

@newpavlov newpavlov closed this Feb 9, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 9, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/crypto-mac-0.10.0 branch February 9, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants