Allow reverse overworld entrances to be used in plando with full mixed pools #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenhl
added a commit
to fenhl/OoT-Randomizer
that referenced
this pull request
Oct 3, 2022
fenhl
pushed a commit
to fenhl/OoT-Randomizer
that referenced
this pull request
Oct 10, 2022
…contents Code style review for pots branch (Roman971#49) Make pots/crates shuffle their vanilla items (Roman971#50) Fix alt_hint for ganondorf only. Fix Ganon's tower filter tags Resolve c compiler warnings Adjust item_give_collectible for MW_SEND_OWN_ITEMS (Roman971#51) Add Vanilla and Master Quest tags to Ganon's Tower pots (Roman971#52) Change new settings' display names from “X Shuffle” to “Shuffle X” (Roman971#53) Fix version.py ItemPool.py Cleanup Removed the no longer in use function `get_new_junk` as well as `is_freestanding_or_potcrate_or_beehive_location` which was only used in places where it does not matter due to those locations already being handled earlier in the elif chain. Use location.type instead of location.filter_tags for new Locations. Cleanup and fix typo Typo Make small key and piece of heart drops work without requiring new type
fenhl
added a commit
to fenhl/OoT-Randomizer
that referenced
this pull request
Nov 4, 2022
fenhl
pushed a commit
to fenhl/OoT-Randomizer
that referenced
this pull request
Nov 15, 2024
Fix presets from dev merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entrance pools for setting plando'd entrances only include one side of overworld entrances as top level keys. This fails seed generation when the opposite direction is specified. The PR adds searches on the .reverse property of the primary entrances, then swaps variables as necessary to link the right entrances.
Tested on 50 random settings seeds with forced full mixed pools, another 50 random settings seeds with forced indoor-only mixed pools, and a final 50 with no mixed pools by generating a seed and feeding the spoiler back into the randomizer as a plando. Decoupled was tested with full mixed only for 50 random settings seeds. The only modifications to the plando are removing fixed shop items from locations, the item pool, and hints. The two attached plandos were used for development and testing:
Full mixed, only OW ER on
Full mixed, OW, All Indoor, Dungeon ER on
There are some remaining issues with world validation that this PR does not address. This includes invalid starting area, ToD passing access as both ages, ToT access guarantee as opposite age, and Biggoron access (maybe any always-hinted location?). When these came up in testing, I verified that the plando had the same error in the unmodified branch.