Add Song of Time location to child pedestal #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlyryD
commented
Mar 3, 2021
Hints.py
Outdated
| else: | ||
| song_of_time_location_string = "\x05\x42your dreams\x05\x40" | ||
| string += "And the song that opens the \x05\x44Door of Time\x05\x40 can be found in %s." % song_of_time_location_string | ||
| return str(GossipText(string, ['Yellow'], prefix='')) |
There was a problem hiding this comment.
I don't understand what impact GossipText or 'Yellow' has on the text.
SlyryD
commented
Mar 3, 2021
Main.py
Outdated
| @@ -553,6 +553,19 @@ def find_light_arrows(spoiler): | |||
| maybe_set_light_arrows(location) | |||
|
|
|||
|
|
|||
| def maybe_set_song_of_time(location): | |||
There was a problem hiding this comment.
Every change I made in this file is lifted and shifted from light_arrow_location logic. I didn't take the time to understand how this works, so some of it might not be relevant to song of time.
fenhl
added a commit
to fenhl/OoT-Randomizer
that referenced
this pull request
Oct 3, 2022
fenhl
pushed a commit
to fenhl/OoT-Randomizer
that referenced
this pull request
Oct 10, 2022
…contents Code style review for pots branch (Roman971#49) Make pots/crates shuffle their vanilla items (Roman971#50) Fix alt_hint for ganondorf only. Fix Ganon's tower filter tags Resolve c compiler warnings Adjust item_give_collectible for MW_SEND_OWN_ITEMS (Roman971#51) Add Vanilla and Master Quest tags to Ganon's Tower pots (Roman971#52) Change new settings' display names from “X Shuffle” to “Shuffle X” (Roman971#53) Fix version.py ItemPool.py Cleanup Removed the no longer in use function `get_new_junk` as well as `is_freestanding_or_potcrate_or_beehive_location` which was only used in places where it does not matter due to those locations already being handled earlier in the elif chain. Use location.type instead of location.filter_tags for new Locations. Cleanup and fix typo Typo Make small key and piece of heart drops work without requiring new type
fenhl
added a commit
to fenhl/OoT-Randomizer
that referenced
this pull request
Nov 4, 2022
fenhl
pushed a commit
to fenhl/OoT-Randomizer
that referenced
this pull request
Nov 15, 2024
Dev merge 8.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Song of Time location to the child pedestal hints.
Impact:
Shortcomings:
Further ideas: