Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase 2024 signInWithRedirect changes #843

Open
MoyTW opened this issue Aug 31, 2024 · 1 comment
Open

Firebase 2024 signInWithRedirect changes #843

MoyTW opened this issue Aug 31, 2024 · 1 comment

Comments

@MoyTW
Copy link
Collaborator

MoyTW commented Aug 31, 2024

I believe but can't really currently prove that our "Sign in with Google" uses signInWithRedirect, and I believe it's flat-out broken. See:
emailpage1
emailpage2

The result of this is that nobody can sign in with Google. Which seems bad.

Since we do not host using Firebase, we'll need to remediate using one of the following: https://firebase.google.com/docs/auth/web/redirect-best-practices#web_1 or we need to disable to "Sign in with Google" sign in method.

See also #844

@MoyTW
Copy link
Collaborator Author

MoyTW commented Aug 31, 2024

I haven't tested this with more Google accounts than just, like, my own main account - which already does have an email-based account - so that could be junking it up but as I posted in Discord, that's bad enough!

Ok, I think that:
1) our email-based login works fine
2) our Google-account-based login might be broken in a way that's annoying to fix (details later) but I'm NOT sure about that
3) our Google-account-based login is DEFINITELY hard-broken if you have an email associated with said Google account already in our system

More generally we have an issue that the library we imported to do the signup hasn't been updated in 6 years and that's bad.

MoyTW added a commit to MoyTW/azure-mud that referenced this issue Sep 5, 2024
Firebase changed how the API worked and I can't figure out how to get
Azure to properly reverse proxy the calls. It's like some sorta CORS but
for browser cookies and anywayways it's apparently remediable but I'll
be dammned if I have the time and energy to fix it, especially since
preview is this Friday.

Anyways we're disabling everything but email and I hope that works lmao
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant