Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update conventions and fix logger providers #1996

Merged
merged 2 commits into from
May 3, 2024

Conversation

david-driscoll
Copy link
Member

No description provided.

@github-actions github-actions bot added this to the v2.0.1 milestone May 3, 2024
@david-driscoll david-driscoll enabled auto-merge (squash) May 3, 2024 15:30
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.98%. Comparing base (bcb6cdd) to head (2762694).

❗ Current head 2762694 differs from pull request most recent head 4f011d5. Consider uploading reports for the commit 4f011d5 to get more accurate results

Files Patch % Lines
...rc/Hosting/Conventions/SerilogHostingConvention.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1996   +/-   ##
=======================================
  Coverage   78.98%   78.98%           
=======================================
  Files         251      251           
  Lines        7500     7500           
  Branches      586      586           
=======================================
  Hits         5924     5924           
  Misses       1576     1576           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-driscoll david-driscoll merged commit 45ce340 into master May 3, 2024
6 checks passed
@david-driscoll david-driscoll deleted the fix/logging-providers branch May 3, 2024 15:46
@github-actions github-actions bot added the ✨ mysterious We forgot to label this label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants