Removed ClearProviders (#1996)

RocketSurgeonsGuild · May 3, 2024 · 45ce340 · 45ce340
1 parent bcb6cdd
commit 45ce340
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Hosting/Conventions/SerilogHostingConvention.cs b/src/Hosting/Conventions/SerilogHostingConvention.cs
@@ -63,12 +63,12 @@ public void Register(IConventionContext context, IHostApplicationBuilder builder
                 _options.PreserveStaticLogger,
                 _options.WriteToProviders
             );
-
-            if (context.Get<ILoggerFactory>() != null)
-                // ReSharper disable once NullableWarningSuppressionIsUsed
-                builder.Services.AddSingleton(context.Get<ILoggerFactory>()!);
         }
 
+        if (context.Get<ILoggerFactory>() != null)
+            // ReSharper disable once NullableWarningSuppressionIsUsed
+            builder.Services.AddSingleton(context.Get<ILoggerFactory>()!);
+
         if (_options.WriteToProviders) return;
 
         builder.OnHostStarting(

diff --git a/src/Serilog/LaunchPadLoggingOptions.cs b/src/Serilog/LaunchPadLoggingOptions.cs
@@ -3,6 +3,7 @@ namespace Rocket.Surgery.LaunchPad.Serilog;
 /// <summary>
 ///     RocketSerilogOptions.
 /// </summary>
+[PublicAPI]
 public class LaunchPadLoggingOptions
 {
     /// <summary>
@@ -30,7 +31,7 @@ public class LaunchPadLoggingOptions
     /// <summary>
     ///     Base option from the serilog package
     /// </summary>
-    public bool WriteToProviders { get; set; } = false;
+    public bool WriteToProviders { get; set; }
 
     /// <summary>
     ///     Base option from the serilog package