Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.15.2 not upgrading to 2.15.3 #1205

Closed
2 tasks done
NathanBeddoeWebDev opened this issue Apr 30, 2019 · 32 comments
Closed
2 tasks done

2.15.2 not upgrading to 2.15.3 #1205

NathanBeddoeWebDev opened this issue Apr 30, 2019 · 32 comments

Comments

@NathanBeddoeWebDev
Copy link

My Setup

  • Operating System: Windows 10
  • App Version: 2.15.2
  • I have tested with the latest version
  • I can simulate the issue easily

Description

A prompt appears asking me to update to 2.15.3, I click the Install Update button. From then on, nothing happens. I believe it does download the update, but doesn't install it, if that makes sense.

Current Behavior

After clicking the Install Update button, nothing happens

Expected Behavior

It should ask me to restart Rocket Chat to install the update.

@JackNWeems
Copy link

I'm having the same issue.

@bkraul
Copy link

bkraul commented May 2, 2019

Same here. It says I will be notified, but it never does. What's the deal?

@franckadil
Copy link

franckadil commented May 2, 2019

Hi Guys, Are you using private Github repos ? if so you may want to check my answer here:

If this fixes the issue please update this issue, so the devs know they should downgrade some packages as explained in the solution that worked for me.

Cheers!

@0xC4N1
Copy link

0xC4N1 commented May 3, 2019

Same behavior on Windows 7

@stonewoodman
Copy link

I have the same Problem.
Error: Error: New version 2.15.3 is not signed by the application owner: publisherNames: Sectigo RSA Code Signing CA, raw info: ...

I attached a file with completely console output of the update.
rocket.chat console output.txt

@Anigif
Copy link

Anigif commented May 7, 2019

Same here, but I wouldn't say nothing happens (but it's close to). When I click "Install Update" a dialog shows that states "You will be notified when the update is ready to be installed". There's a OK-button and when I click that, it seems like nothing happens (other than both the dialog and the update-window closes).

This happens every time I open Rocket.Chat.

OS: Windows 10 Pro
Rocket.Chat: 2.15.2

@tassoevan
Copy link
Collaborator

After looking at @stonewoodman's info, it seems that properly signing the application for Windows broke the update 🤦‍♂️

@Nono-m0le
Copy link

@tassoevan do you need any more logs for troubleshouting this issue ?

@lascapi
Copy link

lascapi commented Sep 2, 2019

Hi! Same here, since the 2.15.2 version, I can't update Rocket.Chat :/

@Nono-m0le
Copy link

@lascapi as far I as remember, it will never work as it's an issue on the updater itself. I suggest you to download & install manually the new version (currently 2.15.5).

@bkraul
Copy link

bkraul commented Sep 2, 2019

Wouldn't it stand to reason, then, to modify the update dialog, to direct the user to a link and a manual download instead?

@nyetwurk
Copy link

Same for 2.15.3 -> 2.15.5

@joshmartindev
Copy link

Is the only fix to manually download the latest update? It's going to be quite the undertaking to update all my users to the latest version.

@Chealer
Copy link

Chealer commented Oct 11, 2019

I experienced something similar (or the same) several times when Rocket.Chat proposed updating. Then I tried manually updating from 2.15.3 to 2.15.5 and got a clear error. Then, I restorted to manually installing 2.15.5.

@bkraul
Copy link

bkraul commented Oct 11, 2019

Once again, if this seems like it is never going to reliably work due to interactions with some of the packages, a simple link to a direct download would be great.

@foss-
Copy link

foss- commented Nov 9, 2019

persisting on macOS as well. not a surprise as the issue seem to require a fix in the installer itself. 2.16.1 to 2.16.2.

@JackNWeems
Copy link

JackNWeems commented Nov 10, 2019 via email

@bkraul
Copy link

bkraul commented Nov 10, 2019

Try the releases section here. You'll find 2.16.2.

@franckadil
Copy link

franckadil commented Nov 10, 2019

Once again, if this seems like it is never going to reliably work due to interactions with some of the packages, a simple link to a direct download would be great.

I absolutely agree, I've been doing my best to keep up with the changes that are introduced, but core features are changed a lot more often than they should . And the whole Electron updater code signing requirement feels painful to keep up with.

On the other hand I am trying to maintain a separate build "deemed stable" for our team otherwise installing every machine would be tedious with people reporting crashes bugs certificate issues etc... That's to give you a perspective of the impact even for tech savvy teams.

Ideas / Feedback

@tassoevan

  • Packages are removed in favor of other packages (this needs q&a tests before a build is released)

  • The build process is changed for the sake of new mac Code Signing (needs q&a and compatibility tests on other platforms too)

  • Maybe a separate repo for Mac with it's own requirements, or a way to have self-signed builds that can be downloaded and installed through a popup link by users instead of forcing apple certificate signing for everyone and auto-updates on a platform that makes it impossible to allow users to choose what apps they want to run on their system.

  • The same goes for Linux (a link to a github release tar file or other packages for each platform)

  • There is need to have more users testing early builds before a release is made with a focus on areas to tests that are improved/changed to keep releases stable enough for daily use.

I think many of us already involved in the project on multiple platforms (Linux / Windows / Mac OS will be happy to go through a checklist and help with the q&a build tests to make sure the quality stays steady.

@JackNWeems
Copy link

Try the releases section here. You'll find 2.16.2.

I'm greatful for the link but I think it's a little much to ask most people to find the release in GitHub.

@tassoevan
Copy link
Collaborator

@JackNWeems Website updated.
@franckadil It's really painful to keep a single code base while the build requirements for each OS keep changing a lot. I'm looking for ideas to minimize problems; some peers have even suggested to remove the auto-update. Also, maintaining separate repositories defeats the whole purpose of using Electron (using the web as a platform over native code), but I've considered going into a monorepo approach. Ultimately, replace electron-builder as it seems to have the slowest update cycle among similar tools.

@franckadil
Copy link

@tassoevan thank you for your kind reply, and being open about new ideas to improve the release cycle. I am looking forward for these changes, and will test the new builds on the supported platforms.
Cheers

@pbb72
Copy link

pbb72 commented Dec 3, 2019

I'm seeing the same for the upgrade from 2.16.2 to 2.17.0. "You will be notified when the update is ready to be installed", but that notification never comes.

On Windows 10 1809, managed by domain administrator.

@dekork
Copy link

dekork commented Dec 4, 2019

This is occuring for 2.16.2 to 2.17.0 for me too. I tried uninstalling and deleting all the left over Rocket.Chat folders in AppData before reinstalling 2.16.2, and it still wouldn't upgrade to 2.17.0.

@JackNWeems
Copy link

I can't upgrade to 2.17.0 either. The direct download on the rocket chat page is also still 2.16.2

@Anigif Anigif mentioned this issue Dec 13, 2019
2 tasks
@joshmartindev
Copy link

@tassoevan Honestly I think the best course of action would be to notify the user there is an update, and then direct them to the website to download the latest version. Unfortunately, that won't be the best solution for enterprise environments where application installs are locked down by domain/group policy. Perhaps those enterprise sys admins can push the installer and install silently through GPO.

@adeniz302
Copy link

This is still an issue on our end, also. Going from 2.17.7 -> 2.17.11
Any update on what's causing this issue and if a fix is being implemented?

@ankar84
Copy link

ankar84 commented Jul 23, 2020

I can confirm that bug.
Did try 2.17.9 -> 2.17.10 and 2.17.10 -> 2.17.11 both didn't work.

@BarnumD
Copy link

BarnumD commented Jul 31, 2020

I'm having the same issue with 2.17.10 -> 2.17.11. I just wanted to add that I installed via chocolatey. I was able to update via choco upgrade rocketchat.

@tassoevan
Copy link
Collaborator

Please report for newer versions at #1670.

@Frank-RC
Copy link

Hy all,

same problem here (Win 10) again and again since years. Meanwhile with V 3.0.5 to 3.0.7 and the all time promise to be "notified when the update is ready to be installed", since now that means "never".

After having downloaded and installed the last update 3.xy manually my RC-host wasn't accepted any more. Uninstalling and new installation solved that problem.

@bkraul
Copy link

bkraul commented Nov 13, 2020

And have been asking over and over to remove such cumbersome way of updating, and just have direct link to the list of binaries...Also, never understood the logic behind the "you will be notified" process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests