Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Auto-Update Does Not Work #1670

Closed
2 tasks done
canuckbrian opened this issue Jul 24, 2020 · 77 comments
Closed
2 tasks done

Client Auto-Update Does Not Work #1670

canuckbrian opened this issue Jul 24, 2020 · 77 comments

Comments

@canuckbrian
Copy link

canuckbrian commented Jul 24, 2020

My Setup

  • Operating System: Windows 10 1909 & 2004 Releases

  • App Version: 2.17.10

  • Installation type: exe

  • I have tested with the latest version

  • I can simulate the issue easily

Description

Automatic update doesn't work. User is prompted and informed that install will proceed once new client is downloaded. But nothing happens.

Current Behavior

  • User is notified that there's an update available and clicks on "INSTALL UPDATE"
    electron_update_notice

  • Dialog pops up letting user know they'll be notified when update is ready to be installed
    electron_update_notice2

  • No notification occurs, no update is installed

  • Update installer file is downloaded to "C:\Users[username]\AppData\Local\rocket-chat-updater\pending"

  • File is called "temp-rocketchat-setup-2.17.11.exe
    electron_updater_file_created

  • After file is downloaded it disappears

Expected Behavior

  • After updated is downloaded, the installer is started and the user is notified

Additional Info

This issue has been around a very long time. At least since I've been using Rocket.Chat which was 3 years ago now. As updates have been coming out we've been instructing users to update manually by downloading the releases through github, but this is tedious as some users don't want to take the time to do it and others don't feel comfortable installing software. It also causes confusion for people who do try, but are constantly prompted that there's an update still every time they launch the client.

@inovari
Copy link

inovari commented Jul 25, 2020

Looks like a (nicely documented) duplicate of #1205. We've also observed this issue too going back at least several months in successive version.

@torrycrass
Copy link

This also appears to be similar to issue #1300

A new bit of info that I hadn't seen in the others. This may be caused by Windows Smart Screen interfering and not posting a pop-up. I manually downloaded .11 for the update and when I went to install I received a smart filter alert that Windows Defender had prevented it from running as seen below.

rocket-chat-setup-2 17 11-defender-error

So, maybe this is a false positive and breaking the install process, or the binary off github has somehow been posted with malicious content?

@adipose
Copy link

adipose commented Aug 12, 2020

I have had this problem for years. It silently fails, I guess--nothing happens at all except when I reboot, it again reminds me that I need to update, I tell it fine, and it tells me it will tell me when it's ready. It never is ready, apparently...

I think the background downloading is doing a disservice here, especially when it's so unreliable (read: it doesn't work at all, for anyone that I know using it). Instead, download it in the foreground, which should be pretty fast, and when it's done, let the user launch it. Maybe then, they will be able to see what error is occurring, if any.

As of now, users click ok, then forget about it, thinking it will update later, when it won't. I'm not sure why this is so hard to get right.

@Dimitrie23
Copy link

Same Issue here. Installer/Updater just disappears.

@ankar84
Copy link

ankar84 commented Aug 21, 2020

@canuckbrian @Dimitrie23 I don't know why, but today it worked!
I upgraded from 2.17.9 to 2.17.11 by auto-update feature.
Please check it now.

@Dimitrie23
Copy link

Dimitrie23 commented Aug 21, 2020

@ankar84 Just tested it. Did still not work on one of our notebooks.

Edit: Same behaviour as mentioned by OP. Download works but updater disappears without a warning/error.

@tassoevan
Copy link
Collaborator

I'm guessing it's an asynchronous bug in electron-updater, because I've never been able to reproduce at >= 2.16.*.

@adipose

I think the background downloading is doing a disservice here, especially when it's so unreliable (read: it doesn't work at all, for anyone that I know using it). Instead, download it in the foreground, which should be pretty fast, and when it's done, let the user launch it. Maybe then, they will be able to see what error is occurring, if any.

One workaround I'm trying to code (but I haven't found time to work on it) is make it unobtrusive as Electrons apps as Visual Studio Code do: showing a small badge instead of a modal dialog.

@adipose
Copy link

adipose commented Sep 3, 2020

I don't get it, are you saying after 2.16 the issue is fixed in some way? That would be great...

@ComBin
Copy link

ComBin commented Oct 1, 2020

Still have this issue for update to 3.0.0.

@adipose
Copy link

adipose commented Oct 1, 2020

So, I too have finally had a chance to test this again, and my 2.17.7 is failing the auto-update to 3.0. So, no fix has occurred.

What steps were taken to fix it before, because it doesn't seem to be working!

@seppultra
Copy link

seppultra commented Oct 2, 2020

Same here from 2.17.11 to 3.0.1. It will be downloaded locally as mentioned above but the installer/updater never appears.

@ankar84
Copy link

ankar84 commented Oct 2, 2020

I think it's fixed only in 3.0.0 so don't expect it magic work in 2.17.11
3.0.0 => 3.0.1
image
image

@xmedeko
Copy link

xmedeko commented Oct 2, 2020

Nope, upgrade 3.0.0 => 3.0.1 does not work for me. I have a per user installation (i.e. in AppData/Local).

@ankar84
Copy link

ankar84 commented Oct 2, 2020

Nope, upgrade 3.0.0 => 3.0.1 does not work for me. I have a per user installation (i.e. in AppData/Local).

Mine was system wide installation and required Administrator credentials. But was successful.

@luciancoman-simplica
Copy link

luciancoman-simplica commented Oct 3, 2020

Auto-update of Windows client still does not work. Same symptoms like the original description of this issue.

Attempted: 3.0.1 => 3.0.2.
Windows 10 version: 2004.
System-wide RC client installation.

It seems that this is only an issue on newer Windows 10 builds, hence the appearance that it was fixed (reading the comment of @ankar84 above). I might be wrong, but I suspect that it worked for ankar84 because he is running RC on an older windows version.

Currently to me this is the most annoying RC client bug, for multiple reasons:

  • it confuses end-users by promising an update which never takes place;
  • it annoys users by repeatedly offering to update on every RC client start (unless choosing to "skip this version");
  • most users do not feel comfortable to manually download and run the new installer over the existing installation.

@ankar84
Copy link

ankar84 commented Oct 3, 2020

I think @alc123ng could be right.
Successful update was not on most modern Windows release (I can clarify version on Monday).
Today I try update 3.0.1 => 3.0.2 on my home laptop on Windows 10 2004 and it was not successful.
Here some details
Update screen and information about update process - that's good
image
image
Here is a new file C:\Users\ankar84\AppData\Local\rocketchat-updater\pending\temp-rocketchat-setup-3.0.2.exe for distributive download
image
After file temp-rocketchat-setup-3.0.2.exe was downloaded system start search prowershell.exe to execute command
powershell.exe -NoProfile -NonInteractive -InputFormat None -Command "Get-AuthenticodeSignature 'C:\Users\ankar84\AppData\Local\rocketchat-updater\pending\temp-rocketchat-setup-3.0.2.exe' | ConvertTo-Json -Compress | ForEach-Object { [Convert]::ToBase64String([System.Text.Encoding]::UTF8.GetBytes($_)) }"
I think that command was successful and issue not here
And here is something not normal
image
For some reason file temp-rocketchat-setup-3.0.2.exe not transform to file rocketchat-setup-3.0.2.exe but temp file deleted
image
I try to search Windows Event logs for something strange, but couldn't find anything.

@ankar84
Copy link

ankar84 commented Oct 5, 2020

Windows 10 1803 - Update works perfect
image
image
image

@KeithStreeter
Copy link

Same for me. Just tells me 3.0.0 is available, then 3.0.1 now this morning 3.0.2. Give me the option to skip or install. When I select install it does not. I get this error message every morning and I'm on version 2.17.11

@ankar84
Copy link

ankar84 commented Oct 14, 2020

3.0.2=>3.0.3 failed on W10 1809
image
image
Then it's gone
image

@ankar84
Copy link

ankar84 commented Nov 26, 2021

Pretty strange thing, but few minutes ago I successfully updated 3.1.1 version to 3.6.0 on pretty recent Windows 20H2
image

But then I try to test it again and issue come back again - installation file disappeared after downloaded.

@ankar84
Copy link

ankar84 commented Nov 26, 2021

Another information.
I did test logging in in Windows as Admin user and update wasn't successful.
Then I logged in as a regular user without Administrative privileges and update was successful, here is a GIF

electron-update
And installation file on it's place
image

@KarimH22
Copy link

KarimH22 commented Dec 7, 2021

Hello
Expecting you fix that , you could change the message just saying a new version is available , link to github tags to get the new one.
that will not disturb people waiting the application to update automaticaly the program.

Thanks

@joshmartindev
Copy link

So if you're not a local admin on the workstation, the auto updater works? Seems a bit backwards.

@eriklesbr
Copy link

eriklesbr commented Dec 14, 2021

I did a test installing only for the local user (C:\users\user\AppData\local\Rocket.Chat) version 3.2.3, after clicking on update, it was updated successfully.

Installing for everyone (C:\Programs Files\Rocket.Chat) also version 3.2.3 does not work.

Trial version 3.2.3, version to which 3.7.0 was updated

@luison
Copy link

luison commented Dec 19, 2021

Just confirming this issue remains for me too (3.5.6 -> 3.7). As someone mentioned before rather get a notice and a link to download and reinstall the updated version.

@canuckbrian
Copy link
Author

3.7.0 -> 3.7.1 update still doesn't work. Surprise surprise...

I opened this issue a year and a half ago. The issue itself has existed for as long as we've been using Rocket.Chat which is coming on 3.5 years now. Since then they have made push notifications a pay feature beyond 10K notifications (which I feel is a slimy way to "encourage" people to subscribe as Push Notifications cost them nothing and no other messaging platform charges for notifications). Their sales team has been in contact with my organization several times trying to get us to subscribe. But in all honesty I can't bring myself to actually recommend my organization pay for the Rocket.Chat service when an issue like this still exists, and they are literally the only messaging platform who's client has this issue. I did raise this issue with the sales people that contacted me, only to never hear from them again regarding the issue being resolved.

Early 2022 will be the end of our use of Rocket.Chat in my organization. It was a great product with a lot of potential, but how can I recommend my organization pay for a product that ignores such a glaring issue for such a long period of time? When their Sales and Marketing are pushing the product towards the Enterprise market, having a way for end users to easily update their client is 100% required. Expecting the System Admins to manually manage upgrades for potentially hundreds or thousands of users is not practical.

We are transitioning staff to Microsoft 365 and using Teams in January of 2022.

@adipose
Copy link

adipose commented Dec 20, 2021

3.7.0 -> 3.7.1 update still doesn't work. Surprise surprise...

I opened this issue a year and a half ago. The issue itself has existed for as long as we've been using Rocket.Chat which is coming on 3.5 years now. Since then they have made push notifications a pay feature beyond 10K notifications (which I feel is a slimy way to "encourage" people to subscribe as Push Notifications cost them nothing and no other messaging platform charges for notifications). Their sales team has been in contact with my organization several times trying to get us to subscribe. But in all honesty I can't bring myself to actually recommend my organization pay for the Rocket.Chat service when an issue like this still exists, and they are literally the only messaging platform who's client has this issue. I did raise this issue with the sales people that contacted me, only to never hear from them again regarding the issue being resolved.

Early 2022 will be the end of our use of Rocket.Chat in my organization. It was a great product with a lot of potential, but how can I recommend my organization pay for a product that ignores such a glaring issue for such a long period of time? When their Sales and Marketing are pushing the product towards the Enterprise market, having a way for end users to easily update their client is 100% required. Expecting the System Admins to manually manage upgrades for potentially hundreds or thousands of users is not practical.

We are transitioning staff to Microsoft 365 and using Teams in January of 2022.

In the same boat. They have been spamming us with support offers. I considered bringing this issue up but I figured they wouldn't care.

Free products cannot be expected to be perfect but this seems like an easy one that affects a lot of people. Not too interested in becoming a customer when the basics don't work.

We also are going to Teams due to a 365 migration. I don't expect to love it, but I am tired of supporting this software. I submitted LDAP patches that took 2 years to even be reviewed. This issue I have been asking about for ages. If something so basic can't be fixed, I don't have high expectations for the future.

Maybe if they get some corporate money they will afford more bug fixes. But they just add pointless features, ignore important problems, and screw up push notifications to get money.

Get your house in order and then ask for money. I am not afraid to pay for open source software. But the free version should be as bug free as possible.

@KarimH22
Copy link

Hello @tassoevan
@jeanfbrito
@ggazzo

here the error seen on update , you know better the program than me to understand faster the issue
I collected the log
thanks
updateversionfailed.txt

@jeanfbrito
Copy link
Collaborator

Hello @tassoevan @jeanfbrito @ggazzo

here the error seen on update , you know better the program than me to understand faster the issue I collected the log thanks updateversionfailed.txt

Yeah! I found this too, I think that the certificate signing publisherName was wrong, I changed it and will be released a new version today. Hope that this fix the problem with Windows update finally.

@KarimH22
Copy link

Hello @tassoevan @jeanfbrito @ggazzo
here the error seen on update , you know better the program than me to understand faster the issue I collected the log thanks updateversionfailed.txt

Yeah! I found this too, I think that the certificate signing publisherName was wrong, I changed it and will be released a new version today. Hope that this fix the problem with Windows update finally.

Hi @jeanfbrito
I saw indeed that yaml file contained a personnal login, I installed the version 3.7.2
So let see at the next release
Thanks a lot :) 👍

@KarimH22
Copy link

Merry Xmas

@KarimH22
Copy link

Hello
Just taking the yaml file updated in the 3.7.2 version to put on my local version 3.6 and user only installation, it updated the Rocket Chat :)

I tried installing the version 3.6 for all users, updating the Yaml file , result , it saw the new version 3.7.2 to take, ask to install but it removed only the C:\Programmes\Rocket.Chat content no new file :-/
So I hope the other change done fixed that point

thanks a lot again @jeanfbrito

@KarimH22
Copy link

KarimH22 commented Dec 30, 2021

Hi
with version 3.7.2 installed for all, it updated properly to 3.7.4
I think you can close now this issue :)

thanks !

@pxlfrk
Copy link

pxlfrk commented Dec 30, 2021

Hi with version 3.7.2 installed for all, it updated properly to 3.7.4 I think you can close now this issue :)

thanks !

Can confirm, since release 3.7.2 Auto-Update is working again. Thanks for solving!
Hopefully abandoning important and user-disturbing issues like this get solved faster in the future..

@canuckbrian
Copy link
Author

Can confirm in our environment that this issue has been resolved too. Auto update now works since 3.7.2.

Too little too late for us though. Still moving to Teams in the New Year. Closing this issue.

@CFTechno
Copy link

CFTechno commented May 20, 2023

Still not resolved, had to download the installation file and reinstall over the old installation. W11, 64b version rocket.chat.

@jeanfbrito
Copy link
Collaborator

Still not resolved, had to download the installation file and reinstall over the old installation. W11, 64b version rocket.chat.

It was working on windows. Stopped working this time?
From what version to what version you updated?

@borisBelloc
Copy link

yeah the problem still happens with the last update.

@luison
Copy link

luison commented May 22, 2023

I seem to have the issue from 3.9.3 to 3.9.4
Offers update, install later... when the alert comes up "install now", rocket chat closes and nothing happens.
When you run it again remains in 3.9.3

@diegolmello
Copy link
Member

Just to help you isolate the issue: it worked from 3.9.3 -> 3.9.4 this morning on my Mac.

@jeanfbrito
Copy link
Collaborator

Yes, seems that we finally found the fix for MacOS but this break the Windows auto update.
Now we can have the both OS working then.

Next verison will have the fix, then version 3.9.5 ahead will work for MacOS and Windows.

@CFTechno
Copy link

Still not resolved, had to download the installation file and reinstall over the old installation. W11, 64b version rocket.chat.

It was working on windows. Stopped working this time? From what version to what version you updated?

to 3.9.4 from 3.9.3. 3.9.3 was my first ever installation of rocket.chat

@CFTechno
Copy link

and now again from 3.9.4 to 3.9.5

@fuzsin
Copy link

fuzsin commented Jun 19, 2023

and now again from 3.9.4 to 3.9.5

Same here (Windows 64 Bit)

@jeanfbrito
Copy link
Collaborator

Its fixed on 3.9.5. On the next update it will work again.

@reox
Copy link

reox commented Jun 19, 2023

Its fixed on 3.9.5. On the next update it will work again.

does it mean I have to install 3.9.5 manually, so the updates will work from now on, or will it work with the next update to 3.9.6?
The updater showed me 3.9.3 --> 3.9.5 but the update did not start...

@jeanfbrito
Copy link
Collaborator

Exactly, you need to install 3.9.5 manually, so the newer versions will auto update again.
The code that fixes it back in on 3.9.5 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests