chore: cleanup #149
Merged
chore: cleanup #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rachwalk
approved these changes
Aug 20, 2024
Comment on lines
+99
to
+112
| if vendor == "openai": | ||
| return [ | ||
| { | ||
| "type": "image_url", | ||
| "image_url": { | ||
| "url": f"data:image/jpeg;base64,{image}", | ||
| }, | ||
| } | ||
| for image in images | ||
| ] | ||
| else: | ||
| raise ValueError(f"Vendor {vendor} not supported") |
There was a problem hiding this comment.
TODO: Add an Issue for covering more vendors, mark Good first issue.
…hon modules for testing refactor(import_test): update test_can_import_all_modules_pathlib to use rai_python_modules for improved module import testing
…sses to simplify the codebase and improve maintainability
maciejmajek
force-pushed
the
chore/cleanup
branch
from
942d7e0 to
002b732
Compare
| @@ -68,6 +68,7 @@ class PubRos2MessageToolInput(BaseModel): | |||
|
|
|||
| # --------------------- Tools --------------------- | |||
| class Ros2BaseTool(BaseTool): | |||
| # TODO: Make the decision between rclpy.node.Node and RaiNode | |||
There was a problem hiding this comment.
FYI: using RaiNode here causes cicrular import error
There was a problem hiding this comment.
Yeah, had that problem. Importing under
if TYPECHECKING:
import ... RaiNode
# and then
node: "rclpy.node.Node | RaiNode"Does not work either. Nonetheless RaiNode is better suited here.
boczekbartek
approved these changes
Aug 20, 2024
Co-authored-by: Kajetan Rachwał <[email protected]>
rachwalk
added a commit
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Kajetan Rachwał <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Cleanup
Proposed Changes
Features:
Chores:
Issues
Testing