Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum node version, issue #528 #529

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Minimum node version, issue #528 #529

merged 2 commits into from
Oct 30, 2019

Conversation

wayneparrott
Copy link
Collaborator

Added notes and maximum node engine restriction to <11.0. See issue #528

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.913% when pulling e10bb8a on wayneparrott:minimum_node_version into 03ef3b4 on RobotWebTools:develop.

@minggangw minggangw self-requested a review October 30, 2019 03:03
minggangw
minggangw approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@minggangw minggangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch! LGTM

@minggangw minggangw merged commit 90ebf88 into RobotWebTools:develop Oct 30, 2019
minggangw pushed a commit to minggangw/rclnodejs-1 that referenced this pull request Oct 31, 2019
@wayneparrott
Minimum node version, issue RobotWebTools#528 (RobotWebTools#529)
1b0278f 
* Defined minimum node version, <11.0.0

* added Wayne to contributors list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minggangw minggangw minggangw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wayneparrott @coveralls @minggangw