Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max supported node/npm version not specified, leads to install errors #528

Closed
wayneparrott opened this issue Oct 28, 2019 · 2 comments
Closed

Comments

@wayneparrott
Copy link
Collaborator

While the README specifies the lowest supported version of node it does not specify the highest supported version of node.

Recently while getting familiar with rclnodejs, I immediately encountered an error when attempting to install the package (v0.10.2) with the latest versions of node and npm, v13.0 and v6.12 respectively. I systematically downgraded node and npm until I was able to install rclnodejs with node 10.17.9 and npm 6.11.3.

Propose updating the README and package.json to list 10.17.0 as the max supported version. I will be glad to submit a PR with these small but time saving changes if you agree.

@minggangw
Copy link
Member

Propose updating the README and package.json to list 10.17.0 as the max supported version. I will be glad to submit a PR with these small but time saving changes if you agree.

Of course, please go ahead to submit and you can add yourself as a contributor (https://github.com/RobotWebTools/rclnodejs#contributors) simultaneously if you like, thanks again!

Thanks for your finding! I also tested with the latest Erbium (v12.13.0) and had the same result, and I found the error is caused by the ref which the rclnodejs depends on heavily (I reckon this is a problem in the future, and the ref seems to be out of maintenance).

At the beginning of this project, I only indicated the minimum version of node.js, because we used some ES6 features which are not supported by the lower ones. As for now, I think we'd better point out the maximum version to avoid the confusion.

minggangw pushed a commit that referenced this issue Oct 30, 2019
* Defined minimum node version, <11.0.0

* added Wayne to contributors list
@minggangw
Copy link
Member

Close this issue, as 90ebf88 has landed.

minggangw pushed a commit to minggangw/rclnodejs-1 that referenced this issue Oct 31, 2019
* Defined minimum node version, <11.0.0

* added Wayne to contributors list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants