Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Enable SDP support in Clarabel #20475

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Nov 3, 2023

Towards #19449.

The release notes are "fix" because we need to list the new externals in the release notes.


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot mac-arm-ventura-clang-bazel-experimental-everything-release please

@jwnimmer-tri jwnimmer-tri added the release notes: fix This pull request contains fixes (no new features) label Nov 3, 2023
Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)


-- commits line 11 at r1:
Working

We need to itemize the new crates here, for the release notes to mention as new dependencies.

@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review November 3, 2023 20:27
@jwnimmer-tri
Copy link
Collaborator Author

+@rpoyner-tri for feature review, please.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers

Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@SeanCurtis-TRI for platform review, please.

Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform)


-- commits line 11 at r1:

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Working

We need to itemize the new crates here, for the release notes to mention as new dependencies.

Done.

Replace the LP example with an SDP example. (The LP capability has
already been covered by clarabel_solver_test.)

Patch Clarabel.rs to opt-out of Rust's choice of blas and lapack.

Add new externals to crate_universe:
- crate__blas-0.22.0
- crate__blas-sys-0.7.1
- crate__lapack-0.19.0
- crate__lapack-sys-0.14.0
- crate__libc-0.2.149
- crate__num-complex-0.4.4
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r3, all commit messages.
Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform)

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewed 7 of 17 files at r1, 10 of 10 files at r3, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),SeanCurtis-TRI(platform)

@SeanCurtis-TRI SeanCurtis-TRI merged commit 37e4bc7 into RobotLocomotion:master Nov 6, 2023
1 check passed
@jwnimmer-tri jwnimmer-tri deleted the clarabel-sdp branch November 6, 2023 21:20
ggould-tri pushed a commit to ggould-tri/drake that referenced this pull request Nov 9, 2023
Replace the LP example with an SDP example. (The LP capability has
already been covered by clarabel_solver_test.)

Patch Clarabel.rs to opt-out of Rust's choice of blas and lapack.

Add new externals to crate_universe:
- crate__blas-0.22.0
- crate__blas-sys-0.7.1
- crate__lapack-0.19.0
- crate__lapack-sys-0.14.0
- crate__libc-0.2.149
- crate__num-complex-0.4.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: fix This pull request contains fixes (no new features)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants