-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] Enable SDP support in Clarabel #20475
[workspace] Enable SDP support in Clarabel #20475
Conversation
@drake-jenkins-bot mac-arm-ventura-clang-bazel-experimental-everything-release please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)
-- commits
line 11 at r1:
Working
We need to itemize the new crates here, for the release notes to mention as new dependencies.
+@rpoyner-tri for feature review, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)
ddcb82a
to
32d76b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@SeanCurtis-TRI for platform review, please.
Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform)
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Working
We need to itemize the new crates here, for the release notes to mention as new dependencies.
Done.
Replace the LP example with an SDP example. (The LP capability has already been covered by clarabel_solver_test.) Patch Clarabel.rs to opt-out of Rust's choice of blas and lapack. Add new externals to crate_universe: - crate__blas-0.22.0 - crate__blas-sys-0.7.1 - crate__lapack-0.19.0 - crate__lapack-sys-0.14.0 - crate__libc-0.2.149 - crate__num-complex-0.4.4
32d76b8
to
b4b542f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r3, all commit messages.
Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 17 files at r1, 10 of 10 files at r3, all commit messages.
Reviewable status: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),SeanCurtis-TRI(platform)
Replace the LP example with an SDP example. (The LP capability has already been covered by clarabel_solver_test.) Patch Clarabel.rs to opt-out of Rust's choice of blas and lapack. Add new externals to crate_universe: - crate__blas-0.22.0 - crate__blas-sys-0.7.1 - crate__lapack-0.19.0 - crate__lapack-sys-0.14.0 - crate__libc-0.2.149 - crate__num-complex-0.4.4
Towards #19449.
The release notes are "fix" because we need to list the new externals in the release notes.
This change is