-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tease apart models_filegroup vs install_data #18923
Tease apart models_filegroup vs install_data #18923
Conversation
009b690
to
6f1f821
Compare
6f1f821
to
1ece06b
Compare
+@EricCousineau-TRI I think you get right of first refusal for this review. If you're busy, we can push it to @sammy-tri instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 34 of 34 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform) (waiting on @EricCousineau-TRI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, beautimous! Small nit on globbing, though maybe it's pre-existing.
Reviewed 23 of 34 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)
tools/skylark/drake_data.bzl
line 36 at r2 (raw file):
] exclude = glob_exclude + [ "**/test/*",
nit (pre-existing) It's not clear to me how intuitive this exclude pattern will be for testonly = True
.
Possible options:
- TODO
glob_exclude
gains these defaults only whentestonly = False
- The default values are these, explicitly, perhaps via global constant
DEFAULT_GLOB_EXCLUDE
, but users can override them. Docstring says they should?
Delete unused PendulumWithFriction.urdf.
1ece06b
to
e6745c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion (waiting on @EricCousineau-TRI)
tools/skylark/drake_data.bzl
line 36 at r2 (raw file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
nit (pre-existing) It's not clear to me how intuitive this exclude pattern will be for
testonly = True
.Possible options:
- TODO
glob_exclude
gains these defaults only whentestonly = False
- The default values are these, explicitly, perhaps via global constant
DEFAULT_GLOB_EXCLUDE
, but users can override them. Docstring says they should?
Aha! Thanks, I'd meant to circle back here and totally forgot.
There are no tests that use this. I've update the docs.
PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform) (waiting on @jwnimmer-tri)
tools/skylark/drake_data.bzl
line 36 at r2 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Aha! Thanks, I'd meant to circle back here and totally forgot.
There are no tests that use this. I've update the docs.
PTAL.
OK Sweet ,thanks!
Delete unused PendulumWithFriction.urdf.
Delete unused
PendulumWithFriction.urdf
.I've tested locally and the list of installed files is the same between this PR and the master branch.
Closes #11010.
Towards #15774.
FYI https://drake.mit.edu/stable.html#model-files
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)