-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parsing: Remove implicit frames created for nested models #15208
parsing: Remove implicit frames created for nested models #15208
Conversation
@drake-jenkins-bot retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@EricCousineau-TRI for feature review, please.
Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform), needs at least two assigned reviewers (waiting on @EricCousineau-TRI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for delay, and looks good! Though needs downstream testing.
As this is a small change, I'm fine with serving as platform as well if there are no downstream issues.
Reviewed 2 of 2 files at r1.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee EricCousineau-TRI(platform), needs at least two assigned reviewers (waiting on @EricCousineau-TRI)
a discussion (no related file):
Working: Testing on Anzu CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+(status: single reviewer ok)
x 2 given that we have not broken Anzu CI - thanks!!!
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @azeey)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Working: Testing on Anzu CI.
Done. Anzu CI just passed; PR 7180, job 1. Sweet!
CI failure seems like a flake: https://drake-jenkins.csail.mit.edu/job/linux-bionic-gcc-bazel-experimental-release/9964/consoleFull
Retesting: |
This removes additional implicit model frames created for nested models that were missed in #15099.
/cc @EricCousineau-TRI
This change is