Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing: Remove implicit frames created for nested models #15208

Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jun 17, 2021

This removes additional implicit model frames created for nested models that were missed in #15099.

/cc @EricCousineau-TRI


This change is Reviewable

@EricCousineau-TRI
Copy link
Contributor

@drake-jenkins-bot retest this please

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@EricCousineau-TRI for feature review, please.

Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform), needs at least two assigned reviewers (waiting on @EricCousineau-TRI)

Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay, and looks good! Though needs downstream testing.

As this is a small change, I'm fine with serving as platform as well if there are no downstream issues.

Reviewed 2 of 2 files at r1.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee EricCousineau-TRI(platform), needs at least two assigned reviewers (waiting on @EricCousineau-TRI)

a discussion (no related file):
Working: Testing on Anzu CI.


@EricCousineau-TRI EricCousineau-TRI added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Jun 22, 2021
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: single reviewer ok)
:lgtm: x 2 given that we have not broken Anzu CI - thanks!!!

Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @azeey)

a discussion (no related file):

Previously, EricCousineau-TRI (Eric Cousineau) wrote…

Working: Testing on Anzu CI.

Done. Anzu CI just passed; PR 7180, job 1. Sweet!


@EricCousineau-TRI
Copy link
Contributor

CI failure seems like a flake: https://drake-jenkins.csail.mit.edu/job/linux-bionic-gcc-bazel-experimental-release/9964/consoleFull

[5:00:38 PM]  INFO: From Testing //manipulation/util:py/show_model_test:
...
[5:00:38 PM]  FileNotFoundError: [Errno 2] No such file or directory: '/home/ubuntu/.cache/matplotlib/fontList.json'
...
[5:00:38 PM]  OSError: [Errno 30] Read-only file system: '/home/ubuntu/.cache/matplotlib/fontList.json'

Retesting:
@drake-jenkins-bot linux-bionic-gcc-bazel-experimental-release please

@EricCousineau-TRI
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label Jun 22, 2021
@EricCousineau-TRI EricCousineau-TRI merged commit 248db43 into RobotLocomotion:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: single reviewer ok https://drake.mit.edu/reviewable.html status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants