Migrate to new CcInfo, JavaInfo, and PyInfo Starlark APIs #11375
Conversation
jamiesnape
added
component: distribution
|
+@jwnimmer-tri for feature review. |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers (waiting on @jwnimmer-tri)
|
+@EricCousineau-TRI for additional feature and platform review of the pybind.bzl changes please. (I am checking on the install.bzl changes locally, and seeing some confusing results. Probably PEBKAC but I'll report back once I understand.) |
There was a problem hiding this comment.
(My problem was I'd assumed that bazel-bin/install worked; it doesn't work on master and probably has never worked.)
Reviewed 1 of 2 files at r1.
Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status:complete! all discussions resolved, LGTM from assignees jwnimmer-tri(platform),EricCousineau-TRI(platform)
Fixes #11374. Relates bazelbuild/bazel#7298 and bazelbuild/bazel#7036. Immediately necessary to fix building binary packages on Mac.
This change is