Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate parameter name #27

Closed
wants to merge 2 commits into from
Closed

duplicate parameter name #27

wants to merge 2 commits into from

Conversation

kwiatkk1
Copy link

Hi,

I've noticed that serialization of a large number of variables can lead to unexpected problems because getName function can produce duplicates:

  • getName(230) =>do_; (reserved word do + _ suffix)
  • getName(12526) => do_; (created "regularly")

Using any number as a suffix to alter reserved word is safe:

  • number won't be at the beginning of an identifier
  • numbers are not included in chars that are used to generate names, so no risk of duplicates

@Rich-Harris
Copy link
Owner

thank you — closing in favour of #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants