Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a large state is incorrectly serialized to __NUXT__ #11

Closed
kwiatkk1 opened this issue Jan 27, 2021 · 2 comments · Fixed by #12
Closed

a large state is incorrectly serialized to __NUXT__ #11

kwiatkk1 opened this issue Jan 27, 2021 · 2 comments · Fixed by #12

Comments

@kwiatkk1
Copy link

problem:

  • If a state is built of many object (12526+), then it is incorrectly serialized and may lead to unexpected behaviour on a rehydration. It happened in my nuxt-based app.

I found the reason of this: it's a bug in devalue library.
I made a pull-request there with a fix:

I'm creating this bug report here, because:

  • I want to let you know and you may be interested in applying this also in the @nuxt/devalue
  • @nuxt/devalue has "issues" feature disabled, so I cannot report it there
@pi0 pi0 transferred this issue from nuxt/nuxt Jan 27, 2021
@pi0
Copy link
Member

pi0 commented Jan 27, 2021

Hi @kwiatkk1 thanks for updating here and also enabled issues (don't know why was disabled). Feel free making same PR as well.

@kwiatkk1
Copy link
Author

Sure thing! Done! Thanks!

@pi0 pi0 closed this as completed in #12 Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants