Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .env file to investigate it's impact on project (#624) #632

Closed

Conversation

Joranhezon
Copy link

Context

Summary of Changes

  • Delete .env file.

Checklist

  • Tested Mobile Responsiveness
  • Added Unit Tests
  • CI Passes
  • Deploys to Heroku on test Correctly (Maintainers will handle)
  • Added Documentation (Service and Code when required)

Screenshots

After

Screenshot from 2020-07-10 10-53-10

Before

Screenshot from 2020-07-10 11-01-10

@Joranhezon
Copy link
Author

It seems that deleting the file won't solve the problem, since it breaks the app.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Jul 10, 2020

@Joranhezon thanks for trying this. I will look at what changed and try to understand.

The other maintainers have set up this part of the app, so I am a bit behind on knowledge of this area.

(As always, @tkwidmer @mi-wood if you know the answer to this one, and you have a free bit of time, feel free to elucidate!)

Will keep trying to get to the bottom of it. 👍

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Jul 10, 2020

There is also #626, which may be a real solution. But by trying something more dramatic, hopefully the errors will shed light on the technical details of why we need (or don't need?) these variables.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Jul 10, 2020

Continuous integration tests passed, https://travis-ci.com/github/RefugeRestrooms/refugerestrooms/builds/175162554, so I think if there are problems they are in areas that we don't have tests for.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Nov 9, 2020

I have found that without this .env file, the RECAPTCHA_SITE_KEY and RECAPTCHA_SECRET_KEY environment variables are unset, and recaptcha no-longer works in local testing with Docker.

(Apparently these keys are set to work on localhost only, so having them out in the open is not a concern, with regard to someone potentially abusing these keys.)

Given that there is some usefulness to this file, I am planning to keep it for the time being. Thanks again for taking an interest and helping to look into this. As a late-comer to this project, I am always learning more about its codebase. This helped me understand why we need this file. 👍

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Nov 9, 2020

Closing, as it turns out we want to keep this file after all.

@DeeDeeG DeeDeeG closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.env file variable syntax is not compatible with latest docker-compose version 1.25.5
2 participants