Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VAR=VAL syntax for environment variables #626

Closed
wants to merge 2 commits into from

Conversation

piercebb
Copy link
Contributor

@piercebb piercebb commented Jun 23, 2020

Context

Summary of Changes

  • Use VAR=VAL syntax for default environment variables
  • Remove export VAR= syntax

Checklist

  • Tested Mobile Responsiveness
  • Added Unit Tests
  • CI Passes
  • Deploys to Heroku on test Correctly (Maintainers will handle)
  • Added Documentation (Service and Code when required)

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Jun 23, 2020

Paging @tkwidmer and @mi-wood, I think one of you (or both of you!) would know about this.

Do we need any of the environment variables in .env in this repo outside of Docker? Like in production/Heroku?

If you get the time to look at this, thanks in advance.

Edit: If so, how can we confirm they work without using export, but just plain setting them with var=value syntax?

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Dec 18, 2022

This change was eventually made in #675.

Thank you for pointing out this fix.

(I will close this as it is redundant to the change from #675.)

@DeeDeeG DeeDeeG closed this Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.env file variable syntax is not compatible with latest docker-compose version 1.25.5
3 participants