Adds translation for miles/kilometers #524

shadowmaru · 2018-10-30T21:46:31Z

Context

In the search results page the terms 'miles' and 'kilometers' weren't translated

Summary of Changes

adds the keys restroom.distance.miles and restroom.distance.kilometers
adds the translation for all languages (via Google Translator, please review)

Checklist

Tested Mobile Responsiveness
Added Unit Tests
CI Passes
Deploys to Heroku on test Correctly (Maintainers will handle)
Added Documentation (Service and Code when required)

Screenshots

Before

After

DeeDeeG · 2018-10-31T00:22:36Z

config/locales/pl/restroom.pl.yml

@@ -20,6 +20,9 @@ pl:
    guess_location: 'Obecna lokalizacja urządzenia'
    directions: 'Wskazówki'
    directions_hint: '(np.: na trzecim piętrze, obok baru, koło przebieralni...)'
+    distance:
+      miles: mile


Suggested change

miles: mile

miles: mil

I think? (From some online dictionaries.)

I honestly have no idea. Polish is the one language here that I have no clue.

DeeDeeG · 2018-10-31T00:32:53Z

Thanks for this. I am taking a look now.

I am surprised there is no obvious gem for official Rails translations for these.

(I'm also not sure whether it makes sense to ping everyone who has submitted or reviewed these languages, but we could do that to get it 100% right.)

DeeDeeG · 2018-11-05T17:24:46Z

Rather than guess, I am planning to reach out to our previous contributors to Polish and French.

with French, google translate hints to me that some French speakers are using "mile" as a loan word from English, where others are using "milles". (Which in conversation would just sound like "thousands"?? Maybe confusing, hence the loan word?)

And with Polish, the online translation doesn't give me a ton of confidence, like it's guessing from too little data.

My inferences/guesses aside, it would be nice to get someone who actually knows these languages!

I am reasonably confident in the other translations, but might still reach out to contributors for those languages in case they want to give the thumbs up or suggest corrections.

DeeDeeG · 2018-11-05T17:33:16Z

config/locales/fr/restroom.fr.yml

@@ -20,6 +20,9 @@ fr:
    guess_location: 'Trouver ma position actuelle'
    directions: 'Indications'
    directions_hint: "(ex: troisième étage au fond, à coté des cabines d'essayage...)"
+    distance:
+      miles: milles
+      kilometers: kilomètres


Hello, @BertrandClosset, @TiteiKo.

Sorry to bother you... It has been a while since you contributed the French translation for Refuge Restrooms (#450).

We are trying to add proper translation of "miles" and "kilometers" to the website, and so I wonder if you could help by checking if this new translation is correct, or suggest a better translation?

Thank you very much.

Sincerely,

- DeeDeeG

Hi @DeeDeeG,

No problem, it's always a pleasure to help. In my opinion, there is nothing to change to this translation ;)

Bertrand

DeeDeeG · 2018-11-05T17:40:05Z

config/locales/pl/restroom.pl.yml

@@ -20,6 +20,9 @@ pl:
    guess_location: 'Obecna lokalizacja urządzenia'
    directions: 'Wskazówki'
    directions_hint: '(np.: na trzecim piętrze, obok baru, koło przebieralni...)'
+    distance:
+      miles: mile
+      kilometers: kilometrów


Hi, @tusindfryd, @katafrakt.

It has been a while since you contributed the Polish translation for Refuge Restrooms (#475), so I'm sorry to bother you if you are busy.

In any case, we are now trying to add translations for the words "mile" and "kilometer", but we only have a machine translation from Google Translate so far. I am wondering if you could confirm that this translation looks good, or suggest the correct translation?

Thank you very much.

Sincerely,

- DeeDeeG

Hi,

In Polish numerals differ slightly: 1 kilometr, 2 - 4 kilometry, 5 - 21 kilometrów, 22 - 24 kilometry, 25 - 31 kilometrów, and so on. I think I would personally go with just writing km tbh.

With miles it would be: 1 mila, 2 - 4 mile, 5 - 21 mil, 22 - 24 mile, 25 - 31 mil, and so on. There is no abbreviation for miles in Polish, but no one uses them, so ¯\_(ツ)_/¯

So yeah. That's fun.

Hmm.

Thank you for the information. I suppose we'll have to think of how we want to do this.

There are ways in Rails to use different pluralizations for different numbers. But it would be a bit trickier to set up. And I'm a little nervous at adding math and branching if - then logic in the results page for performance and complexity reasons. But it is possible.

Wow, it's really interesting the way Polish handles numbers and plurals. Maybe we should go with the abbreviations ('km' and 'mi') anyway in this case.

DeeDeeG · 2018-11-05T17:42:18Z

In other news, today I learned that the word "mile" literally comes from "a thousand", as in "a thousand paces."

https://en.wiktionary.org/wiki/mile#Etymology

micahcochran · 2018-11-07T15:29:06Z

It looks like Wikidata has a few translations "mile", under its unit symbol. Those may be abbreviations.
https://www.wikidata.org/wiki/Q253276

Wikidata also has unit symbols for kilometer. Those may or may not be abbreviations.
https://www.wikidata.org/wiki/Q828224

DeeDeeG · 2018-11-07T16:10:12Z

@micahcochran thanks for that resource.

I looked at the "in more languages" tables on Wikidata, and the translations we have here (from Google Translate) match with those translations (on Wikidata). So that does bring my confidence up just a bit more.

With regard to Polish: I am leaning toward using the suggestion from @tusindfryd, to use "km" instead of all the different pluralizations for 1, 2-4, 5-21, etc. And we can use "mi" for "miles" alongside "km" for "kilometers".

@shadowmaru would you want to update the Polish translation to use "km" and "mi"? Would you rather I do that?

After we update Polish as just mentioned, I think we can merge this. Thanks again, everybody!

shadowmaru · 2018-11-09T23:00:21Z

With regard to Polish: I am leaning toward using the suggestion from @tusindfryd, to use "km" instead of all the different pluralizations for 1, 2-4, 5-21, etc. And we can use "mi" for "miles" alongside "km" for "kilometers".

@shadowmaru would you want to update the Polish translation to use "km" and "mi"? Would you rather I do that?

@DeeDeeG Sure, I can do that!

DeeDeeG · 2018-11-14T15:30:35Z

Also, now that we have Hindi (#503), we should add a Hindi translation as well.

https://translate.google.com says:

miles: मील की दूरी पर

kilometers: किलोमीटर की दूरी पर

("miles away" and "kilometers away", respectively)

But I'm not clear if just this would work:

miles: मील

kilometers: किलोमीटर

("mile" and "kilometer", respectively)

Or if Google Translate is wrong.

@ashishwadekar, @sankalpchauhan-me, We are trying to translate "kilometers" and "miles" in this pull request (#524). If either of you could comment what the correct translation is, it would be appreciated much, and would help us add the correct translation to Refuge Restrooms. Thank you very much once again.

Sincerely,

- DeeDeeG

ashishwadekar · 2018-11-14T18:03:50Z

Also, now that we have Hindi (#503), we should add a Hindi translation as well.

https://translate.google.com says:
miles: मील की दूरी पर

kilometers: किलोमीटर की दूरी पर
("miles away" and "kilometers away", respectively)

But I'm not clear if just this would work:
miles: मील

kilometers: किलोमीटर
Or if Google Translate is wrong.

@ashishwadekar, @sankalpchauhan-me, We are trying to translate "kilometers" and "miles" in this pull request (#524). If either of you could comment what the correct translation is, it would be appreciated much, and would help us add the correct translation to Refuge Restrooms. Thank you very much once again.

Sincerely,

DeeDeeG

@DeeDeeG Thanks for putting that in context.

What we are talking here is about units of distance measurement. So the below mentioned translation is correct.

28 miles: २८  मील 
28 kilometers: २८  किलोमीटर

Google translation is being done as a part of grammar consideration. To clarify more:

28 miles away: २८ मील की दूरी पर
28 kilometers away: २८ किलोमीटर की दूरी पर

Hope this clears the confusion. Let me know if you need more help on this.

Cheers,
Ashish

DeeDeeG · 2018-11-14T18:47:16Z

@ashishwadekar, thanks for your response.

Based on your explanation, I think we can go with the shorter version:

miles: मील

kilometers: किलोमीटर

ashishwadekar · 2018-11-14T18:48:20Z

Sure @DeeDeeG

Cheers

DeeDeeG · 2018-11-14T19:11:13Z

Sorry to add things on, and create a bit of a moving target for finishing this pull request, @shadowmaru; If we can add the translation for Hindi as follows:

distance:
  miles: मील
  kilometers: किलोमीटर

that should be enough to finish up this pull request. Once again, whichever is most convenient/preferred, I am happy to add this or let you do it whenever you get the chance.

In any case, we are close to the finish line on this.

Best regards,

- DeeDeeG

P.S. If you need to overwrite the merge I just did, feel free to force push to your develop branch. Sorry if that merge commit gets in the way at all.

P.P.S: I made a backup branch, in case any commits in this branch get deleted by accident. https://github.com/DeeDeeG/refugerestrooms/tree/shadowmaru-develop-2

mi-wood

I'm going to move forward with this and make a note to add to the recent Hindi translation once merged.

mi-wood · 2018-11-24T19:40:19Z

Thank you @shadowmaru and other folks who chimed in!

DeeDeeG · 2018-11-24T19:47:30Z

Would like to add Co-authored-by: <name.> <email> for a few people to this merge, in the commit message:

@ashishwadekar
@BertrandClosset
@tusindfryd

potentially:

@micahcochran
@shadowmaru (although commit authorship is already there for several commits, so might seem redundant)

DeeDeeG · 2018-11-24T19:47:52Z

Also, I could add the Hindi translation in here real quick before we merge.

mi-wood · 2018-11-24T19:51:29Z

Not going to stop you. I'll leave it up

DeeDeeG · 2018-11-24T19:52:41Z

Thanks!

@ashishwadekar

Thanks for verifying this translation, @ashishwadekar Co-authored-by: Ashish Wadekar <[email protected]>

Adds translation for miles/kilometers

314ff21

DeeDeeG reviewed Oct 31, 2018

View reviewed changes

DeeDeeG added enhancement Ready for Review Hacktoberfest These are issues or pull requests related to Hacktoberfest (https://hacktoberfest.digitalocean.com/) translations labels Nov 2, 2018

DeeDeeG reviewed Nov 5, 2018

View reviewed changes

Abbreviates mile and kilometer for Polish

fbe9e0c

Merge branch 'develop' into develop

afa2b0c

Merge branch 'develop' into develop

7ffbf0d

mi-wood previously approved these changes Nov 24, 2018

View reviewed changes

restroom.hi.yml: Add distance translations for 524

e13ed41

Thanks for verifying this translation, @ashishwadekar Co-authored-by: Ashish Wadekar <[email protected]>

DeeDeeG dismissed mi-wood’s stale review via e13ed41 November 24, 2018 19:56

DeeDeeG merged commit 6ac24ac into RefugeRestrooms:develop Nov 24, 2018

DeeDeeG mentioned this pull request Dec 23, 2018

Translations for EN to FIL Issue 451 #556

Closed

DeeDeeG removed Ready for Review labels Feb 7, 2019

DeeDeeG mentioned this pull request Oct 5, 2019

Requesting for Filipino Translation #451

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds translation for miles/kilometers #524

Adds translation for miles/kilometers #524

shadowmaru commented Oct 30, 2018 •

edited by DeeDeeG

Loading

DeeDeeG Oct 31, 2018

shadowmaru Nov 5, 2018

DeeDeeG commented Oct 31, 2018

DeeDeeG commented Nov 5, 2018

DeeDeeG Nov 5, 2018

vancloss Nov 5, 2018

DeeDeeG Nov 6, 2018

DeeDeeG Nov 5, 2018

nonnullish Nov 5, 2018 •

edited

Loading

DeeDeeG Nov 5, 2018

shadowmaru Nov 9, 2018

DeeDeeG commented Nov 5, 2018

micahcochran commented Nov 7, 2018

DeeDeeG commented Nov 7, 2018 •

edited

Loading

shadowmaru commented Nov 9, 2018

DeeDeeG commented Nov 14, 2018 •

edited

Loading

ashishwadekar commented Nov 14, 2018

DeeDeeG commented Nov 14, 2018

ashishwadekar commented Nov 14, 2018

DeeDeeG commented Nov 14, 2018 •

edited

Loading

mi-wood left a comment

mi-wood commented Nov 24, 2018

DeeDeeG commented Nov 24, 2018

DeeDeeG commented Nov 24, 2018

mi-wood commented Nov 24, 2018

DeeDeeG commented Nov 24, 2018

Adds translation for miles/kilometers #524

Adds translation for miles/kilometers #524

Conversation

shadowmaru commented Oct 30, 2018 • edited by DeeDeeG Loading

Context

Summary of Changes

Checklist

Screenshots

Before

After

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DeeDeeG commented Oct 31, 2018

DeeDeeG commented Nov 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nonnullish Nov 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DeeDeeG commented Nov 5, 2018

micahcochran commented Nov 7, 2018

DeeDeeG commented Nov 7, 2018 • edited Loading

shadowmaru commented Nov 9, 2018

DeeDeeG commented Nov 14, 2018 • edited Loading

ashishwadekar commented Nov 14, 2018

DeeDeeG commented Nov 14, 2018

ashishwadekar commented Nov 14, 2018

DeeDeeG commented Nov 14, 2018 • edited Loading

mi-wood left a comment

Choose a reason for hiding this comment

mi-wood commented Nov 24, 2018

DeeDeeG commented Nov 24, 2018

DeeDeeG commented Nov 24, 2018

mi-wood commented Nov 24, 2018

DeeDeeG commented Nov 24, 2018

shadowmaru commented Oct 30, 2018 •

edited by DeeDeeG

Loading

nonnullish Nov 5, 2018 •

edited

Loading

DeeDeeG commented Nov 7, 2018 •

edited

Loading

DeeDeeG commented Nov 14, 2018 •

edited

Loading

DeeDeeG commented Nov 14, 2018 •

edited

Loading