-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hindi Translations Added under config/locales/hi #503
Hindi Translations Added under config/locales/hi #503
Conversation
Wow, @sankalpchauhan-me thank you for doing this! It has been a while since that issue was posted, I was almost expecting that we might never receive this translation. I will take a look at the error message at Travis and see what might be the issue, but overall these translations look very good. Usually we like to have a second native speaker look over any new translation to be sure it is correct. We can look for another person who might be able to review this. Also, if you know someone who might be willing to review and give feedback on the translations, it might speed up the time it takes to review this PR. Thanks again! |
Forgot a ' on line 42
Removed an extra quotation mark ' at line 59
I have corrected the errors reported by Travis CI, the build is now passing. |
Thank you very much! All that is left is to find another native speaker of Hindi, so we can review the actual translations. Once such a review has happened, we would be glad to merge. (If for some reason we can't find a reviewer for a long time, we may review using Google Translate just to make sure this can go live at refugerestrooms.org, rather than sitting as a Pull Request forever.) We appreciate this contribution very much. And happy Hacktoberfest! 🎃 💻 🍂 ✨ |
Happy Hacktoberfest to you too @DeeDeeG |
I put out a tweet to see if someone can review this: https://twitter.com/REFUGErestrooms/status/1049416630604689410 |
Thank you, @mi-wood! |
Hi @ashishwadekar, It has been some time since you initially submitted issue #431 to our repository, and someone has now submitted a Hindi translation for Refuge Restrooms. Would you be interested in reviewing this translation for accuracy, and suggesting any improvements you think it needs? Best regards, - DeeDeeG |
Hi @DeeDeeG Sure, I am more than happy to review translation and post my suggestions here. Cheers, |
Hi @sankalpchauhan-me @DeeDeeG The translation looks good to me. बोहोत हि उम्दा काम किया है अपने (You have done a fantastic job) @sankalpchauhan-me few suggestions to make translation better: संसाधन पन्ना बारे में पन्ना Also, Please add :hi to config.i18n.available_locales in application.rb Cheers, |
Thank you for the review, @ashishwadekar! |
@ashishwadekar @DeeDeeG I have committed the required changes. |
Thanks @sankalpchauhan-me! I should be able to take a look at this within the next couple of days and merge. |
I "deployed" a copy of this branch, so anyone can take a look at it, here: Edit to add: see also https://staging.refugerestrooms.org/ And here is a video capture of what it looks like, also: |
@DeeDeeG @sankalpchauhan-me The changes look good. Cheers 👍 |
Alright, it is merged now;,thanks very much to both of you, @sankalpchauhan-me and @ashishwadekar! |
Everything looks good in the deployment, as the PR is merged I am deleting my copy of the branch i.e.sankalpchauhan-me:hindi-translations-develop, I will keep contributing to the project in future. |
I am a self taught Native Android Developer currently pursuing my Bachelors of Technology in Information Technology @DeeDeeG if there is some Native Android App of this project, I could contribute to that. |
@sankalpchauhan-me we would be happy to have contributions over at our Android app, here: https://github.com/RefugeRestrooms/refugerestrooms-android/ ! We might not be able to review pull requests right away, as our maintainers there are somewhat busy, but contributions are still appreciated, and hopefully we can get to them soon. |
Context
Summary of Changes
Checklist
No changes were made to existing code base total 14 files added in config/locales/hi
I have changed the top line of each file from en: -> hi: as mentioned by @DeeDeeG in Issue Hindi Translation #431
I have renamed every file from filename.en.yml to filename.hi.yml as mentioned by @DeeDeeG in Issue Hindi Translation #431 . except for the file buisness_info.yml as it did not contain the keyword 'en'.
Translated only to the right of a colon : from English into Hindi.
-hello: 'hello!' --> hello: 'नमस्ते!' (as mentioned by @DeeDeeG in Issue Hindi Translation #431)
Tested Mobile Responsiveness
Added Unit Tests
CI Passes
Deploys to Heroku on test Correctly (Maintainers will handle)
Added Documentation (Service and Code when required)
Screenshots
N/A
Before
After