Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hindi Translations Added under config/locales/hi #503

Merged
merged 7 commits into from
Nov 14, 2018
Merged

Hindi Translations Added under config/locales/hi #503

merged 7 commits into from
Nov 14, 2018

Conversation

sankalpchauhan-me
Copy link
Contributor

@sankalpchauhan-me sankalpchauhan-me commented Oct 3, 2018

Context

  • Fixes Hindi Translation #431
  • I have added Hindi translations to all the files present in config/locales/en then I saved the translations to a new folder at config/locales/hi

Summary of Changes

  • All the translations are correct to the best of my knowledge (I am a native Hindi speaker and have full professional proficiency in English)
  • All files are translated by me except config/locales/hi/devise.hi.yml for this particular file I have used the original source mentioned in the file i.e. https://github.com/plataformatec/devise/wiki/I18n
  • I have not translated commented lines in documents, as they won't be visible in the actual app

Checklist

  • No changes were made to existing code base total 14 files added in config/locales/hi

  • I have changed the top line of each file from en: -> hi: as mentioned by @DeeDeeG in Issue Hindi Translation #431

  • I have renamed every file from filename.en.yml to filename.hi.yml as mentioned by @DeeDeeG in Issue Hindi Translation #431 . except for the file buisness_info.yml as it did not contain the keyword 'en'.

  • Translated only to the right of a colon : from English into Hindi.
    -hello: 'hello!' --> hello: 'नमस्ते!' (as mentioned by @DeeDeeG in Issue Hindi Translation #431)

  • Tested Mobile Responsiveness

  • Added Unit Tests

  • CI Passes

  • Deploys to Heroku on test Correctly (Maintainers will handle)

  • Added Documentation (Service and Code when required)

Screenshots

N/A

Before

After

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Oct 4, 2018

Wow, @sankalpchauhan-me thank you for doing this! It has been a while since that issue was posted, I was almost expecting that we might never receive this translation.

I will take a look at the error message at Travis and see what might be the issue, but overall these translations look very good.

Usually we like to have a second native speaker look over any new translation to be sure it is correct. We can look for another person who might be able to review this. Also, if you know someone who might be willing to review and give feedback on the translations, it might speed up the time it takes to review this PR.

Thanks again!

@DeeDeeG DeeDeeG added Hacktoberfest These are issues or pull requests related to Hacktoberfest (https://hacktoberfest.digitalocean.com/) Ready for Review translations labels Oct 4, 2018
Forgot a ' on line 42
Removed an extra quotation mark ' at line 59
@sankalpchauhan-me
Copy link
Contributor Author

I have corrected the errors reported by Travis CI, the build is now passing.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Oct 4, 2018

Thank you very much!

All that is left is to find another native speaker of Hindi, so we can review the actual translations. Once such a review has happened, we would be glad to merge. (If for some reason we can't find a reviewer for a long time, we may review using Google Translate just to make sure this can go live at refugerestrooms.org, rather than sitting as a Pull Request forever.)

We appreciate this contribution very much. And happy Hacktoberfest! 🎃 💻 🍂 ✨

@sankalpchauhan-me
Copy link
Contributor Author

Happy Hacktoberfest to you too @DeeDeeG

@mi-wood
Copy link
Member

mi-wood commented Oct 8, 2018

I put out a tweet to see if someone can review this: https://twitter.com/REFUGErestrooms/status/1049416630604689410

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Oct 8, 2018

Thank you, @mi-wood!

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Oct 31, 2018

Hi @ashishwadekar,

It has been some time since you initially submitted issue #431 to our repository, and someone has now submitted a Hindi translation for Refuge Restrooms. Would you be interested in reviewing this translation for accuracy, and suggesting any improvements you think it needs?

Best regards,

- DeeDeeG

@ashishwadekar
Copy link
Contributor

Hi @DeeDeeG

Sure, I am more than happy to review translation and post my suggestions here.

Cheers,
Ashish

@ashishwadekar
Copy link
Contributor

ashishwadekar commented Nov 4, 2018

Hi @sankalpchauhan-me @DeeDeeG

The translation looks good to me. बोहोत हि उम्दा काम किया है अपने (You have done a fantastic job)

@sankalpchauhan-me few suggestions to make translation better:

संसाधन पन्ना
साइन्स -> प्रतिक

बारे में पन्ना
सरलपुर्वक -> सरलतापूर्वक
बच्चे -> व्यक्ति

Also, Please add :hi to config.i18n.available_locales in application.rb

Cheers,
Ashish

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Nov 5, 2018

Thank you for the review, @ashishwadekar!

@sankalpchauhan-me
Copy link
Contributor Author

@ashishwadekar @DeeDeeG I have committed the required changes.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Nov 13, 2018

Thanks @sankalpchauhan-me! I should be able to take a look at this within the next couple of days and merge.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Nov 13, 2018

I "deployed" a copy of this branch, so anyone can take a look at it, here:
https://refuge-cedar-14.herokuapp.com/

Edit to add: see also https://staging.refugerestrooms.org/

And here is a video capture of what it looks like, also:
refugerestrooms-hindi-translation-mp4.zip

@ashishwadekar
Copy link
Contributor

@DeeDeeG @sankalpchauhan-me The changes look good. Cheers 👍

@DeeDeeG DeeDeeG merged commit 7f22212 into RefugeRestrooms:develop Nov 14, 2018
@DeeDeeG
Copy link
Contributor

DeeDeeG commented Nov 14, 2018

Alright, it is merged now;,thanks very much to both of you, @sankalpchauhan-me and @ashishwadekar!

@sankalpchauhan-me sankalpchauhan-me deleted the hindi-translations-develop branch November 15, 2018 18:35
@sankalpchauhan-me sankalpchauhan-me restored the hindi-translations-develop branch November 15, 2018 18:36
@sankalpchauhan-me
Copy link
Contributor Author

Everything looks good in the deployment, as the PR is merged I am deleting my copy of the branch i.e.sankalpchauhan-me:hindi-translations-develop, I will keep contributing to the project in future.
Best Of Luck to everyone working on this project.

@sankalpchauhan-me sankalpchauhan-me deleted the hindi-translations-develop branch November 15, 2018 18:39
@sankalpchauhan-me
Copy link
Contributor Author

I am a self taught Native Android Developer currently pursuing my Bachelors of Technology in Information Technology @DeeDeeG if there is some Native Android App of this project, I could contribute to that.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Nov 15, 2018

@sankalpchauhan-me we would be happy to have contributions over at our Android app, here: https://github.com/RefugeRestrooms/refugerestrooms-android/ !

We might not be able to review pull requests right away, as our maintainers there are somewhat busy, but contributions are still appreciated, and hopefully we can get to them soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Hacktoberfest These are issues or pull requests related to Hacktoberfest (https://hacktoberfest.digitalocean.com/) translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants