-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(icon,flag): add deprecation warning for src attribute and property #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bualoy-napat
added
the
refactor
Code refactoring that does not effect existing functionality
label
Jun 12, 2023
Deploying with Cloudflare Pages
|
Size Change: +246 B (0%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
bualoy-napat
commented
Jun 13, 2023
Sakchai-Refinitiv
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 👍
Kudos, SonarCloud Quality Gate passed! |
1 similar comment
Kudos, SonarCloud Quality Gate passed! |
Theeraphat-Sorasetsakul
added a commit
that referenced
this pull request
Jun 22, 2023
* refactor(chart): rename variable clarifying its value (#737) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] * docs: workaround to avoid skypack issue (#738) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] * fix(calendar, datetime-picker): prevent deselect date on calendar (#735) * fix(calendar, datetime-picker): prevent deselect value on calendar * chore: update datetime-picker demo font-size * test: add deselect value test case in datetime-picker * fix(calendar, datetime-picker): prevent deselect values in range mode * test(calendar): split range values test case * test(calendar): revise test case name --------- Co-authored-by: Sarin-Udompanish <[email protected]> * docs: remove via with using (#739) * refactor(icon,flag): add deprecation warning for src attribute and property (#742) * refactor(utils): update RegEx base64 svg (#745) * docs(configuration): fix wrong usage guide import part (#747) * docs(configuration): update usage guide * ci: sync nightly test v7 workflow * ci: update schedule nightly test time * ci: refactor nightly test v6 and v7 * fix(number-field): fix Floating point Division on validate method (#757) * fix(number-field): fix Floating point Division on validate method * Update packages/elements/src/number-field/__test__/number-field.validity.test.js Co-authored-by: Wasuwat Limsuparhat <[email protected]> * Update packages/elements/src/number-field/index.ts Co-authored-by: Wasuwat Limsuparhat <[email protected]> * test(number-field): add more Floating point precision test cases * Update packages/elements/src/number-field/index.ts Co-authored-by: Wasuwat Limsuparhat <[email protected]> * Update packages/elements/src/number-field/index.ts Co-authored-by: Wasuwat Limsuparhat <[email protected]> --------- Co-authored-by: Wasuwat Limsuparhat <[email protected]> * ci: fix lerna to use from local (#761) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] --------- Co-authored-by: wattachai <[email protected]> Co-authored-by: refinitiv-ui-dev <[email protected]> Co-authored-by: Nantawat Poothong <[email protected]> Co-authored-by: Sarin-Udompanish <[email protected]> Co-authored-by: Sarin-Udompanish <[email protected]> Co-authored-by: Domrongpon Tanpaibul <[email protected]> Co-authored-by: Napat Bualoy <[email protected]> Co-authored-by: Sakchai Homhual <[email protected]> Co-authored-by: Sakchai Homhual <[email protected]> Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add deprecation warning message for
src
attribute and propertyFixes # (issue)
STG-444
Type of change
Checklist