Skip to content

Commit

Permalink
Merge pull request #766 from Refinitiv/sync-v6-to-v7
Browse files Browse the repository at this point in the history
* refactor(chart): rename variable clarifying its value (#737)

* chore(release): publish [skip ci]

 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]

* docs: workaround to avoid skypack issue (#738)

* chore(release): publish [skip ci]

 - @refinitiv-ui/[email protected]

* fix(calendar, datetime-picker): prevent deselect date on calendar (#735)

* fix(calendar, datetime-picker): prevent deselect value on calendar

* chore: update datetime-picker demo font-size

* test: add deselect value test case in datetime-picker

* fix(calendar, datetime-picker): prevent deselect values in range mode

* test(calendar): split range values test case

* test(calendar): revise test case name

---------

Co-authored-by: Sarin-Udompanish <[email protected]>

* docs: remove via with using (#739)

* refactor(icon,flag): add deprecation warning for src attribute and property (#742)

* refactor(utils): update RegEx base64 svg (#745)

* docs(configuration): fix wrong usage guide import part (#747)

* docs(configuration): update usage guide

* ci: sync nightly test v7 workflow

* ci: update schedule nightly test time

* ci: refactor nightly test v6 and v7

* fix(number-field): fix Floating point Division on validate method (#757)

* fix(number-field): fix Floating point Division on validate method

* Update packages/elements/src/number-field/__test__/number-field.validity.test.js

Co-authored-by: Wasuwat Limsuparhat <[email protected]>

* Update packages/elements/src/number-field/index.ts

Co-authored-by: Wasuwat Limsuparhat <[email protected]>

* test(number-field): add more Floating point precision test cases

* Update packages/elements/src/number-field/index.ts

Co-authored-by: Wasuwat Limsuparhat <[email protected]>

* Update packages/elements/src/number-field/index.ts

Co-authored-by: Wasuwat Limsuparhat <[email protected]>

---------

Co-authored-by: Wasuwat Limsuparhat <[email protected]>

* ci: fix lerna to use from local (#761)

* chore(release): publish [skip ci]

 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]

---------

Co-authored-by: wattachai <[email protected]>
Co-authored-by: refinitiv-ui-dev <[email protected]>
Co-authored-by: Nantawat Poothong <[email protected]>
Co-authored-by: Sarin-Udompanish <[email protected]>
Co-authored-by: Sarin-Udompanish <[email protected]>
Co-authored-by: Domrongpon Tanpaibul <[email protected]>
Co-authored-by: Napat Bualoy <[email protected]>
Co-authored-by: Sakchai Homhual <[email protected]>
Co-authored-by: Sakchai Homhual <[email protected]>
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
  • Loading branch information
11 people authored Jun 22, 2023
2 parents 4be2de1 + dee9096 commit 137b5a3
Show file tree
Hide file tree
Showing 38 changed files with 287 additions and 53 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dev_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ jobs:
uses: ./.github/actions/checkout-install-and-build

- name: Publish to NPM
run: lerna publish 0.0.0-dev.${{ github.run_id }}.${{ github.run_attempt }} --dist-tag dev --force-publish --exact --include-merged-tags --no-private --no-changelog --no-git-tag-version --no-push --yes
run: npx lerna publish 0.0.0-dev.${{ github.run_id }}.${{ github.run_attempt }} --dist-tag dev --force-publish --exact --include-merged-tags --no-private --no-changelog --no-git-tag-version --no-push --yes
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
4 changes: 2 additions & 2 deletions .github/workflows/pre_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ jobs:

- name: Publish to NPM (all packages)
if: ${{ github.event.inputs.version == 'premajor' }}
run: lerna publish ${{ github.event.inputs.version }} --preid next --dist-tag next --force-publish --include-merged-tags --no-private --no-changelog --yes
run: npx lerna publish ${{ github.event.inputs.version }} --preid next --dist-tag next --force-publish --include-merged-tags --no-private --no-changelog --yes
env:
GH_TOKEN: ${{ secrets.GH_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Publish to NPM (modified packages)
if: ${{ github.event.inputs.version != 'premajor' }}
run: lerna publish ${{ github.event.inputs.version }} --preid next --dist-tag next --include-merged-tags --no-private --no-changelog --yes
run: npx lerna publish ${{ github.event.inputs.version }} --preid next --dist-tag next --include-merged-tags --no-private --no-changelog --yes
env:
GH_TOKEN: ${{ secrets.GH_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
4 changes: 2 additions & 2 deletions .github/workflows/prod_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ jobs:
echo "GRADUATE_OPTION=$GRADUATE" >> $GITHUB_ENV
- name: Bump package versions and create GitHub release
run: lerna version --create-release github --conventional-commits ${{ env.FORCE_OPTION }} ${{ env.GRADUATE_OPTION }} --yes
run: npx lerna version --create-release github --conventional-commits ${{ env.FORCE_OPTION }} ${{ env.GRADUATE_OPTION }} --yes
env:
GH_TOKEN: ${{ secrets.GH_TOKEN }}

- name: Publish to NPM
run: lerna publish from-git --yes
run: npx lerna publish from-git --yes
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/test_nightly_v7.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -97,6 +98,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -115,6 +117,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -131,6 +134,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -147,6 +151,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -165,6 +170,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -181,6 +187,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -200,6 +207,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -217,6 +225,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -234,6 +243,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -253,6 +263,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -269,6 +280,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand All @@ -285,6 +297,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: v7

- name: Test
uses: ./.github/actions/run-test
Expand Down
24 changes: 24 additions & 0 deletions documents/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,30 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [6.5.8](https://github.com/Refinitiv/refinitiv-ui/compare/@refinitiv-ui/[email protected]...@refinitiv-ui/[email protected]) (2023-06-20)

**Note:** Version bump only for package @refinitiv-ui/docs





## [6.5.7](https://github.com/Refinitiv/refinitiv-ui/compare/@refinitiv-ui/[email protected]...@refinitiv-ui/[email protected]) (2023-06-08)

**Note:** Version bump only for package @refinitiv-ui/docs





## [6.5.6](https://github.com/Refinitiv/refinitiv-ui/compare/@refinitiv-ui/[email protected]...@refinitiv-ui/[email protected]) (2023-06-08)

**Note:** Version bump only for package @refinitiv-ui/docs





## [6.5.5](https://github.com/Refinitiv/refinitiv-ui/compare/@refinitiv-ui/[email protected]...@refinitiv-ui/[email protected]) (2023-06-07)

**Note:** Version bump only for package @refinitiv-ui/docs
Expand Down
2 changes: 1 addition & 1 deletion documents/src/pages/accessibility.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ When developing your UI, be cognizant of the common keyboard interactions noted
Keyboard navigation is best implemented in such a way that it promotes logical rules of orientation and navigation (see figure 2 below).

- Focus usually starts from the top-left of the screen when it first loads.
- Focus can be followed easily via the use of a visually consistent focus indication.
- Focus can be followed easily using the use of a visually consistent focus indication.
- Upon activation of a component, focus can automatically be initiated on a logical starting point. For example, when an Overlay Menu or Overlay is highlighted, focus programmatically moves to the first item.
- Modal components can restrict the focus to remain within the modal region.
- When a control is dismissed, focus should be returned to the triggering element.
Expand Down
4 changes: 2 additions & 2 deletions documents/src/pages/build-element/element-types.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class MyLogo extends BasicElement {

The control element is used mainly for elements that require user interaction and need to be included in keyboard navigation sequences. A good example of a control element is a button.

- Makes the item reachable via key navigation
- Makes the item reachable using key navigation
- Support getter and setter `value` property
- Support control states e.g. `disabled` and `readonly`

Expand All @@ -44,7 +44,7 @@ class CameraButton extends ControlElement {
The form field element class is used for control elements that contains **input fields**. This abstract class is extended from Control Elements. It provides additional logic for managing accessibility features and should be used when creating new form field elements. An example of a form field element is Number Input Field

- Adds support for aria tags to be used for accessibility
- Makes the item reachable via key navigation
- Makes the item reachable using key navigation
- Support state validation `error` and `warning`

```typescript
Expand Down
2 changes: 1 addition & 1 deletion documents/src/pages/build-element/notice-messages.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ layout: default

# Notice Messages

When creating elements, it's best to keep things simple and try to reduce any errors that may occur. However, your elements should feedback to developers via console log when necessary.
When creating elements, it's best to keep things simple and try to reduce any errors that may occur. However, your elements should feedback to developers using console log when necessary.

o> **Tip**:\
Try to implement flexibility into your element by handling invalid input in a way that least disrupts a user.
Expand Down
2 changes: 1 addition & 1 deletion documents/src/pages/elements/appstate-bar.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ ef-appstate-bar {
`ef-appstate-bar` is used to display status or other information at the top of an application. App State Bar comes with pre-defined colors in the theme.

## Usage
Styles for App State Bar content can be set using the `state` attribute/property. The App State Bar's heading can be set via the `heading` attribute/property.
Styles for App State Bar content can be set using the `state` attribute/property. The App State Bar's heading can be set using the `heading` attribute/property.

```html
<ef-appstate-bar heading="Heading">
Expand Down
2 changes: 1 addition & 1 deletion documents/src/pages/elements/button.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ btn.addEventListener('tap', () => {
## Accessibility
::a11y-intro::

`ef-button` has been assigned the role of `button` and can have a `pressed` state. Always try to include a text label for a button. Avoid relying solely upon an image or icon to convey the button’s purpose to users. Assistive technology users ascertain the purpose of a button via its accessible name which gets computed from either its visual label, alternative text, or aria-label attribute – so be sure to fill them in accurately. Whenever the button’s visual state changes, the button state programmatically updates to inform assistive technology users of the element’s changed state.
`ef-button` has been assigned the role of `button` and can have a `pressed` state. Always try to include a text label for a button. Avoid relying solely upon an image or icon to convey the button’s purpose to users. Assistive technology users ascertain the purpose of a button using its accessible name which gets computed from either its visual label, alternative text, or aria-label attribute – so be sure to fill them in accurately. Whenever the button’s visual state changes, the button state programmatically updates to inform assistive technology users of the element’s changed state.

`ef-button` handles role and aria value but when using button without any text label, assign `aria-label` as the accessible name.

Expand Down
4 changes: 2 additions & 2 deletions documents/src/pages/elements/collapse.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ The header can contain simple text or components such as checkbox, button. These
::
```javascript
::collapse::
import 'https://cdn.skypack.dev/@refinitiv-ui/elements/checkbox?min';
import 'https://cdn.skypack.dev/@refinitiv-ui/elements/button?min';
import 'https://cdn.skypack.dev/@refinitiv-ui/elements@next/checkbox?min';
import 'https://cdn.skypack.dev/@refinitiv-ui/elements@next/button?min';
halo('checkbox');
halo('button');
```
Expand Down
2 changes: 1 addition & 1 deletion documents/src/pages/elements/color-dialog.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ document.getElementById('button').addEventListener('click', () => {
```
::

`ef-color-dialog` allows users to select any color. You can set the value as a hex color code (short hex is also supported) or as Red/Green/Blue (0 - 255). Users can choose a color directly from a pallete UI or via input boxes in the dialog.
`ef-color-dialog` allows users to select any color. You can set the value as a hex color code (short hex is also supported) or as Red/Green/Blue (0 - 255). Users can choose a color directly from a pallete UI or using input boxes in the dialog.

## Usage

Expand Down
2 changes: 1 addition & 1 deletion documents/src/pages/elements/color-picker.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ ef-color-picker {
`ef-color-picker` allows users to pick any colours from colour dialog.

### Basic usage
You can set an initial value via `value` attribute. The `value` must be a string of hex colour code.
You can set an initial value using `value` attribute. The `value` must be a string of hex colour code.

```html
<ef-color-picker value="#001EFF"></ef-color-picker>
Expand Down
2 changes: 1 addition & 1 deletion documents/src/pages/elements/combo-box.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ The `ef-combo-box` uses the [ComboBoxData](https://github.com/Refinitiv/refiniti
## Getting value on single and multiple mode
When an item is selected, the item's `value` will set to Combo Box's `value`.

Value can be preset via `selected` field when set data or by programmatically setting the Combo Box `value` property.
Value can be preset using `selected` field when set data or by programmatically setting the Combo Box `value` property.

```javascript
comboBox.data = [
Expand Down
Loading

0 comments on commit 137b5a3

Please sign in to comment.