-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(number-field): fix Floating point Division on validate method #757
Merged
Theeraphat-Sorasetsakul
merged 6 commits into
v6
from
fix/number-field-floating-point-division
Jun 19, 2023
Merged
fix(number-field): fix Floating point Division on validate method #757
Theeraphat-Sorasetsakul
merged 6 commits into
v6
from
fix/number-field-floating-point-division
Jun 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +295 B (0%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
wsuwt
reviewed
Jun 16, 2023
packages/elements/src/number-field/__test__/number-field.validity.test.js
Outdated
Show resolved
Hide resolved
wsuwt
reviewed
Jun 16, 2023
…ity.test.js Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Deploying with Cloudflare Pages
|
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
wsuwt
reviewed
Jun 19, 2023
wsuwt
reviewed
Jun 19, 2023
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
wsuwt
approved these changes
Jun 19, 2023
Theeraphat-Sorasetsakul
deleted the
fix/number-field-floating-point-division
branch
June 19, 2023 06:48
Theeraphat-Sorasetsakul
added a commit
that referenced
this pull request
Jun 22, 2023
* refactor(chart): rename variable clarifying its value (#737) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] * docs: workaround to avoid skypack issue (#738) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] * fix(calendar, datetime-picker): prevent deselect date on calendar (#735) * fix(calendar, datetime-picker): prevent deselect value on calendar * chore: update datetime-picker demo font-size * test: add deselect value test case in datetime-picker * fix(calendar, datetime-picker): prevent deselect values in range mode * test(calendar): split range values test case * test(calendar): revise test case name --------- Co-authored-by: Sarin-Udompanish <[email protected]> * docs: remove via with using (#739) * refactor(icon,flag): add deprecation warning for src attribute and property (#742) * refactor(utils): update RegEx base64 svg (#745) * docs(configuration): fix wrong usage guide import part (#747) * docs(configuration): update usage guide * ci: sync nightly test v7 workflow * ci: update schedule nightly test time * ci: refactor nightly test v6 and v7 * fix(number-field): fix Floating point Division on validate method (#757) * fix(number-field): fix Floating point Division on validate method * Update packages/elements/src/number-field/__test__/number-field.validity.test.js Co-authored-by: Wasuwat Limsuparhat <[email protected]> * Update packages/elements/src/number-field/index.ts Co-authored-by: Wasuwat Limsuparhat <[email protected]> * test(number-field): add more Floating point precision test cases * Update packages/elements/src/number-field/index.ts Co-authored-by: Wasuwat Limsuparhat <[email protected]> * Update packages/elements/src/number-field/index.ts Co-authored-by: Wasuwat Limsuparhat <[email protected]> --------- Co-authored-by: Wasuwat Limsuparhat <[email protected]> * ci: fix lerna to use from local (#761) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] --------- Co-authored-by: wattachai <[email protected]> Co-authored-by: refinitiv-ui-dev <[email protected]> Co-authored-by: Nantawat Poothong <[email protected]> Co-authored-by: Sarin-Udompanish <[email protected]> Co-authored-by: Sarin-Udompanish <[email protected]> Co-authored-by: Domrongpon Tanpaibul <[email protected]> Co-authored-by: Napat Bualoy <[email protected]> Co-authored-by: Sakchai Homhual <[email protected]> Co-authored-by: Sakchai Homhual <[email protected]> Co-authored-by: Wasuwat Limsuparhat <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a red border around the input for valid numbers.
Steps to replicate:
Fixes # (STG-457)
Type of change
Checklist