added the ability to overide a command data (like first_key, last_key, jump and flags)

RAMP/module_metadata.py

@@ -22,6 +22,7 @@
 MIN_REDIS_PACK_VERSION = "5.0"
 RAMP_FORMAT_VERSION = 1
 CONFIG_COMMAND = ""
+OVERIDE_COMMAND = []
 
 FIELDS = ["module_name", "module_file", "architecture", "version", "semantic_version",
           "display_name", "author", "email", "description", "homepage", "license",
@@ -60,6 +61,7 @@ def create_default_metadata(module_path):
         "commands": MODULE_COMMANDS,
         "ramp_format_version": RAMP_FORMAT_VERSION,
         "config_command": CONFIG_COMMAND,
-        "exclude_commands": EXCLUDE_COMMANDS
+        "exclude_commands": EXCLUDE_COMMANDS,
+        "overide_command": OVERIDE_COMMAND
     }
     return metadata

RAMP/packer.py

@@ -65,7 +65,7 @@ def archive(module_path, metadata, archive_name='module.zip'):
 def package(module, output, verbose, manifest, display_name, module_name, author,
             email, architecture, description, homepage, license, cmdargs,
             redis_min_version, redis_pack_min_version, config_command, os, os_list, capabilities,
-            print_filename_only, exclude_commands):
+            print_filename_only, exclude_commands, overide_command):
     module_path = module
     metadata = set_defaults(module_path)
 
@@ -87,13 +87,27 @@ def package(module, output, verbose, manifest, display_name, module_name, author
         metadata["capabilities"] = capabilities
         metadata["config_command"] = config_command
         metadata["exclude_commands"] = exclude_commands
+        metadata["overide_command"] = overide_command
 
     # Load module into redis and discover its commands
     module = discover_modules_commands(module_path, metadata["command_line_args"])
     metadata["module_name"] = module.name
     metadata["version"] = module.version
     metadata["semantic_version"] = str(version_to_semantic_version(module.version))
     metadata["commands"] = [cmd.to_dict() for cmd in module.commands if cmd.command_name not in metadata["exclude_commands"]]
+
+    # overide requested commands data
+    for overide in metadata["overide_command"]:
+        if 'command_name' not in overide:
+            print("error: the given overide json does not contains command name: %s" % str(overide))
+            continue
+        overide_index = [i for i in range(len(metadata["commands"])) if metadata["commands"][i]['command_name'] == overide['command_name']]
+        if len(overide_index) != 1:
+            print("error: the given overide command appears more then once")
+            continue
+        if verbose:
+            print 'overiding %s with %s' % (str(metadata["commands"][overide_index[0]]), str(overide)) 
+        metadata["commands"][overide_index[0]] = overide
 
     if module_name:
         metadata["module_name"] = module_name

RAMP/ramp.py

@@ -18,6 +18,15 @@ def comma_seperated_to_list(ctx, param, value):
     else:
         items = value.split(',')
         return list(set(items))
+
+def jsons_str_tuple_to_jsons_tuple(ctx, param, value):
+    """
+    Converts json str into python map
+    """
+    if value is None:
+        return []
+    else:
+        return [json.loads(a) for  a in value]
 
 @click.group()
 def ramp():
@@ -79,14 +88,15 @@ def unpack(bundle):
 @click.option('--capabilities', '-C', callback=comma_seperated_to_list, help='comma seperated list of module capabilities')
 @click.option('--print-filename-only', '-P', is_flag=True, help="Print package path, but don't generate file")
 @click.option('--exclude-commands', '-E', callback=comma_seperated_to_list, help='comma seperated list of exclude commands')
+@click.option('--overide-command', multiple=True, callback=jsons_str_tuple_to_jsons_tuple, help='gets a command json representation and overide it on the module json file')
 def pack(module, output, verbose, manifest, display_name, module_name, author,
          email, architecture, description, homepage, license, cmdargs,
          redis_min_version, redis_pack_min_version, config_command, os, os_list, capabilities,
-         print_filename_only, exclude_commands):
+         print_filename_only, exclude_commands, overide_command):
     return package(module, output, verbose, manifest, display_name, module_name, author,
                    email, architecture, description, homepage, license, cmdargs,
                    redis_min_version, redis_pack_min_version, config_command, os, os_list, capabilities,
-                   print_filename_only, exclude_commands)
+                   print_filename_only, exclude_commands, overide_command)
 
 if __name__ == '__main__':
     ramp()

example.manifest.yml

@@ -20,3 +20,4 @@ capabilities:
     - flash
 exclude_commands:
     - graph.BULK
+overide_command: [{"command_name": "graph.EXPLAIN"}]

test.py

@@ -41,12 +41,7 @@ def validate_module_commands(commands):
 
     # Expected commands:
     expected_command = []
-    expected_command.append({"command_arity": -1,
-                         "command_name": "graph.EXPLAIN",
-                         "first_key": 1,
-                         "flags": ["write","noscript"],
-                         "last_key": 1,
-                         "step": 1})
+    expected_command.append({"command_name": "graph.EXPLAIN"})
 
     expected_command.append({"command_arity": -1,
                    "command_name": "graph.QUERY",
@@ -67,7 +62,9 @@ def validate_module_commands(commands):
 def test_defaults():
     """Test auto generated metadata from module is as expected."""
     runner = CliRunner()
-    result = runner.invoke(ramp.pack, [MODULE_FILE_PATH, '-o', BUNDLE_ZIP_FILE, '-E', 'graph.BULK'])
+    result = runner.invoke(ramp.pack, [MODULE_FILE_PATH, '-o', BUNDLE_ZIP_FILE,
+                                       '-E', 'graph.BULK',
+                                       '--overide-command', '{"command_name": "graph.EXPLAIN"}'])
     assert result.exit_code == 0
 
     metadata, _ = unpacker.unpack(BUNDLE_ZIP_FILE)
@@ -120,7 +117,8 @@ def test_bundle_from_cmd():
             '-r', min_redis_version, '-R', min_redis_pack_version,
             '-C', ','.join([cap['name'] for cap in MODULE_CAPABILITIES]),
             '-o', BUNDLE_ZIP_FILE, '-cc', CONFIG_COMMAND, '-E', 'graph.bulk',
-            '-E', 'graph.BULK']
+            '-E', 'graph.BULK',
+            '--overide-command', '{"command_name": "graph.EXPLAIN"}']
 
     runner = CliRunner()
     result = runner.invoke(ramp.pack, argv)