Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the ability to overide a command data (like first_key, last_key, jump and flags) #28

Merged
merged 4 commits into from
Jul 21, 2019

Conversation

MeirShpilraien
Copy link
Collaborator

No description provided.

@MeirShpilraien MeirShpilraien requested a review from swilly22 July 21, 2019 10:25
@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #28 into master will decrease coverage by 0.67%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   85.74%   85.06%   -0.68%     
==========================================
  Files           9        9              
  Lines         491      509      +18     
==========================================
+ Hits          421      433      +12     
- Misses         70       76       +6
Impacted Files Coverage Δ
RAMP/module_metadata.py 100% <100%> (ø) ⬆️
test.py 94.69% <100%> (ø) ⬆️
RAMP/packer.py 84.04% <58.33%> (-3.77%) ⬇️
RAMP/ramp.py 67.64% <80%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89de9ad...674b67f. Read the comment docs.

RAMP/ramp.py Outdated
@@ -79,14 +88,15 @@ def unpack(bundle):
@click.option('--capabilities', '-C', callback=comma_seperated_to_list, help='comma seperated list of module capabilities')
@click.option('--print-filename-only', '-P', is_flag=True, help="Print package path, but don't generate file")
@click.option('--exclude-commands', '-E', callback=comma_seperated_to_list, help='comma seperated list of exclude commands')
@click.option('--overide-command', multiple=True, callback=jsons_str_tuple_to_jsons_tuple)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing help message

@swilly22 swilly22 merged commit 7d953ef into master Jul 21, 2019
@swilly22 swilly22 deleted the overide_commands_data branch July 21, 2019 19:25
@swilly22 swilly22 restored the overide_commands_data branch July 21, 2019 19:25
@swilly22 swilly22 deleted the overide_commands_data branch July 21, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants