Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify BootstrapNav TEXT_DISABLED #114

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Modify BootstrapNav TEXT_DISABLED #114

merged 2 commits into from
Dec 11, 2019

Conversation

valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Nov 30, 2019 •
edited
Loading

The current TEXT_DISABLED doesn't always give the correct xpath, modify it to work with all the cases.

Required for: ManageIQ/integration_tests#9685

@coveralls
Copy link

coveralls commented Nov 30, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 52.907% when pulling eee61d8 on valaparthvi:bsnav_is_disabled into 7be378c on RedHatQE:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 49.185% when pulling 90c24dc on valaparthvi:bsnav_is_disabled into 8553b34 on RedHatQE:master.

@valaparthvi valaparthvi mentioned this pull request Nov 30, 2019
Merged
@mshriver mshriver self-assigned this Dec 2, 2019
john-dupuy
john-dupuy reviewed Dec 3, 2019
View reviewed changes
Copy link
Collaborator

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment about consistency. I don't think it will make any difference though.

src/widgetastic_patternfly/__init__.py Outdated Show resolved Hide resolved
@valaparthvi
Copy link
Contributor Author

Hey @mshriver can we merge this now?

@mshriver mshriver merged commit 39f46eb into RedHatQE:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-dupuy john-dupuy john-dupuy approved these changes

@mshriver mshriver mshriver approved these changes

Assignees

@mshriver mshriver

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valaparthvi @coveralls @mshriver @john-dupuy