[1LP][RFR] Add sidebar accordion to Compute Infrastructure pages AND automate test: test_infrastructure_provider_left_panel_titles #9266

valaparthvi · 2019-08-29T09:07:50Z

Purpose or Intent

Adding tests test_infrastructure_provider_left_panel_titles
Updating tests test_run_host_analysis which uses host details sidebar.
Enhancement Add sidebar accordions to the following pages
1. Infrastructure > Providers
2. Infrastructure > Clusters
3. Infrastructure > Hosts
4. Infrastructure > Resource Pools

Note: Dependent on : RedHatQE/widgetastic.patternfly#114

PRT Run

{{ pytest : cfme/tests/webui/test_general_ui.py::test_infrastructure_provider_left_panel_titles cfme/tests/infrastructure/test_host_analysis.py::test_run_host_analysis -vvv }}

cfme/tests/webui/test_general_ui.py

valaparthvi · 2019-12-19T15:08:14Z

These tests passed locally, but PRT keeps resulting into Invalid state for some reason :/
Just a heads up, PRT will fail for 511 because of test_run_host_analysis but that is not related to the changes made by this PR.

jawatts · 2019-12-19T16:20:05Z

@valaparthvi looks like test_general_ui failed as well in 5.11

valaparthvi · 2019-12-19T19:10:21Z

@jawatts So I figured what went wrong, I guess I'll have to open another PR to wt.patternfly 😩
Here, there is no parent, so it selects any element that matches the xpath without taking into account the scope. There is an extra element that matches the xpath on 511, which is causing this failure. I think defining the parent here should fix this.

Edit:
wt.patternfly PR: RedHatQE/widgetastic.patternfly#117

mshriver · 2019-12-19T19:53:45Z

cfme/tests/webui/test_general_ui.py

+            test_view = provider.create_view(ALL_OPTIONS[option][panel], wait="60s")
+            soft_assert(test_view.is_displayed, f"{test_view} not displayed.")
+        else:
+            logger.info(f"'{panel}' was not tested, it did not enable.")


I think this should be a pytest.skip or pytest.fail - the item was expected to enable why wouldn't that be a failure?

There are a few items that get enabled once the provider receives data, but there are items such as Timelines that take some 15-20 minutes to enable itself, so I decided to just log it, I don't want to fail/skip the test in this case. Is there a way to quickly enable Timelines?

I'm not aware of a way to quickly enable timelines in this case.

I still am not comfortable with this result for the test though. There will be no indication in the results or artifactor report that this occurred - you would have to inspect the cfme.log file on every test execution to check for this message and to know whether or not timelines was actually tested.

A pytest xfail may be your best option here - that its more or less and expected failure state. We need some indication in results that there was missing coverage for this test case.

That or test timelines separately, putting more investigation into how to enable the option quickly.

So John helped me trigger Timelines, activities like creating/deleting/reconfiguring VMs create an event and triggers Timelines. So I did that, I create VM as a part of setup.

mshriver

Looks great - just 1 comment about the silent test failure with a log message.

I'm also going to merge/release the wt.pf PR that adds parents to the partial match element lookups, which is causing the PRT failures. You should update the requirements files to the newest wt.pf version.

valaparthvi · 2019-12-21T06:36:42Z

Moving to RFR. 511 PRT failures are unrelated to these changes.

mshriver · 2020-01-07T14:13:36Z

cfme/tests/webui/test_general_ui.py

+        )
+        if not accordion.tree.is_disabled(partial_match(panel)):
+            accordion.tree.select(partial_match(panel))
+            test_view = provider.create_view(ALL_OPTIONS[option][panel], wait="60s")


Since you passed wait parameter, this will raise an exception before your soft assert if the view isn't displayed.

mshriver

Test failure modes need to be revised.

dajoRH · 2020-01-14T13:39:40Z

I detected some fixture changes in commit 32cd546

The local fixture vm is used in the following files:

cfme/tests/webui/test_general_ui.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

…automate test: test_infrastructure_provider_left_panel_titles (ManageIQ#9266) * Add sidebar accordion to provider detail and cluster details view * Add sidebar for infra hosts * Add sidebar for infra resource pools * Requested changes * Update wt.pf requirements * Fix failing test

dajoRH added lint-ok WIP labels Aug 29, 2019

valaparthvi changed the title ~~[WIP] Add sidebar accordion to Compute Infrastructure pages~~ [WIP] Add sidebar accordion to Compute Infrastructure pages and Automate test: test_infrastructure_provider_left_panel_titles Sep 4, 2019

valaparthvi changed the title ~~[WIP] Add sidebar accordion to Compute Infrastructure pages and Automate test: test_infrastructure_provider_left_panel_titles~~ [WIP] Add sidebar accordion to Compute Infrastructure pages AND automate test: test_infrastructure_provider_left_panel_titles Sep 4, 2019

valaparthvi added enhancement new-test-or-feature labels Sep 4, 2019

dajoRH added WIP-testing and removed WIP labels Sep 4, 2019

valaparthvi mentioned this pull request Sep 5, 2019

[1LP][RFR] Add partial_match in BootstrapNav is_disabled method RedHatQE/widgetastic.patternfly#106

Merged

dajoRH added WIP and removed WIP-testing labels Sep 5, 2019

valaparthvi force-pushed the fix_manageiqtree branch from 60f94bf to 0f9118f Compare September 14, 2019 08:57

dajoRH added WIP-testing and removed WIP labels Sep 14, 2019

valaparthvi force-pushed the fix_manageiqtree branch from 0f9118f to 97a0c56 Compare September 16, 2019 11:29

valaparthvi commented Sep 16, 2019

View reviewed changes

cfme/tests/webui/test_general_ui.py Show resolved Hide resolved

dajoRH removed the WIP-testing label Sep 16, 2019

dajoRH added the WIP-testing label Sep 16, 2019

valaparthvi force-pushed the fix_manageiqtree branch 2 times, most recently from ebbd7b5 to f402e2f Compare October 17, 2019 10:26

dajoRH changed the title ~~[WIPTEST] Add sidebar accordion to Compute Infrastructure pages AND automate test: test_infrastructure_provider_left_panel_titles~~ [WIP] Add sidebar accordion to Compute Infrastructure pages AND automate test: test_infrastructure_provider_left_panel_titles Oct 25, 2019

dajoRH added needs-rebase WIP and removed WIP-testing labels Oct 25, 2019

valaparthvi force-pushed the fix_manageiqtree branch from f402e2f to 6e5f23c Compare November 30, 2019 09:03

dajoRH removed the WIP-testing label Dec 19, 2019

mshriver reviewed Dec 19, 2019

View reviewed changes

mshriver suggested changes Dec 19, 2019

View reviewed changes

mshriver assigned mshriver and unassigned jawatts Dec 19, 2019

dajoRH added the WIP-testing label Dec 19, 2019

valaparthvi force-pushed the fix_manageiqtree branch from 616aa2f to 4d7faa9 Compare December 20, 2019 19:25

dajoRH removed the WIP-testing label Dec 21, 2019

mshriver reviewed Jan 7, 2020

View reviewed changes

mshriver suggested changes Jan 7, 2020

View reviewed changes

valaparthvi added 5 commits January 14, 2020 16:51

Add sidebar accordion to provider detail and cluster details view

595a82e

Add sidebar for infra hosts

4a790e9

Add sidebar for infra resource pools

7f509a6

Requested changes

b7b24df

Update wt.pf requirements

2ba7a9c

valaparthvi force-pushed the fix_manageiqtree branch from 4d7faa9 to d702bc8 Compare January 14, 2020 11:22

Fix failing test

32cd546

valaparthvi force-pushed the fix_manageiqtree branch from d702bc8 to 32cd546 Compare January 14, 2020 13:21

mshriver approved these changes Jan 14, 2020

View reviewed changes

mshriver merged commit f556946 into ManageIQ:master Jan 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1LP][RFR] Add sidebar accordion to Compute Infrastructure pages AND automate test: test_infrastructure_provider_left_panel_titles #9266

[1LP][RFR] Add sidebar accordion to Compute Infrastructure pages AND automate test: test_infrastructure_provider_left_panel_titles #9266

valaparthvi commented Aug 29, 2019 •

edited

Loading

valaparthvi commented Dec 19, 2019

jawatts commented Dec 19, 2019

valaparthvi commented Dec 19, 2019 •

edited

Loading

mshriver Dec 19, 2019

valaparthvi Dec 20, 2019 •

edited

Loading

mshriver Jan 7, 2020

valaparthvi Jan 14, 2020

mshriver left a comment

valaparthvi commented Dec 21, 2019

mshriver Jan 7, 2020

mshriver left a comment

dajoRH commented Jan 14, 2020

[1LP][RFR] Add sidebar accordion to Compute Infrastructure pages AND automate test: test_infrastructure_provider_left_panel_titles #9266

[1LP][RFR] Add sidebar accordion to Compute Infrastructure pages AND automate test: test_infrastructure_provider_left_panel_titles #9266

Conversation

valaparthvi commented Aug 29, 2019 • edited Loading

Purpose or Intent

PRT Run

valaparthvi commented Dec 19, 2019

jawatts commented Dec 19, 2019

valaparthvi commented Dec 19, 2019 • edited Loading

mshriver Dec 19, 2019

Choose a reason for hiding this comment

valaparthvi Dec 20, 2019 • edited Loading

Choose a reason for hiding this comment

mshriver Jan 7, 2020

Choose a reason for hiding this comment

valaparthvi Jan 14, 2020

Choose a reason for hiding this comment

mshriver left a comment

Choose a reason for hiding this comment

valaparthvi commented Dec 21, 2019

mshriver Jan 7, 2020

Choose a reason for hiding this comment

mshriver left a comment

Choose a reason for hiding this comment

dajoRH commented Jan 14, 2020

valaparthvi commented Aug 29, 2019 •

edited

Loading

valaparthvi commented Dec 19, 2019 •

edited

Loading

valaparthvi Dec 20, 2019 •

edited

Loading