fix: check list range to avoid exception #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-blakley
requested changes
Nov 1, 2022
pcs config shows empty "Corosync Nodes" on pacemaker remote nodes, and data[in_line] has an empty list. This fix checks the range before accessing data[in_line][0]. Without this fix, an exception is raised. Signed-off-by: Takayuki Nagata <[email protected]>
xiangce
approved these changes
Nov 3, 2022
psachin
pushed a commit
that referenced
this pull request
Nov 3, 2022
pcs config shows empty "Corosync Nodes" on pacemaker remote nodes, and data[in_line] has an empty list. This fix checks the range before accessing data[in_line][0]. Without this fix, an exception is raised. Signed-off-by: Takayuki Nagata <[email protected]> Signed-off-by: Takayuki Nagata <[email protected]> (cherry picked from commit f5fb7ba)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
pcs config shows empty "Corosync Nodes" on pacemaker remote nodes, and data[in_line] has an empty list. This fix checks the range before accessing data[in_line][0]. Without this fix, an exception is raised. Signed-off-by: Takayuki Nagata <[email protected]> Signed-off-by: Takayuki Nagata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takayuki Nagata [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
pcs configshows emptyCorosync Nodeson pacemaker remote nodes, anddata[in_line]has an empty list. This fix checks the range before accessingdata[in_line][0]. Without this fix, an exception is raised.