fix: check list range to avoid exception (#3576)

pcs config shows empty "Corosync Nodes" on pacemaker remote nodes, and data[in_line] has an empty list. This fix checks the range before accessing data[in_line][0]. Without this fix, an exception is raised. Signed-off-by: Takayuki Nagata <[email protected]> Signed-off-by: Takayuki Nagata <[email protected]>
RedHatInsights · Nov 3, 2022 · 0f50d36 · 0f50d36
1 parent 397534e
commit 0f50d36
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 1 deletion.
diff --git a/insights/parsers/pcs_config.py b/insights/parsers/pcs_config.py
@@ -141,7 +141,7 @@ def parse_content(self, content):
         if not dc_key == "" and dc_key not in self.data.keys():
             self.data[dc_key] = list_data
         for in_line in in_line_tuple:
-            if isinstance(self.data.get(in_line), list):
+            if isinstance(self.data.get(in_line), list) and self.data[in_line]:
                 self.data[in_line] = self.data[in_line][0].split()
 
     def get(self, key):

diff --git a/insights/tests/parsers/test_pcs_config.py b/insights/tests/parsers/test_pcs_config.py
@@ -66,6 +66,53 @@
  stonith-enabled: false
 """.strip()
 
+PCS_CONFIG_ON_REMOTE = """
+Cluster Name: test_cluster
+Corosync Nodes:
+Pacemaker Nodes:
+ node1 node2 node3
+
+Resources:
+ Resource: dummy1 (class=ocf provider=heartbeat type=Dummy)
+  Operations: migrate_from interval=0s timeout=20s (dummy1-migrate_from-interval-0s)
+              migrate_to interval=0s timeout=20s (dummy1-migrate_to-interval-0s)
+              monitor interval=10s timeout=20s (dummy1-monitor-interval-10s)
+              reload interval=0s timeout=20s (dummy1-reload-interval-0s)
+              start interval=0s timeout=20s (dummy1-start-interval-0s)
+              stop interval=0s timeout=20s (dummy1-stop-interval-0s)
+ Resource: remote1 (class=ocf provider=pacemaker type=remote)
+  Attributes: server=remote1
+  Operations: migrate_from interval=0s timeout=60s (remote1-migrate_from-interval-0s)
+              migrate_to interval=0s timeout=60s (remote1-migrate_to-interval-0s)
+              monitor interval=60s timeout=30s (remote1-monitor-interval-60s)
+              reload interval=0s timeout=60s (remote1-reload-interval-0s)
+              start interval=0s timeout=60s (remote1-start-interval-0s)
+              stop interval=0s timeout=60s (remote1-stop-interval-0s)
+
+Stonith Devices:
+Fencing Levels:
+
+Location Constraints:
+Ordering Constraints:
+Colocation Constraints:
+Ticket Constraints:
+
+Alerts:
+ No alerts defined
+
+Resources Defaults:
+ No defaults set
+Operations Defaults:
+ No defaults set
+
+Cluster Properties:
+ cluster-infrastructure: corosync
+ cluster-name: my_cluster
+ dc-version: 2.0.3-5.el8-4b1f869f0f
+ have-watchdog: false
+ last-lrm-refresh: 1667289123
+""".strip()
+
 
 def test_pcs_config_basic():
     pcs = PCSConfig(context_wrap(NORMAL_PCS_CONFIG))
@@ -85,6 +132,11 @@ def test_pcs_config_normal():
     assert pcs.cluster_properties.get("have-watchdog") == "false"
 
 
+def test_pcs_config_on_remote():
+    pcs = PCSConfig(context_wrap(PCS_CONFIG_ON_REMOTE))
+    assert pcs.get("Corosync Nodes") == []
+
+
 def test_pcs_config_documentation():
     env = {
         'pcs_config': PCSConfig(context_wrap(NORMAL_PCS_CONFIG)),