feat(retry): add config to reset error count on successful emission #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the ability to reset the error counter on successful emissions using the `retry` operator. The current behavior for `retry(n)` is to call error if n errors occurred, regardless of whether or not they were consecutive. Now one would be able to use `retry(n, true)` to have the count reset so that only n consecutive errors will cause the observable to fail.
added overloaded signature to the `retry` operator that accepts a config object
cartant
changed the title
benlesh
approved these changes
Feb 3, 2020
kwonoj
pushed a commit
to kwonoj/rxjs
that referenced
this pull request
Feb 5, 2020
…eactiveX#5280) * feat(retry): add config to reset error count on successful emission This PR adds the ability to reset the error counter on successful emissions using the `retry` operator. The current behavior for `retry(n)` is to call error if n errors occurred, regardless of whether or not they were consecutive. Now one would be able to use `retry(n, true)` to have the count reset so that only n consecutive errors will cause the observable to fail. * feat(retry): add config parameter added overloaded signature to the `retry` operator that accepts a config object * chore: restore package-lock.json * chore: appease TypeScript * chore: revert change to Observable spec
martinsik
pushed a commit
to martinsik/rxjs
that referenced
this pull request
Feb 15, 2020
…eactiveX#5280) * feat(retry): add config to reset error count on successful emission This PR adds the ability to reset the error counter on successful emissions using the `retry` operator. The current behavior for `retry(n)` is to call error if n errors occurred, regardless of whether or not they were consecutive. Now one would be able to use `retry(n, true)` to have the count reset so that only n consecutive errors will cause the observable to fail. * feat(retry): add config parameter added overloaded signature to the `retry` operator that accepts a config object * chore: restore package-lock.json * chore: appease TypeScript * chore: revert change to Observable spec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR cherry picks commits from #4683 but removes/reverts the unnecessary changes made to the
package.jsonand the testing infrastructure. And removes the merge commit.Related PR: #4683