Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing #275

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

GulajavaMinistudio
Copy link
Owner

ReactiveX#5280)

  • feat(retry): add config to reset error count on successful emission

This PR adds the ability to reset the error counter on successful emissions using the retry
operator. The current behavior for retry(n) is to call error if n errors occurred, regardless of
whether or not they were consecutive. Now one would be able to use retry(n, true) to have the
count reset so that only n consecutive errors will cause the observable to fail.

  • feat(retry): add config parameter

added overloaded signature to the retry operator that accepts a config object

  • chore: restore package-lock.json

  • chore: appease TypeScript

  • chore: revert change to Observable spec

Description:

Related issue (if exists):

…5280)

* feat(retry): add config to reset error count on successful emission

This PR adds the ability to reset the error counter on successful emissions using the `retry`
operator. The current behavior for `retry(n)` is to call error if n errors occurred, regardless of
whether or not they were consecutive. Now one would be able to use `retry(n, true)` to have the
count reset so that only n consecutive errors will cause the observable to fail.

* feat(retry): add config parameter

added overloaded signature to the `retry` operator that accepts a config object

* chore: restore package-lock.json

* chore: appease TypeScript

* chore: revert change to Observable spec
@GulajavaMinistudio GulajavaMinistudio merged commit 7614fb8 into GulajavaMinistudio:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants