Fixes #223 #225 #226 #214 #228 #230 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 4, 2014 21:56
…d never be pooled & reused) Channel attribute "rxnetty_http_discard_connection" is used by `ObservableConnection` to discard a connection on close. SSE Inbound handler sets this attribute as a connection on which SSE response has started should never be pooled.
Issue 226: Flushing response when `RequestHandler` emits an error or throws an unexpected error. Issue 225: Connection close for HttpClient.submit() is now done when the content is completed or the (only) subscriber to the content subject unsubscribes.
If no one subscribes to the UnicastContentSubject, for HttpClientResponse, the connection would never be closed. For this reason we should also call the onUnubscribe action when the content is disposed.
Issue ReactiveX#214 Provde getChannel() method in HttpServerRequest Issue ReactiveX#228 Provide getChannel() method in DefaultChannelWriter and deprecate getChannelHandlerContext()
…here is no content.) Also, fixed the test failure for previous PR
NiteshKant
added a commit
that referenced
this pull request
Sep 7, 2014
This was referenced Sep 7, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #223 Force closing underlying physical connection whenever an SSE response is received on it.
Issue #225 Now the connection close is triggered after the content completes or the sole subscriber of the content unsubscribes.
Issue #226 Flushing response when
RequestHandleremits an error or throws an unexpected error.Issue #214
HttpServerRequestshould provide access to the underlyingChannel.Issue #228 Provided
getChannel()inDefaultChannelWriterinstead ofgetChannelHandlerContext().Issue #230 FlatResponseOperator does not emit any item if there is no content.