You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
HttpConnectionHandler does not flush the response on request handling termination to optimize for gathering writes from the request handler.
This makes sense for onComplete() as for graceful completion the RequestHandler must make the decision to flush or not. However, for error, specifically for unexpected errors this default (of not flushing the response) does not make sense as the error could have happened even before the handler had chance to populate/handle the response. In a case when the request handling is done in a different thread* and failed without flushing the response, the response would not be flushed unless some other code invokes flush() on the same connection (in response to a different request).
* The reason why this works for request handling done in the server eventloop is that we do an explicit flush at the channel read complete.
The text was updated successfully, but these errors were encountered:
HttpConnectionHandler
does not flush the response on request handling termination to optimize for gathering writes from the request handler.This makes sense for
onComplete()
as for graceful completion theRequestHandler
must make the decision to flush or not. However, for error, specifically for unexpected errors this default (of not flushing the response) does not make sense as the error could have happened even before the handler had chance to populate/handle the response. In a case when the request handling is done in a different thread*
and failed without flushing the response, the response would not be flushed unless some other code invokesflush()
on the same connection (in response to a different request).*
The reason why this works for request handling done in the server eventloop is that we do an explicit flush at the channel read complete.The text was updated successfully, but these errors were encountered: