2.x: Add efficient concatWith(Single|Maybe|Completable) overloads #5845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #5845 +/- ##
============================================
+ Coverage 96.38% 96.42% +0.04%
- Complexity 5812 5835 +23
============================================
Files 634 640 +6
Lines 41760 41944 +184
Branches 5796 5804 +8
============================================
+ Hits 40251 40446 +195
+ Misses 591 580 -11
Partials 918 918
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Feb 9, 2018
| } else { | ||
| inMaybe = true; | ||
| s = SubscriptionHelper.CANCELLED; | ||
| MaybeSource<? extends T> c = other; |
There was a problem hiding this comment.
should probably be named m
| @Override | ||
| public void onComplete() { | ||
| s = SubscriptionHelper.CANCELLED; | ||
| SingleSource<? extends T> c = other; |
There was a problem hiding this comment.
should probably be named s. But then it's conflicting with the subscription s. So I guess ss would be more appropriate.
| } else { | ||
| inMaybe = true; | ||
| DisposableHelper.replace(this, null); | ||
| MaybeSource<? extends T> c = other; |
There was a problem hiding this comment.
should probably be named m
| public void onComplete() { | ||
| inSingle = true; | ||
| DisposableHelper.replace(this, null); | ||
| SingleSource<? extends T> c = other; |
vanniktech
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds specialized overloads to the
concatWithoperator inFlowableandObservable.If accepted, the marbles will be updated in a separate PR.
Related: #5350.