Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RxJava 2: Observable.concatWith variants for Single, Completable & Maybe. #5350

Closed
vanniktech opened this issue May 17, 2017 · 4 comments
Closed

RxJava 2: Observable.concatWith variants for Single, Completable & Maybe. #5350

vanniktech opened this issue May 17, 2017 · 4 comments
Labels
2.x Discussion

Comments

@vanniktech
Copy link
Collaborator

How do you guys feel about concatWith variants that take Single, Completable and Maybe. For now they could internally just use toObservable() and then maybe later receive custom implementations.
@vanniktech
Copy link
Collaborator Author

Another nice addition would be the mergeWith() as well. Given that this has received some upvotes would you consider adding those methods?

@akarnokd
Copy link
Member

Use Kotlin?

@vanniktech
Copy link
Collaborator Author

I'm doing that right now however having custom implementations could improve performance since certain shortcuts can be taken. For instance knowing that Single can only emit once or error once unlike Observable / Flowable variants.

This was referenced Feb 8, 2018
Merged
Merged
@vanniktech
Copy link
Collaborator Author

This can be closed now with #5845 & #5847

@arekolek arekolek mentioned this issue Jul 18, 2018
Closed
@marianosimone marianosimone mentioned this issue Jul 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akarnokd @vanniktech