Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YouTube - Spoof video streams): Remove iOS, add clients Android TV and Android Creator #4180

Merged
merged 10 commits into from
Dec 21, 2024
Merged

fix(YouTube - Spoof video streams): Remove iOS, add clients Android TV and Android Creator #4180

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0e44d7c
fix(YouTube - Spoof video streams): Use Android VR as default spoof c…
LisoUseInAIKyrios Dec 21, 2024
3d6a9c8
Remove iOS, add Android TV
LisoUseInAIKyrios Dec 21, 2024
51f12d9
Age restricted seems to work. Paid videos probably works since it's …
LisoUseInAIKyrios Dec 21, 2024
e873fb9
Add Android creator client type
LisoUseInAIKyrios Dec 21, 2024
8c40f4f
Fix settings
LisoUseInAIKyrios Dec 21, 2024
853cabd
fix: No good reason to localize the client name
LisoUseInAIKyrios Dec 21, 2024
83d606b
fix: Don't need to rename key since prior default enum type was deleted
LisoUseInAIKyrios Dec 21, 2024
4bb9263
Cleanup
LisoUseInAIKyrios Dec 21, 2024
247af2b
fix: Add disclaimer
LisoUseInAIKyrios Dec 21, 2024
07ebead
fix strings
LisoUseInAIKyrios Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ons/shared/library/src/main/java/app/revanced/extension/shared/settings/BaseSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ public class BaseSettings {
public static final EnumSetting<AudioStreamLanguage> SPOOF_VIDEO_STREAMS_LANGUAGE = new EnumSetting<>("revanced_spoof_video_streams_language", AudioStreamLanguage.DEFAULT, parent(SPOOF_VIDEO_STREAMS));
public static final BooleanSetting SPOOF_VIDEO_STREAMS_IOS_FORCE_AVC = new BooleanSetting("revanced_spoof_video_streams_ios_force_avc", FALSE, true,
"revanced_spoof_video_streams_ios_force_avc_user_dialog_message", new SpoofiOSAvailability());
public static final EnumSetting<ClientType> SPOOF_VIDEO_STREAMS_CLIENT_TYPE = new EnumSetting<>("revanced_spoof_video_streams_client_type", ClientType.IOS, true, parent(SPOOF_VIDEO_STREAMS));
public static final EnumSetting<ClientType> SPOOF_VIDEO_STREAMS_CLIENT_TYPE = new EnumSetting<>("revanced_spoof_video_streams_type", ClientType.ANDROID_VR, true, parent(SPOOF_VIDEO_STREAMS));

}
2 changes: 1 addition & 1 deletion patches/src/main/kotlin/app/revanced/patches/youtube/misc/spoof/SpoofVideoStreamsPatch.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ val spoofVideoStreamsPatch = spoofVideoStreamsPatch({
preferences = setOf(
SwitchPreference("revanced_spoof_video_streams"),
ListPreference(
"revanced_spoof_video_streams_client_type",
"revanced_spoof_video_streams_type",
LisoUseInAIKyrios marked this conversation as resolved.
Show resolved Hide resolved
summaryKey = null,
),
ListPreference(
Expand Down
4 changes: 2 additions & 2 deletions patches/src/main/resources/addresources/values/arrays.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<resources>
<app id="youtube">
<patch id="misc.fix.playback.spoofVideoStreamsPatch">
<string-array name="revanced_spoof_video_streams_client_type_entries">
<string-array name="revanced_spoof_video_streams_type_entries">
<!-- Operating system names are not translatable, so no need to use strings.xml -->
<item>Android VR</item>
<item>iOS</item>
</string-array>
<string-array name="revanced_spoof_video_streams_client_type_entry_values">
<string-array name="revanced_spoof_video_streams_type_entry_values">
<!-- Enum names from extension -->
<item>ANDROID_VR</item>
<item>IOS</item>
Expand Down
5 changes: 3 additions & 2 deletions patches/src/main/resources/addresources/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,15 +1296,16 @@ Enabling this can unlock higher video qualities"</string>

Video playback may not work"</string>
<string name="revanced_spoof_video_streams_user_dialog_message">Turning off this setting may cause video playback issues.</string>
<string name="revanced_spoof_video_streams_client_type_title">Default client</string>
<string name="revanced_spoof_video_streams_type_title">Default client</string>
<string name="revanced_spoof_video_streams_ios_force_avc_title">Force AVC (H.264)</string>
<string name="revanced_spoof_video_streams_ios_force_avc_summary_on">Video codec is forced to AVC (H.264)</string>
<string name="revanced_spoof_video_streams_ios_force_avc_summary_off">Video codec is determined automatically</string>
<string name="revanced_spoof_video_streams_ios_force_avc_user_dialog_message">"Enabling this might improve battery life and fix playback stuttering.

AVC has a maximum resolution of 1080p, Opus audio codec is not available, and video playback will use more internet data than VP9 or AV1."</string>
<string name="revanced_spoof_video_streams_about_ios_title">iOS spoofing side effects</string>
<string name="revanced_spoof_video_streams_about_ios_summary">"• Private kids videos may not play
<string name="revanced_spoof_video_streams_about_ios_summary">"• Video playback may not work
• Private kids videos may not play
• Videos end 1 second early"</string>
<string name="revanced_spoof_video_streams_about_android_vr_title">Android VR spoofing side effects</string>
<string name="revanced_spoof_video_streams_about_android_vr_summary">"• Kids videos may not play
Expand Down
Loading