Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(YouTube - Spoof video streams): Remove iOS, add clients Android TV and Android Creator #4180

Merged
merged 10 commits into from
Dec 21, 2024
Merged

fix(YouTube - Spoof video streams): Remove iOS, add clients Android TV and Android Creator #4180

merged 10 commits into from
Dec 21, 2024

Conversation

LisoUseInAIKyrios
Copy link
Contributor

iOS is is starting to have playback issues and patch changes are needed.

For now, use Android VR as default since it still works.

oSumAtrIX
oSumAtrIX approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS can technically be removed otherwise it may return video streams that fail to play

@LisoUseInAIKyrios
Copy link
Contributor Author

Ok then for this PR I'll remove the spoof client type setting from the UI so users cannot change from Android VR.

@LisoUseInAIKyrios
Copy link
Contributor Author

Or add Android TV as a secondary client type. I'll try that now.

@oSumAtrIX
Copy link
Member

Not only that, if VR requests fail such as for kids videos, then iOS would be used. It needs to be removed

@LisoUseInAIKyrios
Copy link
Contributor Author

Yes that's true. Will remove iOS.

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Dec 21, 2024 •
edited
Loading

ANDROID_CREATOR is being suggested. You can find it in the yt-dlp repo

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(YouTube - Spoof video streams): Use Android VR as default spoof client fix(YouTube - Spoof video streams): Remove iOS client, add Android TV client Dec 21, 2024
@LisoUseInAIKyrios
Copy link
Contributor Author

Maybe in a separate PR bump the recommended version to 19.47.53, since so many people think the app version is the same as the patch version.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(YouTube - Spoof video streams): Remove iOS client, add Android TV client fix(YouTube - Spoof video streams): Remove iOS, add clients Android TV and Android Creator Dec 21, 2024
@LisoUseInAIKyrios
Copy link
Contributor Author

Seems ready. Any opinions before committing?

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 86abfb2 into ReVanced:dev Dec 21, 2024
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/spoof_android_vr_default branch December 21, 2024 11:33
github-actions bot pushed a commit that referenced this pull request Dec 21, 2024
@semantic-release-bot
chore: Release v5.6.1-dev.2 [skip ci]
69ee16c 
## [5.6.1-dev.2](v5.6.1-dev.1...v5.6.1-dev.2) (2024-12-21)

### Bug Fixes

* **YouTube - Spoof video streams:** Remove iOS, add clients Android TV and Android Creator ([#4180](#4180)) ([86abfb2](86abfb2))
@Karthik-Subbu
Copy link

iOS is is starting to have playback issues and patch changes are needed.

For now, use Android VR as default since it still works.

Many users started reporting? IOS failing only for age restricted music videos or in general?

@LisoUseInAIKyrios
Copy link
Contributor Author

That's what I said

iOS is is starting to have playback issues and patch changes are needed.

@Karthik-Subbu
Copy link

I think it is worth evaluating how the spoof client approach behaves for playback issues. Would there be any difference if ios client is used but with the old spoof client approach?

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Dec 21, 2024 that may be closed by this pull request
bug: YouTube Playback stopped at 1:00 #4176
Closed
3 tasks
github-actions bot pushed a commit that referenced this pull request Dec 22, 2024
@semantic-release-bot
chore: Release v5.7.0 [skip ci]
f7d5701 
# [5.7.0](v5.6.0...v5.7.0) (2024-12-22)

### Bug Fixes

* **YouTube - Force original audio:** Use correct availability for settings UI ([a7eedcb](a7eedcb))
* **YouTube - Spoof video stream:** Remove UI client type setting.  Allow setting default audio language. ([#4184](#4184)) ([99f3f29](99f3f29))
* **YouTube - Spoof video streams:** Remove iOS, add clients Android TV and Android Creator ([#4180](#4180)) ([86abfb2](86abfb2))
* **YouTube:** Change fingerprints to support a wider range of target versions ([8a09174](8a09174))

### Features

* **YouTube:** Support version `19.47.53` ([#4182](#4182)) ([2089e61](2089e61))
@alcatraz-zz
Copy link

alcatraz-zz commented Dec 23, 2024 •
edited
Loading

How about changing the default spoof setting but allow iOS to remain available?

Edit: I noticed the iOS client got updated in 5.6.0. I'm on 5.5.1
and haven't experienced issues. Maybe it's your update people are having issues with?

I reverted to an older patch version to enable iOS spoofing. I use it daily and never had playback issues. I need it because it's the only spoof setting that offers AV1 streams. (AV1 makes a big difference for me because I get higher qualities/less buffer issues compared with VP9. This is isp and not app related.)

@LisoUseInAIKyrios
Copy link
Contributor Author

Going to add iOS tv as an option.

Regular iOS is dead and it's only a matter of time before it stops working for everyone (likely very soon).

@Karthik-Subbu
Copy link

Default audio language can be set any language now? Or any restrictions?

@alcatraz-zz
Copy link

Going to add iOS tv as an option.

Regular iOS is dead and it's only a matter of time before it stops working for everyone (likely very soon).

Is there any other way to enable AV1? Hmm.

This was referenced Dec 27, 2024
Open
Open
@Adity1243
Copy link

Can stable volume supports in ios tv or in android vr client with AV01 codec

@Figim Figim mentioned this pull request Dec 31, 2024
Closed
github-actions bot pushed a commit to Flat/revanced-patches that referenced this pull request Jan 15, 2025
@semantic-release-bot
chore: Release v5.3.0 [skip ci]
7b9b3de 
# [5.3.0](v5.2.0...v5.3.0) (2025-01-15)

### Bug Fixes

* **Change package name:** Prevent applying the patch to known incompatible apps ([ReVanced#3943](https://github.com/Flat/revanced-patches/issues/3943)) ([44936e7](44936e7))
* **ci:** update url for publishing ([a08568b](a08568b))
* **GmsCore support:** Adjust presentation of battery optimization dialog  ([ReVanced#4091](https://github.com/Flat/revanced-patches/issues/4091)) ([5d8fc1b](5d8fc1b))
* **GmsCore support:** Do not show battery optimization error on Android Automotive devices (Google built-in) ([ReVanced#4218](https://github.com/Flat/revanced-patches/issues/4218)) ([d6e389c](d6e389c))
* **Reddit:** Fix patches by using correct extension class ([70bdc68](70bdc68))
* **Sync for Reddit:** Fix patches by using correct extension name ([030093e](030093e))
* **TikTok - Settings:** Use correct colors for dark mode ([ReVanced#4087](https://github.com/Flat/revanced-patches/issues/4087)) ([6bd22ff](6bd22ff))
* **TikTok - SIM Spoof:** Change patch to default off to fix login ([ReVanced#4084](https://github.com/Flat/revanced-patches/issues/4084)) ([f4659a3](f4659a3))
* **Twitch:** Change recommended target to the latest app version ([fb32972](fb32972))
* **Twitch:** Resolve setting menu crashes ([ReVanced#4025](https://github.com/Flat/revanced-patches/issues/4025)) ([62df596](62df596))
* **Twitter - Change link sharing domain:** Use correct extension package ([ad7fab6](ad7fab6))
* **twitter:** doubleclick ads ([c32fe2e](c32fe2e))
* **Twitter:** Merge correct extension by depending on correct extension patch ([8281cf6](8281cf6))
* **YouTube - Exit fullscreen mode:** Exit fullscreen mode of first video opened after cold start ([be5cf2e](be5cf2e))
* **YouTube - Force original audio:** If stream spoofing to Android then show a summary text why force audio is not available ([ReVanced#4220](https://github.com/Flat/revanced-patches/issues/4220)) ([029aee8](029aee8))
* **YouTube - Force original audio:** Use correct availability for settings UI ([a7eedcb](a7eedcb))
* **YouTube - Force original audio:** Use correct original audio stream if app language is not English ([0d20171](0d20171))
* **YouTube - Hide ads:** Hide new type of featured promotions ([ReVanced#4113](https://github.com/Flat/revanced-patches/issues/4113)) ([13c7592](13c7592))
* **YouTube - Hide layout components:** Don't hide Shorts channel bar when toggling for video player ([9af6412](9af6412))
* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4155](https://github.com/Flat/revanced-patches/issues/4155)) ([08f68cb](08f68cb))
* **YouTube - Miniplayer:** Use estimated maximum on screen size for devices with low density screens ([ReVanced#4150](https://github.com/Flat/revanced-patches/issues/4150)) ([2694158](2694158))
* **YouTube - Open Shorts in regular player:** Do not show the miniplayer after opening a Short while a video is playing ([894e366](894e366))
* **YouTube - SponsorBlock:** Show a toast and not a dialog if segment submitted successfully ([134b189](134b189))
* **YouTube - SponsorBlock:** Show create new segment error messages using a dialog ([ReVanced#4148](https://github.com/Flat/revanced-patches/issues/4148)) ([5870906](5870906))
* **YouTube - Spoof app version:** Update spoof target to resolve library tab crashes ([ReVanced#4014](https://github.com/Flat/revanced-patches/issues/4014)) ([c8eced5](c8eced5))
* **YouTube - Spoof app version:** Update spoof target to resolve library tab crashes ([ReVanced#4019](https://github.com/Flat/revanced-patches/issues/4019)) ([d89ad65](d89ad65))
* **YouTube - Spoof video stream:** Remove UI client type setting.  Allow setting default audio language. ([ReVanced#4184](https://github.com/Flat/revanced-patches/issues/4184)) ([99f3f29](99f3f29))
* **YouTube - Spoof video streams:** Add 'Android Creator' ([ReVanced#4262](https://github.com/Flat/revanced-patches/issues/4262)) ([0479dd2](0479dd2))
* **YouTube - Spoof video streams:** Add iOS TV client, restore iOS 'force AVC', show client type in stats for nerds ([ReVanced#4202](https://github.com/Flat/revanced-patches/issues/4202)) ([ab29f80](ab29f80))
* **YouTube - Spoof video streams:** Add missing preferred language preference to the settings ([630633c](630633c))
* **YouTube - Spoof video streams:** Change default spoofing to iOS, allow setting a default language with Android VR ([ReVanced#4171](https://github.com/Flat/revanced-patches/issues/4171)) ([171b4e7](171b4e7))
* **YouTube - Spoof video streams:** Enable opus codec by updating iOS client version ([ReVanced#4063](https://github.com/Flat/revanced-patches/issues/4063)) ([0af156f](0af156f))
* **YouTube - Spoof video streams:** Fix error toast that is sometimes shown ([ReVanced#4090](https://github.com/Flat/revanced-patches/issues/4090)) ([4c46cb2](4c46cb2))
* **YouTube - Spoof video streams:** Ignore harmless error toast if hide ads is disabled ([c3423bb](c3423bb))
* **YouTube - Spoof video streams:** Make livestreams start at the current time when using iOS client   ([ReVanced#4137](https://github.com/Flat/revanced-patches/issues/4137)) ([140f484](140f484))
* **YouTube - Spoof video streams:** Remove iOS, add clients Android TV and Android Creator ([ReVanced#4180](https://github.com/Flat/revanced-patches/issues/4180)) ([86abfb2](86abfb2))
* **YouTube - Spoof video streams:** Resolve playback of age restricted videos ([ReVanced#4096](https://github.com/Flat/revanced-patches/issues/4096)) ([839a404](839a404))
* **YouTube - Spoof video streams:** Update `Force AVC` client data ([ReVanced#4064](https://github.com/Flat/revanced-patches/issues/4064)) ([7d537dd](7d537dd))
* **YouTube - Spoof video streams:** Update iOS client version ([df3aeed](df3aeed))
* **YouTube - Spoof video streams:** Use 2 letter device language code ([33ff997](33ff997))
* **YouTube - Spoof video streams:** Use Android VR authentication if using default audio language ([ReVanced#4191](https://github.com/Flat/revanced-patches/issues/4191)) ([98773cc](98773cc))
* **YouTube - Spoof video streams:** Use system language as default iOS audio stream ([ReVanced#4042](https://github.com/Flat/revanced-patches/issues/4042)) ([4017185](4017185))
* **YouTube - Theme:** Use dark theme color for status and navigation bar ([0240efe](0240efe))
* **YouTube Music - Bypass certificate checks:** Add a recommended target version ([ReVanced#4104](https://github.com/Flat/revanced-patches/issues/4104)) ([17a5a6c](17a5a6c))
* **YouTube Music - GmsCore support:** Resolve patching errors ([ReVanced#4056](https://github.com/Flat/revanced-patches/issues/4056)) ([38a4bad](38a4bad))
* **YouTube Music - Hide category bar:** Add support for latest release ([ReVanced#3968](https://github.com/Flat/revanced-patches/issues/3968)) ([b63fdeb](b63fdeb))
* **YouTube Music - Permanent shuffle:** Remove obsolete and non functional patch ([ReVanced#4073](https://github.com/Flat/revanced-patches/issues/4073)) ([fbc6ab6](fbc6ab6))
* **YouTube Music - Spoof video streams:** Disable stable volume ([ReVanced#4097](https://github.com/Flat/revanced-patches/issues/4097)) ([16bb9df](16bb9df))
* **YouTube Music:** Add `Spoof client patch` to fix playback ([ReVanced#4132](https://github.com/Flat/revanced-patches/issues/4132)) ([b092508](b092508))
* **YouTube:** Change fingerprints to support a wider range of target versions ([8a09174](8a09174))
* **YouTube:** Do not reset playback speed to 1.0x after closing comment thread (Fixes stock YouTube bug) ([ReVanced#4195](https://github.com/Flat/revanced-patches/issues/4195)) ([dda788c](dda788c))
* **YouTube:** Fix string translations ([52e04d3](52e04d3))

### Features

* Add Internal data documents provider patch ([ReVanced#3830](https://github.com/Flat/revanced-patches/issues/3830)) ([cb22f65](cb22f65))
* **Change package name:** Add options to change provider and permission package names to handle installation conflicts ([75c740c](75c740c))
* **Nyx:** Remove broken `Unlock pro` patch ([1fe8b16](1fe8b16))
* **Swipe controls:** Add option to enable/disable fullscreen swipe to next video ([ReVanced#4222](https://github.com/Flat/revanced-patches/issues/4222)) ([119092f](119092f))
* **Twitch:** Make patches compatible with latest versions ([ReVanced#4099](https://github.com/Flat/revanced-patches/issues/4099)) ([eecfbb7](eecfbb7))
* **YouTube - Comments:** Add `Hide 'Chat summary'` ([ReVanced#4110](https://github.com/Flat/revanced-patches/issues/4110)) ([269493c](269493c))
* **YouTube - Hide feed components:** Remove obsolete `Hide search result shelf header` option ([ReVanced#4134](https://github.com/Flat/revanced-patches/issues/4134)) ([c71443a](c71443a))
* **YouTube - Hide Shorts components:** Add option to hide Shorts in watch history ([ReVanced#4214](https://github.com/Flat/revanced-patches/issues/4214)) ([19c2742](19c2742))
* **YouTube - Navigation buttons:** Add options to disable translucent status bar and navigation bar ([ReVanced#4133](https://github.com/Flat/revanced-patches/issues/4133)) ([a2d2141](a2d2141))
* **YouTube - Spoof app version:** Add 'Restore old navigation and toolbar icons' ([f84e459](f84e459))
* **YouTube - Spoof video streams:** Allow picking a default audio language track ([ReVanced#4050](https://github.com/Flat/revanced-patches/issues/4050)) ([ede666b](ede666b))
* **YouTube Music:** Add `Spoof video streams` patch to fix playback ([ReVanced#4065](https://github.com/Flat/revanced-patches/issues/4065)) ([cf3116a](cf3116a))
* **YouTube:** Add `Change form factor` patch ([ReVanced#4217](https://github.com/Flat/revanced-patches/issues/4217)) ([644ac5b](644ac5b))
* **YouTube:** Add `Exit fullscreen mode` patch ([ReVanced#4223](https://github.com/Flat/revanced-patches/issues/4223)) ([bb5d03b](bb5d03b))
* **YouTube:** Add `Force original audio` patch ([ReVanced#4122](https://github.com/Flat/revanced-patches/issues/4122)) ([f4aa440](f4aa440))
* **YouTube:** Add `Open Shorts in regular player` patch ([ReVanced#4153](https://github.com/Flat/revanced-patches/issues/4153)) ([c7c5e5b](c7c5e5b))
* **YouTube:** Add `Open videos fullscreen` patch ([ReVanced#4069](https://github.com/Flat/revanced-patches/issues/4069)) ([296d63b](296d63b))
* **YouTube:** Add in app option to select a preferred language for ReVanced specific text ([ReVanced#4231](https://github.com/Flat/revanced-patches/issues/4231)) ([3932af3](3932af3))
* **YouTube:** Support version `19.47.53` ([ReVanced#4182](https://github.com/Flat/revanced-patches/issues/4182)) ([2089e61](2089e61))

### Performance Improvements

* Move variables to local scope ([43c0421](43c0421))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oSumAtrIX oSumAtrIX oSumAtrIX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: YouTube Playback stopped at 1:00
5 participants
@LisoUseInAIKyrios @oSumAtrIX @Karthik-Subbu @alcatraz-zz @Adity1243