Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Sync translations #4105

Merged
merged 1 commit into from
Dec 12, 2024
Merged

chore: Sync translations #4105

merged 1 commit into from
Dec 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Sync translations from crowdin.com/project/revanced

@github-actions github-actions bot force-pushed the feat/translations branch 3 times, most recently from 7a40ac8 to 1cff34b Compare December 11, 2024 12:23
@LisoUseInAIKyrios
Copy link
Contributor

The AI translations looks at the string context, which for some strings has commented out add resource tags:

    <!-- <app id="shared"> -->
        <!-- <patch id="misc.checks.checkEnvironmentPatch"> -->
            <string name="revanced_check_environment_failed_title">Checks failed</string>

I tried changing the preprocessor regex rules to make these a comment of an ignored tag:

    <!-- <app id="shared"> -->
   <ignore/>
        <!-- <patch id="misc.checks.checkEnvironmentPatch"> -->
        <ignore/>
            <string name="revanced_check_environment_failed_title">Checks failed</string>

And this works for imported and the commented out elements do not show as a string context,
But...during export Crowdin is stripping out all unknown tags including the comments.

So this won't work

@github-actions github-actions bot force-pushed the feat/translations branch 4 times, most recently from 9257d12 to 6c04f51 Compare December 11, 2024 12:59
@cyberboh
Copy link

I see on crowdin, most translated strings are gone, but they are already translated by ReVanced (idk, this bot or real human :D)
Only some untranslated strings are needed to translation, but i recently translated them. :)

@MarcaDian
Copy link
Contributor

MarcaDian commented Dec 11, 2024

@cyberboh I don't know about you, but my language always has some problems... 🥴

Now I have to check and approve each line, and there are more than 1,000 of them. The reason for all this is the "memory" of Crowdin, who remembered the wrong translation and now returns it every time.
I'll probably just import the translation file from the previous build, it'll be easier that way.

Screenshot_2024-12-11-15-42-35-946_com.android.chrome-edit.jpg

@LisoUseInAIKyrios
Copy link
Contributor

I just deleted the video resolution strings (those can be hard coded).

@MarcaDian Do you want me to delete all prior translation memories for Ukraine? The translations already created will stay, but nothing will be added to TM until a person suggests a new translation or a machine translation is approved.

@LisoUseInAIKyrios
Copy link
Contributor

A typo in the regex caused all the old approvals to be removed.

Since it's a free crowdin plan there is no revert function 😒

The Google Gemini translations are running now and slowly being added.

@MarcaDian
Copy link
Contributor

Do you want me to delete all prior translation memories for Ukraine?

That would be very good. Is it better to do it before or after importing the translation I wrote above?

@LisoUseInAIKyrios
Copy link
Contributor

All Ukraine TM entries have been deleted. You can import the prior build and it should add those strings to TM.

@github-actions github-actions bot force-pushed the feat/translations branch 12 times, most recently from 3d15aea to 6e6b89d Compare December 12, 2024 14:57
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit c696b5f into dev Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants