Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YouTube - Settings): Do not clip settings menus when using an Android 15 device #3999

Merged
merged 4 commits into from
Nov 27, 2024
Merged

fix(YouTube - Settings): Do not clip settings menus when using an Android 15 device #3999

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4dfcee
fix(YouTube - Settings): Do not clip settings menus when using an And…
LisoUseInAIKyrios Nov 26, 2024
f57fc2c
fix: Change SDK to 35 (Android 15), apply menu fix only for Android 1…
LisoUseInAIKyrios Nov 26, 2024
849d566
Revert "fix: Change SDK to 35 (Android 15), apply menu fix only for A…
LisoUseInAIKyrios Nov 27, 2024
4916bbc
comments
LisoUseInAIKyrios Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...in/java/app/revanced/extension/shared/settings/preference/AbstractPreferenceFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@
import android.app.Dialog;
import android.content.Context;
import android.content.SharedPreferences;
import android.graphics.Insets;
import android.graphics.drawable.Drawable;
import android.os.Build;
import android.os.Bundle;
import android.preference.*;
import android.util.TypedValue;
import android.view.ViewGroup;
import android.view.WindowInsets;
import android.widget.TextView;
import android.widget.Toolbar;

Expand Down Expand Up @@ -310,6 +312,18 @@ private void setPreferenceScreenToolbar(PreferenceScreen parentScreen) {
.findViewById(android.R.id.content)
.getParent();

// Fix required for Android 15 and YT 19.45+
// FIXME:
// On Android 15 the text layout is not aligned the same as the parent
// screen and it looks a little off. Otherwise this works.
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {
LisoUseInAIKyrios marked this conversation as resolved.
Show resolved Hide resolved
rootView.setOnApplyWindowInsetsListener((v, insets) -> {
Insets statusInsets = insets.getInsets(WindowInsets.Type.statusBars());
v.setPadding(0, statusInsets.top, 0, 0);
return insets;
});
}

Toolbar toolbar = new Toolbar(childScreen.getContext());
toolbar.setTitle(childScreen.getTitle());
toolbar.setNavigationIcon(getBackButtonDrawable());
Expand Down