Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube): Hide the 'Visit store' button on channel pages #3058

Closed
3 tasks done
ILoveOpenSourceApplications opened this issue Apr 21, 2024 · 8 comments · Fixed by #3077
Closed
3 tasks done

feat(YouTube): Hide the 'Visit store' button on channel pages #3058

ILoveOpenSourceApplications opened this issue Apr 21, 2024 · 8 comments · Fixed by #3077
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@ILoveOpenSourceApplications
Copy link
Contributor

Feature description

Hide the 'Visit store' button in the channel page.
Screenshot_20240421_175421_YouTube

Motivation

Well, clicking it leads the user to a page full of products from the channels, so basically ad blocking.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Feature request Requesting a new feature that's not implemented yet label Apr 21, 2024
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title feat(YouTube/Hide Visit store button: Hide the 'Visit store' button in channel feat(YouTube/Hide 'Visit store' button: Hide the 'Visit store' button in channel Apr 21, 2024
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title feat(YouTube/Hide 'Visit store' button: Hide the 'Visit store' button in channel feat(YouTube/Hide 'Visit store' button: Hides the 'Visit store' button in channel Apr 21, 2024
@ILoveOpenSourceApplications
Copy link
Contributor Author

I tried the litho component ^channel_profile.eml$header_store_button in custom filter and that seems to work.

04-21 18:08:29.982 11186 11186 D revanced: LithoFilterPatch: Searching ID: null Path: channel_profile.eml|fe7264abae464c88|channel_profile_phone.eml|4a5e3ed8b99b52ed|ContainerType|channel_action_buttons_phone.eml|93f701b73481db51|ContainerType|button.eml|e4d01425197b9e68|ContainerType| BufferStrings: Visit storeΓ¥Ösans-serifΓ¥Öeml.header_store_buttonΓ¥ÖUCV6mNrW8CrmWtcxWfQXy11gΓ¥Ö8gYEEgIqAA%3D%3D"Γ¥Ö/@DarkViperAUΓ¥Ö
04-21 18:08:29.982 11186 11186 D revanced: LithoFilterPatch: Searching ID: null Path: channel_profile.eml|fe7264abae464c88|channel_profile_phone.eml|4a5e3ed8b99b52ed|ContainerType|channel_action_buttons_phone.eml|93f701b73481db51|ContainerType|button.eml|e4d01425197b9e68|ContainerType|TextType| BufferStrings: Visit storeΓ¥Ösans-serifΓ¥Öeml.header_store_buttonΓ¥ÖUCV6mNrW8CrmWtcxWfQXy11gΓ¥Ö8gYEEgIqAA%3D%3D"Γ¥Ö/@DarkViperAUΓ¥Ö

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(YouTube/Hide 'Visit store' button: Hides the 'Visit store' button in channel feat(YouTube): Hide the 'Visit store' button on channel pages Apr 21, 2024
@oSumAtrIX oSumAtrIX added the Prioritized Prioritization over other issues label Apr 21, 2024
@oSumAtrIX
Copy link
Member

Is header_store_button not a path builder string?

@ILoveOpenSourceApplications
Copy link
Contributor Author

Is header_store_button not a path builder string?

No, it's in the bufferstrings.

@n1cKz1
Copy link

n1cKz1 commented Apr 23, 2024

Since this is still in dev I didn't wanna create a new issue about this: "Hide the 'Visit store' button on channel pages" is a little too long. Also, what do you think about creating a "Channel page" subcategory in Layout settings?

@LisoUseInAIKyrios
Copy link
Contributor

Changing strings pushed from YT is very difficult and not realistic for most cases.

List all the different 'channel page' settings, and if there's enough then a sub-menu under 'feed' could be made.

@n1cKz1
Copy link

n1cKz1 commented Apr 24, 2024

Could at least remove the "the" to shorten it a bit

List all the different 'channel page' settings, and if there's enough then a sub-menu under 'feed' could be made.

Well currently there's 3: channel member shelf, 'for you' shelf and visit store button, also in the case #3059 gets implemented then I think 4 is more than enough

@oSumAtrIX
Copy link
Member

If you remove "the" it won't be a proper sentence anymore.

@LisoUseInAIKyrios LisoUseInAIKyrios removed the Prioritized Prioritization over other issues label May 31, 2024
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title feat(YouTube): Hide the 'Visit store' button on channel pages feat(YouTube): Hide the 'Visit store' button on channel profiles Jun 7, 2024
@ILoveOpenSourceApplications
Copy link
Contributor Author

ILoveOpenSourceApplications commented Jun 11, 2024

A heads up. YouTube changed the path for 'Visit store' button. It's now ^page_header.eml$header_store_button and leaves behind a blank space where the button was unlike the previous one.

Screenshot_20240611_114736_YouTube

06-11 11:28:53.736 29858 29858 D revanced: LithoFilterPatch: Searching ID: null Path: page_header.eml|29bf20f8b14236d4|ContainerType|ContainerType|ContainerType|flexible_actions.eml|daf1064fca739913|ContainerType|ContainerType|ContainerType|button.eml|ebc698722222cbfe|ContainerType| BufferStrings: Visit storeΓ¥Ösans-serifΓ¥Öeml.header_store_buttonΓ¥ÖVisit storeΓ¥ÖUCKqH_9mk1waLgBiL2vT5b9gΓ¥ÖEgVzdG9yZfIGBBICKgA%3D"Γ¥Ö/@VanossGamingΓ¥Ö

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title feat(YouTube): Hide the 'Visit store' button on channel profiles feat(YouTube): Hide the 'Visit store' button on channel pages Jun 11, 2024
validcube pushed a commit to validcube/revanced-patches that referenced this issue Aug 6, 2024
validcube pushed a commit to validcube/revanced-patches that referenced this issue Aug 6, 2024
# [2.191.0](ReVanced/revanced-patches@v2.190.0...v2.191.0) (2023-10-04)

### Bug Fixes

* Add hooks to existing hook set ([5655067](ReVanced/revanced-patches@5655067))
* **Duolingo - Unlock Super:** Get correct instruction offset ([ReVanced#3023](ReVanced/revanced-patches#3023)) ([5146de8](ReVanced/revanced-patches@5146de8))
* **Google Recorder - Remove device restrictions:** Clarify limitation ([094f57b](ReVanced/revanced-patches@094f57b))
* **Infinity for Reddit - Spoof client:** Constrain patch to last working versions ([ReVanced#2944](ReVanced/revanced-patches#2944)) ([ee975de](ReVanced/revanced-patches@ee975de))
* **Relay - Spoof client:** Restore OAuth login ([96e01f7](ReVanced/revanced-patches@96e01f7))
* **Slide - Spoof client:** Use correct patch name ([f355dbf](ReVanced/revanced-patches@f355dbf))
* **Sync for Reddit:** Do not throw an error when not necessary ([ef644e4](ReVanced/revanced-patches@ef644e4))
* **TikTok - Hide ads:** Constrain to last working version ([56e45a6](ReVanced/revanced-patches@56e45a6))
* **Twitch - Audio ads:** Support missing version `16.1.0` ([ReVanced#2928](ReVanced/revanced-patches#2928)) ([688d8fa](ReVanced/revanced-patches@688d8fa))
* Use consistent toggle description ([ReVanced#2983](ReVanced/revanced-patches#2983)) ([ceaa512](ReVanced/revanced-patches@ceaa512))
* Use correct instruction ([246cf2c](ReVanced/revanced-patches@246cf2c))
* **YouTube - Client spoof:** adjust settings text ([ReVanced#3035](ReVanced/revanced-patches#3035)) ([59a2e96](ReVanced/revanced-patches@59a2e96))
* **YouTube - Client spoof:** Display seekbar thumbnails in high quality ([5e8a2d3](ReVanced/revanced-patches@5e8a2d3))
* **YouTube - Client spoof:** Do not record feed videos to history by default ([ReVanced#3017](ReVanced/revanced-patches#3017)) ([5ccbf1b](ReVanced/revanced-patches@5ccbf1b))
* **YouTube - Client spoof:** Removed unused code ([ReVanced#3030](ReVanced/revanced-patches#3030)) ([15e27bf](ReVanced/revanced-patches@15e27bf))
* **YouTube - Client spoof:** Restore seekbar thumbnails ([bf4a115](ReVanced/revanced-patches@bf4a115))
* **YouTube - Client spoof:** Show seekbar thumbnail for age restricted and paid videos ([1a79300](ReVanced/revanced-patches@1a79300))
* **YouTube - Custom filter:** Use new lines between components instead of commas ([ReVanced#2952](ReVanced/revanced-patches#2952)) ([ecb2e32](ReVanced/revanced-patches@ecb2e32))
* **YouTube - Hide "Load more" button:** Use correct names ([569c3cd](ReVanced/revanced-patches@569c3cd))
* **YouTube - Hide info cards:** Fix info cards not hiding for some users ([ReVanced#3039](ReVanced/revanced-patches#3039)) ([cb38637](ReVanced/revanced-patches@cb38637))
* **YouTube - Hide layout components:** Always hide redundant 'player audio track' button ([ReVanced#2951](ReVanced/revanced-patches#2951)) ([ca632bd](ReVanced/revanced-patches@ca632bd))
* **YouTube - Hide shorts components:** Fix hiding navigation bar ([2de51e6](ReVanced/revanced-patches@2de51e6))
* **YouTube - Premium heading:** Correct inverted logic ([ReVanced#3042](ReVanced/revanced-patches#3042)) ([b33ed75](ReVanced/revanced-patches@b33ed75))
* **YouTube - ReturnYouTubeDislike:** Revert support for 18.37.36 ([ReVanced#3041](ReVanced/revanced-patches#3041)) ([3761073](ReVanced/revanced-patches@3761073))
* **YouTube - SponsorBlock:** Adjust import/export UI text ([ReVanced#3063](ReVanced/revanced-patches#3063)) ([4e5513e](ReVanced/revanced-patches@4e5513e))
* **YouTube - Video Id:** Fix video id not showing the currently playing video ([ReVanced#3038](ReVanced/revanced-patches#3038)) ([f6f226b](ReVanced/revanced-patches@f6f226b))
* **YouTube:** Restore functionality of `Old video quality menu` and `Custom speeds` on tablets ([ReVanced#2999](ReVanced/revanced-patches#2999)) ([238bed1](ReVanced/revanced-patches@238bed1))

### Features

* Add notice for thumbnails for age restricted or paid videos ([f7cf70b](ReVanced/revanced-patches@f7cf70b))
* **Duolingo:** Remove `Unlock Duolingo Super` patch ([b4b9746](ReVanced/revanced-patches@b4b9746))
* **SPB Serviceportal Bund:** Add `Remove root detection` patch ([ReVanced#3049](ReVanced/revanced-patches#3049)) ([481bf58](ReVanced/revanced-patches@481bf58))
* **Strava:** Add `Disable subscription suggestions` patch ([ReVanced#2997](ReVanced/revanced-patches#2997)) ([af02175](ReVanced/revanced-patches@af02175))
* **Sync for Reddit - Client spoof:** Restore upload functionality ([9344c8a](ReVanced/revanced-patches@9344c8a))
* **TikTok - Hide ads:** Constrain to last working version ([516e8a1](ReVanced/revanced-patches@516e8a1))
* **TU Dortmund:** Add `Show on lockscreen` patch ([ReVanced#2947](ReVanced/revanced-patches#2947)) ([9a18326](ReVanced/revanced-patches@9a18326))
* **Tumblr:** Add `Disable blog notification reminder` patch ([29f19b9](ReVanced/revanced-patches@29f19b9))
* **Tumblr:** Add `Disable dashboard ads` patch ([ReVanced#2979](ReVanced/revanced-patches#2979)) ([07c267a](ReVanced/revanced-patches@07c267a))
* **Tumblr:** Add `Disable gift message popup` patch ([a4d6b4e](ReVanced/revanced-patches@a4d6b4e))
* **Tumblr:** Add `Disable in-app update` patch ([ReVanced#3058](ReVanced/revanced-patches#3058)) ([5e8076b](ReVanced/revanced-patches@5e8076b))
* **Tumblr:** Add `Disable Tumblr Live` patch ([ReVanced#2987](ReVanced/revanced-patches#2987)) ([bf1f9dc](ReVanced/revanced-patches@bf1f9dc))
* **Twitch - Block embedded ads:** Switch from `ttv.lol` to `luminous.dev` ([0fe115e](ReVanced/revanced-patches@0fe115e))
* Use properties file for `Client spoof` patches ([e5d548c](ReVanced/revanced-patches@e5d548c))
* **YouTube - Hide layout components:** Hide "Join" button ([1b71f89](ReVanced/revanced-patches@1b71f89))
* **YouTube - Hide layout components:** Hide "Notify me" button ([3027c15](ReVanced/revanced-patches@3027c15))
* **YouTube - Hide layout components:** Hide search result shelf header ([f4eda8c](ReVanced/revanced-patches@f4eda8c))
* **YouTube - Hide layout components:** Hide timed reactions ([d0a775d](ReVanced/revanced-patches@d0a775d))
* **YouTube - Premium heading:** Allow using default heading ([ReVanced#3029](ReVanced/revanced-patches#3029)) ([d5ab35a](ReVanced/revanced-patches@d5ab35a))
* **YouTube - Spoof app version:** add version 18.20.39 ([ReVanced#3001](ReVanced/revanced-patches#3001)) ([f14c5e7](ReVanced/revanced-patches@f14c5e7))
* **YouTube:** Add `Bypass URL redirects` patch ([125cac5](ReVanced/revanced-patches@125cac5))
* **YouTube:** Bump compatibility to `18.37.36` ([ReVanced#3028](ReVanced/revanced-patches#3028)) ([eda28e5](ReVanced/revanced-patches@eda28e5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
4 participants