bug(youtube): swipe brightness control on HDR videos are acting funky

[SodaWithoutSparkles]

Type

Error at runtime

Bug description

Swipe brightness is acting funky on HDR videos, possibly interfering with HDR auto brightness

Steps to reproduce

1. Patch YT 17.36.37 with manager 0.0.30 with all patches except debugging, auto repeat, wide search bar
2. Enable swipt brightness and sound control
3. Play a sample HDR video like this one or this one or this one
4. Fullscreen the video and swipe to control brightness on the left side
5. Brightness control is not working normally

Relevant log output

N/A

Screenshots or videos

video resolution reduced for uploading, also muted

Screenrecorder-2022-10-09-20-12-27-791.0.mp4

Solution

Swipe brightness ctrl should be prioritized before HDR auto brightness.

Additional context

No response

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.

[its0x08]

Works perfectly on MIUI 13.0.4 POCO F3.
Latest supported YT and Revanced tools

[SodaWithoutSparkles]

Strange, I am also on MIUI 13.0.5 Amdroid 12 POCO X4 GT

@its0x08 did you enable HDR auto brightness under settings > revanced > miscellaneous ?

[its0x08]

I just confirmed that the video you mentioned makes YouTube works weird!

I answered above based on other hdr videos 🤔

[its0x08]

Strange, I am also on MIUI 13.0.5 Amdroid 12 POCO X4 GT

@its0x08 did you enable HDR auto brightness under settings > revanced > miscellaneous ?

Yes I did. The thing is that I tested it using another video mot the one mentioned on the issue.

Now I see that the same problem exists on POCO F3 MIUI 13.0.4 Android 12
Latest Revanced toolkit ..

[SodaWithoutSparkles]

@its0x08 I have edited the top comment for 2 more videos that I have experienced the same issue. could you check those as well? the last one use VP9 codec if that matters, but I still get the funky swipe ctrls, even if my hands are way off the light sensor.

Could you send the vid that u used 4 testing?

[its0x08]

I confirm that with all three YouTube behaves the same.

[jonas-hurst]

As requested in #745 (comment), I reproduced this on LG V30 running Android 9. I can only reproduce it to a certain extent:

1. Right after opening video, I can change brightness by swiping without a problem
2. I tap the video settings after changing brightness (little gear top right corner in video player), then the brightness is reset to system setting
3. I tap video settings and change video quality, then things get weird: Brightness changes accordingly to my swipe on the screen, but as soon as I release my finger from the screen, brightness is reset to system setting.

I used current recommended YT, cli v2.14.0, patches v2.81.10 and integrations v0.51.0

I hope I was able to help you out.

[SodaWithoutSparkles]

New Findings: This behaviour exists no matter "Enable HDR auto brightness" under settings > misc is enabled or disabled. I have cleared the app from recent tasks before repeating the test.

I did not need to click the gear icon to have this funky brightness swipe

[54m4d]

As of v2.170.0, the issue is persistent regardless if hdr-auto-brightness patch is used or not.

[Heikrana]

This behaviour exists no matter "Enable HDR auto brightness" under settings > misc is enabled or disabled.

I tried patching without the HDR patch and even then this problems persists even though there is no option related to HDR in the settings.

[oSumAtrIX]

HDR automatically adjusts brightness, not sure if this a bug

[SodaWithoutSparkles]

HDR automatically adjusts brightness, not sure if this a bug

It should only do so when swipe brightness control was set to auto.

[oSumAtrIX]

Isn't HDR controlled by the device?

[SodaWithoutSparkles]

Isn't HDR controlled by the device?

I dont really know. Why does that even matter anyway?

It is counter-intuitive that the swipe-brightness-control overrides system brightness in all videos except HDR ones. Swipe brightness controls serves as a override to the brightness, and so should HDR content too.

Even if that is not achievable, the scroll action should provide feedback to the user by locking the controls at auto, instead of seemingly scrolling but snapping back causing confusion.

Edit: the problem is that the swipe brightness controls does work, if you act quickly and dont hold on the screen longer than a tap. If you holded longer than roughly 300ms it snaps to auto brightness again. I managed to set the brightness to 1% actually.

The solution would be to disable HDR auto brightness when there is a swipe in left zone, handle the brightness change, then only enable it back on whenthe brightness is set to auto or exit fullscreen/video

[54m4d]

Why was this issue closed without any clarification? Has it been resolved?

[oSumAtrIX]

@SodaWithoutSparkles HDR overrides brightness. If you have HDR enabled, brightness controls won't work because HDR should be controlled by the device which is why it matters.

[SodaWithoutSparkles]

@SodaWithoutSparkles HDR overrides brightness. If you have HDR enabled, brightness controls won't work because HDR should be controlled by the device which is why it matters.

But it does work, at least on my device. Maybe I should get another device to physically record it.

[oSumAtrIX]

What does "it works" mean? HDR is supposed to change the brightness:

You are not supposed to override it.

[SodaWithoutSparkles]

Thats the issue. Some people would like to watch videos that are only available in HDR in their beds w/o blinding themselves.

[oSumAtrIX]

Swipe gestures is not supposed to override HDR settings in any way. For this, another patch can be made.

Can you change the brightness from your phone when watching HDR?

[SodaWithoutSparkles]

Can you change the brightness from your phone when watching HDR?

Yes, both from the quick settings menu and with quick swipes in the video player.

[54m4d]

And what is the purpose of this option? it doesn't make any difference if it's toggled or not.

Complete inaccuracy when adjusting brightness by swiping while playing HDR videos. 👇🏻

cap.mp4

[oSumAtrIX]

Then the patch is broken, open an issue

[54m4d]

@oSumAtrIX I see that it works fine with other's patches, i see no reason why not to approach this in the same way they did?

cap.mp4