Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the backend code #334

Merged
merged 16 commits into from
Nov 13, 2023
Merged

Refactoring the backend code #334

merged 16 commits into from
Nov 13, 2023

Conversation

Benji377
Copy link
Member

The backend was originally developed by @GamingGuy003, and I used that occasion to practice Rust and expand it further. Unfortunately, I am still pretty much a beginner, and I am sure the backend can be heavily optimized.

Some needed changes:

  • Remove redundant code (Currently some functions are written twice once async and one sync, but identical)
  • Consolidate logging into a single file (Currently it writes everything to a single file, which gets overwritten on each start, while also writing any malware found to a separate file that is not getting deleted even if empty)
  • Optimize scanning
  • Organize code better and cleaner

@GamingGuy003 if you need anything for your task, just write a comment down below or contact me and I will help you out as best as I can. Thank you again for your help!

@Benji377 Benji377 added the enhancement New feature or request label Sep 17, 2023
@Benji377 Benji377 added this to the Releasing 1.2.0 milestone Sep 17, 2023
@Benji377
Copy link
Member Author

Benji377 commented Oct 9, 2023

Hey @GamingGuy003, how's it going?

@GamingGuy003
Copy link
Collaborator

Hey @GamingGuy003, how's it going?

Hey there, since uni started i haven't had a great deal of time to work on the code but I'll do my best to be done by the end of the month, if that's alright

@Benji377
Copy link
Member Author

Benji377 commented Oct 9, 2023

Sure, no problem. I know how it feels

@GamingGuy003 GamingGuy003 linked an issue Oct 25, 2023 that may be closed by this pull request
@GamingGuy003 GamingGuy003 linked an issue Oct 27, 2023 that may be closed by this pull request
Apart from the small changes to the usb_utils windows function I saw that the backend works really well.
@Benji377
Copy link
Member Author

@GamingGuy003 I saw you added a program_path variable in the config file. I am loading the config file on the frontend to write the user-selected settings in it. What should I fill the program_path variable with? Or is it read-only?

@GamingGuy003
Copy link
Collaborator

GamingGuy003 commented Nov 12, 2023

Oh, that was my mistake. I migrated the location string for the current program files into the config but forgot to make serde ignore it when de-/serializing. This should not have to be exposed to the user from what I know. Will fix asap

@Benji377 Benji377 merged commit 0f83a81 into main Nov 13, 2023
@Benji377 Benji377 deleted the refactor branch November 13, 2023 15:28
@Benji377 Benji377 restored the refactor branch November 13, 2023 15:28
@Benji377
Copy link
Member Author

@GamingGuy003 the branch has been merged, but I restored the branch, so you can continue working on that, you just need to reopen a pull-request. Or I can do that for you if you want

@GamingGuy003
Copy link
Collaborator

@GamingGuy003 the branch has been merged, but I restored the branch, so you can continue working on that, you just need to reopen a pull-request. Or I can do that for you if you want

if you could do that id be glad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make sure zip file scan still works properly after changes Implement logging into singular log file
2 participants