Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocket Hideout #986

Merged
merged 33 commits into from
Jan 26, 2025
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
d4f8384
Init Rocket Hideout
vulcandth Dec 24, 2024
a44b96d
Updated items and text for Celadon Rocket Hideout
SoupPotato Dec 27, 2024
d9cf90c
Merge branch '9bit' into pGO-hideout
vulcandth Dec 28, 2024
7722c59
Some Rockethideout name changes & Dialogue adjustments
vulcandth Dec 28, 2024
c99f6cd
Don't duplicated pGO hideout names; replace with placeholders
vulcandth Dec 28, 2024
6ec8691
Missed a placeholder name
vulcandth Dec 28, 2024
a66ffd6
Add Lure Menu And setup basic Cherrygrove bay event
vulcandth Dec 29, 2024
f76b03b
Add galar bird engine caught flags and event flags
vulcandth Dec 29, 2024
02293a4
Finish CherrygroveBay events
vulcandth Dec 29, 2024
f57ae2a
Fix hideout doors
vulcandth Dec 31, 2024
48bac8d
Fix Sparks Pikachu
vulcandth Dec 31, 2024
18cbb6b
Add GameCorner poster switch
vulcandth Jan 2, 2025
e2ce4e6
Add valor grunt next to gamecorner poster
vulcandth Jan 2, 2025
275b8c3
forgot todo comment.
vulcandth Jan 2, 2025
8ac3f7a
pGO leaders are only in the university during the day.
vulcandth Jan 2, 2025
6866995
Remove pGO leaders from Shamouti Island
vulcandth Jan 2, 2025
cb5d06f
Merge branch 'bloodmoon-ursaluna' into pGO-hideout
vulcandth Jan 2, 2025
af42703
Fix build: `NIGHT` -> `NITE`
Rangi42 Jan 4, 2025
a19ee65
Merge branch 'bloodmoon-ursaluna' into pGO-hideout
vulcandth Jan 7, 2025
2c4eea3
Fix review items
vulcandth Jan 9, 2025
2137369
Updated Cherrygrove Bay dialogue to reference the Legendary Birds event
SoupPotato Jan 10, 2025
f2033c3
Merge branch 'bloodmoon-ursaluna' into pr/986
vulcandth Jan 11, 2025
edf8fcc
Call it "The Great Tree"
vulcandth Jan 12, 2025
6cb56ad
Unique names for remaining grunts
vulcandth Jan 12, 2025
0b321df
pGO leaders should be called "Leader"
vulcandth Jan 12, 2025
f254041
Add TEACHER_M trainerclass
vulcandth Jan 12, 2025
9e7066f
Final pGO Leader dialogue
vulcandth Jan 12, 2025
faf63bc
Merge branch 'bloodmoon-ursaluna' into pr/986
vulcandth Jan 18, 2025
92b0eb1
Apply review corrections.
vulcandth Jan 18, 2025
9f9e1d0
Apply Rangi Comments
vulcandth Jan 23, 2025
7666b8d
Merge branch 'bloodmoon-ursaluna' into pGO-hideout
vulcandth Jan 23, 2025
e57e44e
Apply suggestions from code review
Rangi42 Jan 24, 2025
2dc39b6
Merge branch 'bloodmoon-ursaluna' into pGO-hideout
vulcandth Jan 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions constants/engine_flags.asm
Original file line number Diff line number Diff line change
Expand Up @@ -270,4 +270,7 @@
const ENGINE_PLAYER_CAUGHT_MEWTWO
const ENGINE_PLAYER_CAUGHT_CELEBI
const ENGINE_PLAYER_CAUGHT_SUDOWOODO
const ENGINE_PLAYER_CAUGHT_GALARIAN_ARTICUNO
const ENGINE_PLAYER_CAUGHT_GALARIAN_ZAPDOS
const ENGINE_PLAYER_CAUGHT_GALARIAN_MOLTRES
DEF NUM_ENGINE_FLAGS EQU const_value
44 changes: 38 additions & 6 deletions constants/event_flags.asm
Original file line number Diff line number Diff line change
Expand Up @@ -2175,9 +2175,9 @@
const EVENT_BOULDER_IN_CINNABAR_VOLCANO_1F_4
const EVENT_BOULDER_IN_CINNABAR_VOLCANO_B1F
const EVENT_LUCKY_ISLAND_CIVILIANS
const EVENT_CELADON_UNIVERSITY_BLANCHE
const EVENT_CELADON_UNIVERSITY_CANDELA
const EVENT_CELADON_UNIVERSITY_SPARK
const_skip
const_skip
const_skip
vulcandth marked this conversation as resolved.
Show resolved Hide resolved
const EVENT_MURKY_SWAMP_CHERYL
const EVENT_DIM_CAVE_RILEY
const EVENT_CINNABAR_VOLCANO_BUCK
Expand Down Expand Up @@ -2212,9 +2212,9 @@
const EVENT_SHAMOUTI_ISLAND_PIKABLU_GUY
const EVENT_SHAMOUTI_POKE_CENTER_IVY
const EVENT_NOISY_FOREST_PIKABLU
const EVENT_SHAMOUTI_COAST_BLANCHE
const EVENT_SHAMOUTI_COAST_CANDELA
const EVENT_SHAMOUTI_COAST_SPARK
const_skip
const_skip
const_skip
vulcandth marked this conversation as resolved.
Show resolved Hide resolved

; New to Crystal
const EVENT_KURTS_HOUSE_GRANDDAUGHTER_1
Expand Down Expand Up @@ -2406,6 +2406,38 @@
const EVENT_UNION_CAVE_B2F_LINKING_CORD
const EVENT_GOT_LOADED_DICE_FROM_GOLDENROD
const EVENT_LISTENED_TO_BATON_PASS_INTRO
const EVENT_BEAT_BLACK_BELT_VALOR_GRUNT_1
const EVENT_BEAT_SCIENTIST_SANDERS
const EVENT_BEAT_PICNICKER_ZANE
const EVENT_BEAT_BATTLE_GIRL_SASHA
const EVENT_BEAT_LASS_INSTINCT_GRUNT_1
const EVENT_PICKED_UP_MOON_STONE_FROM_ROCKET_HIDEOUT_B1F
const EVENT_PICKED_UP_ZINC_FROM_ROCKET_HIDEOUT_B1F
const EVENT_ROCKET_HIDEOUT_B1F_HIDDEN_MAX_REVIVE
const EVENT_BEAT_HEX_MANIAC_CORYN
const EVENT_PICKED_UP_ULTRA_BALL_FROM_ROCKET_HIDEOUT_B2F
const EVENT_PICKED_UP_SUPER_REPEL_FROM_ROCKET_HIDEOUT_B2F
const EVENT_PICKED_UP_NUGGET_FROM_ROCKET_HIDEOUT_B2F
const EVENT_PICKED_UP_RARE_CANDY_FROM_ROCKET_HIDEOUT_B2F
const EVENT_BEAT_COSPLAYER_INSTINCT_GRUNT_2
const EVENT_BEAT_COOL_DUDE_MYSTIC_GRUNT_1
const EVENT_PICKED_UP_CARBOS_FROM_ROCKET_HIDEOUT_B3F
const EVENT_PICKED_UP_ELIXIR_FROM_ROCKET_HIDEOUT_B3F
const EVENT_ROCKET_HIDEOUT_B3F_HIDDEN_FULL_HEAL
const EVENT_BEAT_YOUNGSTER_VALOR_GRUNT_2
const EVENT_PICKED_UP_LIFT_KEY_FROM_ROCKET_HIDEOUT_B4F
const EVENT_BEAT_TEACHER_SERENA
const EVENT_BEAT_SUPER_NERD_INSTINCT_GRUNT_3
const EVENT_ROCKET_HIDEOUT_B4F_HIDDEN_MAX_POTION
const EVENT_PICKED_UP_X_SP_ATK_FROM_ROCKET_HIDEOUT_B4F
const EVENT_PICKED_UP_PP_UP_FROM_ROCKET_HIDEOUT_B4F
const EVENT_PICKED_UP_DUBIOUS_DISC_FROM_ROCKET_HIDEOUT_B4F
const EVENT_CHERRYGROVE_BAY_FOUGHT_GALARIAN_ARTICUNO
const EVENT_CHERRYGROVE_BAY_FOUGHT_GALARIAN_ZAPDOS
const EVENT_CHERRYGROVE_BAY_FOUGHT_GALARIAN_MOLTRES
const EVENT_PUSHED_GAME_CORNER_SWITCH
const EVENT_RICH_BOY_VALOR_GRUNT_3
const EVENT_BEAT_RICH_BOY_VALOR_GRUNT_3

const_next $8ff
DEF NUM_EVENTS EQU const_value ; 2303
14 changes: 8 additions & 6 deletions constants/item_constants.asm
Original file line number Diff line number Diff line change
Expand Up @@ -667,14 +667,15 @@ DEF NUM_CANDIES EQU const_value
const ORANGETICKET ; 1d
const MYSTICTICKET ; 1e
const OLD_SEA_MAP ; 1f
const HARSH_LURE ; 20
const POTENT_LURE ; 21
const MALIGN_LURE ; 22
const LIFT_KEY ; 20
const HARSH_LURE ; 21
const POTENT_LURE ; 22
const MALIGN_LURE ; 23
DEF CHARMS_START EQU const_value
; Only charms below this point!
const SHINY_CHARM ; 23
const OVAL_CHARM ; 24
const CATCH_CHARM ; 25
const SHINY_CHARM ; 24
const OVAL_CHARM ; 25
const CATCH_CHARM ; 26
DEF NUM_KEY_ITEMS EQU const_value - 1

; Alphabetical order (see data/items/name_order.asm)
Expand All @@ -694,6 +695,7 @@ DEF NUM_KEY_ITEMS EQU const_value - 1
const NAM_GS_BALL
const NAM_HARSH_LURE
const NAM_ITEMFINDER
const NAM_LIFT_KEY
const NAM_LOST_ITEM
const NAM_MACHINE_PART
const NAM_MALIGN_LURE
Expand Down
6 changes: 6 additions & 0 deletions constants/menu_constants.asm
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,9 @@ DEF NUM_PARTYMENUACTIONS EQU const_value
const NAME_TRENDY
const NAME_BOX
DEF NUM_NAME_TYPES EQU const_value

; Lure Menu Options (see engine/menus/lure_menu.asm)
const_def 1
const HARSH_LURE_MENU_OPT ; 1
const POTENT_LURE_MENU_OPT ; 2
const MALIGN_LURE_MENU_OPT ; 3
11 changes: 7 additions & 4 deletions constants/ram_constants.asm
Original file line number Diff line number Diff line change
Expand Up @@ -491,10 +491,13 @@ DEF CELEBIEVENT_FOREST_IS_RESTLESS_F EQU 2

; wPlayerCaught2::
const_def
const PLAYER_CAUGHT_MEW_F ; 0
const PLAYER_CAUGHT_MEWTWO_F ; 1
const PLAYER_CAUGHT_CELEBI_F ; 2
const PLAYER_CAUGHT_SUDOWOODO_F ; 3
const PLAYER_CAUGHT_MEW_F ; 0
const PLAYER_CAUGHT_MEWTWO_F ; 1
const PLAYER_CAUGHT_CELEBI_F ; 2
const PLAYER_CAUGHT_SUDOWOODO_F ; 3
const PLAYER_CAUGHT_GALARIAN_ARTICUNO_F ; 4
const PLAYER_CAUGHT_GALARIAN_ZAPDOS_F ; 5
const PLAYER_CAUGHT_GALARIAN_MOLTRES_F ; 6

DEF CAUGHT_DUO_MASK EQU (1 << PLAYER_CAUGHT_HO_OH_F) | (1 << PLAYER_CAUGHT_LUGIA_F)
DEF CAUGHT_BEASTS_MASK EQU (1 << PLAYER_CAUGHT_RAIKOU_F) | (1 << PLAYER_CAUGHT_ENTEI_F) | (1 << PLAYER_CAUGHT_SUICUNE_F)
Expand Down
12 changes: 12 additions & 0 deletions constants/trainer_constants.asm
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ DEF CRYS EQU __trainer_class__
const OLIVER
const CHAZ
const TYLER
const VALOR_GRUNT_2

trainerclass BUG_CATCHER ; 21
const WADE1
Expand Down Expand Up @@ -213,6 +214,7 @@ DEF CRYS EQU __trainer_class__
const GINGER
const CHEYENNE
const ADRIAN
const ZANE

trainerclass TWINS ; 24
const AMYANDMAY1
Expand Down Expand Up @@ -406,6 +408,7 @@ DEF CRYS EQU __trainer_class__
const CHLOE
const BROOKE
const KUROKO
const INSTINCT_GRUNT_2

trainerclass SUPER_NERD ; 31
const STAN
Expand All @@ -428,6 +431,7 @@ DEF CRYS EQU __trainer_class__
const FOOTE
const DAVE
const KOUTA
const INSTINCT_GRUNT_3

trainerclass LASS ; 32
const DANA1
Expand All @@ -453,6 +457,7 @@ DEF CRYS EQU __trainer_class__
const GINA
const ALICE
const DUPLICA
const INSTINCT_GRUNT_1

trainerclass BEAUTY ; 33
const VICTORIA
Expand Down Expand Up @@ -579,6 +584,7 @@ DEF CRYS EQU __trainer_class__
const ESTHER
const MATILDA
const BETHANY
const CORYN

trainerclass SAGE ; 3c
const CHOW
Expand Down Expand Up @@ -663,6 +669,7 @@ DEF CRYS EQU __trainer_class__
const WINSTON
const GERALD
const IRVING
const VALOR_GRUNT_3

trainerclass LADY ; 4b
const JESSICA
Expand Down Expand Up @@ -793,6 +800,7 @@ DEF CRYS EQU __trainer_class__
const JOSEPH
const NIGEL
const PIOTR
const SANDERS

trainerclass ROCKET_SCIENTIST ; 55
const ROSS
Expand Down Expand Up @@ -830,6 +838,7 @@ DEF CRYS EQU __trainer_class__
const MANFORD
const ANDER
const TAKEO
const VALOR_GRUNT_1

trainerclass BATTLE_GIRL ; 59
const SUBARU
Expand All @@ -839,6 +848,7 @@ DEF CRYS EQU __trainer_class__
const RONDA
const PADMA
const EMY
const SASHA

trainerclass DRAGON_TAMER ; 5a
const PAUL
Expand All @@ -865,6 +875,7 @@ DEF CRYS EQU __trainer_class__
const SHIRLEY
const KATHRYN
const CLARICE
const SERENA

trainerclass GUITARISTM ; 5d
const CLYDE
Expand Down Expand Up @@ -970,6 +981,7 @@ DEF CRYS EQU __trainer_class__
const COOLTRAINERM_COREY
const COOLTRAINERM_RAYMOND
const FERGUS
const MYSTIC_GRUNT_1

trainerclass COOLTRAINERF ; 6b
const BETH1
Expand Down
3 changes: 3 additions & 0 deletions data/events/engine_flags.asm
Original file line number Diff line number Diff line change
Expand Up @@ -287,5 +287,8 @@ EngineFlags:
engine_flag wPlayerCaught2, PLAYER_CAUGHT_MEWTWO_F
engine_flag wPlayerCaught2, PLAYER_CAUGHT_CELEBI_F
engine_flag wPlayerCaught2, PLAYER_CAUGHT_SUDOWOODO_F
engine_flag wPlayerCaught2, PLAYER_CAUGHT_GALARIAN_ARTICUNO_F
engine_flag wPlayerCaught2, PLAYER_CAUGHT_GALARIAN_ZAPDOS_F
engine_flag wPlayerCaught2, PLAYER_CAUGHT_GALARIAN_MOLTRES_F

assert_table_length NUM_ENGINE_FLAGS
3 changes: 0 additions & 3 deletions data/events/initialize_events.asm
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,6 @@ InitialEvents:
dw EVENT_SOUL_HOUSE_MR_FUJI
dw EVENT_ROUTE_8_KANTO_POKEMON_FEDERATION
dw EVENT_SHAMOUTI_ISLAND_PIKABLU_GUY
dw EVENT_SHAMOUTI_COAST_CANDELA
dw EVENT_SHAMOUTI_COAST_BLANCHE
dw EVENT_SHAMOUTI_COAST_SPARK
dw EVENT_LAWRENCE_ROUTE_10
dw EVENT_LAWRENCES_ZAPDOS_ROUTE_10
dw EVENT_LAWRENCE_FINAL_BIRD
Expand Down
2 changes: 2 additions & 0 deletions data/items/attributes.asm
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,8 @@ KeyItemAttributes:
key_item_attribute 0, ITEMMENU_NOUSE, ITEMMENU_NOUSE
; MALIGN LURE
key_item_attribute 0, ITEMMENU_NOUSE, ITEMMENU_NOUSE
; LIFT KEY
key_item_attribute 0, ITEMMENU_NOUSE, ITEMMENU_NOUSE
; SHINY CHARM
key_item_attribute 0, ITEMMENU_CURRENT, ITEMMENU_NOUSE
; OVAL CHARM
Expand Down
6 changes: 6 additions & 0 deletions data/items/descriptions.asm
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ KeyItemDescriptions:
dw HarshLureDesc
dw PotentLureDesc
dw MalignLureDesc
dw LiftKeyDesc
dw ShinyCharmDesc
dw OvalCharmDesc
dw CatchCharmDesc
Expand Down Expand Up @@ -1656,6 +1657,11 @@ MalignLureDesc:
next "malevolent odor."
done

LiftKeyDesc:
text "Operates the lift"
next "in a building."
done

ShinyCharmDesc:
text "A charm for find-"
next "ing shiny #mon."
Expand Down
1 change: 1 addition & 0 deletions data/items/icon_pointers.asm
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ KeyItemIconPointers:
dba HarshLureIcon
dba PotentLureIcon
dba MalignLureIcon
dba LiftKeyIcon
dba ShinyCharmIcon
dba OvalCharmIcon
dba CatchCharmIcon
Expand Down
1 change: 1 addition & 0 deletions data/items/key_names.asm
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ KeyItemNames::
li "Harsh Lure"
li "Potent Lure"
li "Malign Lure"
li "Lift Key"
li "Shiny Charm"
li "Oval Charm"
li "Catch Charm"
Expand Down
1 change: 1 addition & 0 deletions data/items/name_order.asm
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ KeyItemNameOrder:
db NAM_HARSH_LURE
db NAM_POTENT_LURE
db NAM_MALIGN_LURE
db NAM_LIFT_KEY
db NAM_SHINY_CHARM
db NAM_OVAL_CHARM
db NAM_CATCH_CHARM
Expand Down
1 change: 1 addition & 0 deletions data/maps/scenes.asm
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,5 @@ MapScenes::
scene_var WILLS_ROOM, wWillsRoomSceneID
scene_var WISE_TRIOS_ROOM, wWiseTriosRoomSceneID
scene_var YELLOW_FOREST, wYellowForestSceneID
scene_var ROCKET_HIDEOUT_B4F, wRocketHideoutB4FSceneID
db -1
Binary file modified data/tilesets/underground_attributes.bin
Binary file not shown.
1 change: 1 addition & 0 deletions data/tilesets/underground_collision.asm
Original file line number Diff line number Diff line change
Expand Up @@ -103,3 +103,4 @@
tilecoll FLOOR, FLOOR, WALL, FLOOR ; 66
tilecoll WALL, ELEVATOR_BUTTON, FLOOR, FLOOR ; 67
tilecoll DOOR, WALL, FLOOR, FLOOR ; 68
tilecoll FLOOR, FLOOR, WALL, WALL ; 69
Binary file modified data/tilesets/underground_metatiles.bin
Binary file not shown.
Loading