Rocket Hideout

[vulcandth]

NOTICE: This causes a minor save break due to adding an additional key item and shifting a some ram. This will be merged into bloodmoon-ursaluna aka 3.1.0.. and be save-patched.

Some Todos:

• Replace RARE_CANDY placeholder items
• Better Dialogue (some of its fine, a lot of its barely better than placeholder text)
• Actually implement the CherryGroveBay events.
• Review pickup items for alternate choices.
• New names for NPCs; search for ; TODO: replace placeholder name
• Fix Sparks Pikachu animation
• Add grunt outside in front of a poster switch
• Final dialogue review
• Determine if we should remove the pGO leaders from shamouti island (for now)

[Rangi42]

@vulcandth @SoupPotato Thank you both so much for tackling this unfinished content! As I review/playtest it, I'll be making some notes here on what could be updated -- not necessarily by either of you, and not generally blockers for merging, just ideas.

• The RBY hideout music could instead be a PGo remix of something. (I'm not sure what already exists, or who's still in the scene making new ones.)
• The stairs should be hidden requiring a poster switch (and beating a grunt in front of it first, who would clue the player into the whole "PGo teams are hiding down here" thing). (Keep in mind how obviously telegraphed the RBY Rocket hideout was -- it's good design for ten-year-olds, and also for fast-forwarding players with the attention of ten-year-olds. :P )

[Rangi42]

Overall, I love your work here. The hideout is complete, the leaders can be battled, and the birds can be captured. I just left comments here based on a playthrough, haven't inspected the code changes, but it's looking really good!

[Rangi42]

I was fast-forwarding in BGB through a battle with VGrunt1, after exploring the various floors but not yet fighting the leaders, and when it exited the hideout BGM got silent. Not sure what the conditions are to reproduce -- it could be a problem with the hideout music itself, being ported from RBY.

[vulcandth]

Fixed the music not stopping.. but.. there is still an audio hiccup... Its mild enough that its not a blocker.. but not sure how to fix it right now.

1. Music resumes after battle
2. refresh/reload map causes music to stop for an unknown reason
3. Manually restart music
This causes the music to start playing briefly before restarting... but if I don't manually restart the music it goes silent.

[Rangi42]

Excellent work! Thank you so much for getting PC this much closer to 100% content <3