CI: upgrade to setup-go v4 and disable cache with golangci

[Shwetha-Acharya]

Below errors were seen with setup-go@v4 in golangci Lint: Error: /usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/yaml_ test.go: Cannot open: File exists
/usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/LICENSE: Cannot open: File exists

Disabling Cache with golangci solves the problem and makes sure that we are in a recent setup-go as well.

Cache can be enabled once the resultant issue is fixed in golangci lint action repo.
Issue that is to be tracked:
golangci/golangci-lint-action#135

Updates: #1000

[Shwetha-Acharya]

Successful runs after the change:
https://github.com/Shwetha-Acharya/ramen/actions/runs/5666081903
https://github.com/RamenDR/ramen/actions/runs/5666374061/job/15352984165
https://github.com/RamenDR/ramen/actions/runs/5666452802

[nirs]

It works, but I would check if this can be solved in golanci, since the issue is the cache used in golanci, not setup-go.

In any case, when we change the defaults we want to add a comment explaining why the change is needed.

[nirs]

We need a comment here why we skip the cache, or maybe we should skip golangci cache instead, since the issue is in golanci?

[Shwetha-Acharya]

I agree, but I did not find any workarounds with golangci.
I will raise a new issue in the golangci to highlight this scenario.
Also the golangci issue135 has one partial fix which went in 2.4.1 and we are already in golangci-lint-action@v3.

I had tried by updating the' with version' in golangci/golangci-lint-action:
uses: golangci/golangci-lint-action@v3
with:
version: v1.49.0
But did not find much luck with it.

I am not sure what version v1.49.0 is actually representing.

[Shwetha-Acharya]

@nirs golangci/golangci-lint-action#807

[nirs]

The whitespace changes are unrelated and should be in another commit.

[ShyamsundarR]

The white space changes do not look consistent to me, not sure if the intent is to separate sections using 2 lines. Can you clarify @Shwetha-Acharya ?

[Shwetha-Acharya]

It works, but I would check if this can be solved in golanci, since the issue is the cache used in golanci, not setup-go.

In any case, when we change the defaults we want to add a comment explaining why the change is needed.

As of now we are disabling cache on setup-go only when we are using golangci.
I agree it would be better if there was a fix from golangci.

The white space changes do not look consistent to me, not sure if the intent is to separate sections using 2 lines. Can you clarify @Shwetha-Acharya ?

I was experimenting with many changes to resolve this issue and did not notice that I had added extra spaces.