Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: upgrading to setup-go v4 is leads to Golangci Lint errors #1000

Closed
2 tasks done
Shwetha-Acharya opened this issue Jul 24, 2023 · 1 comment · Fixed by #1005
Closed
2 tasks done

CI: upgrading to setup-go v4 is leads to Golangci Lint errors #1000

Shwetha-Acharya opened this issue Jul 24, 2023 · 1 comment · Fixed by #1005
Labels
test Testing related issue triage Issue needs triage

Comments

@Shwetha-Acharya
Copy link
Contributor

Shwetha-Acharya commented Jul 24, 2023 •
edited by nirs
Loading

Below are the few builds that encountered the stated issue:
run_5598571526
run_5607722950

Error Snippet:

Received 612368384 of 664124659 (92.2%), 116.3 MBs/sec
Received 664124659 of 664124659 (100.0%), 118.2 MBs/sec
Cache Size: ~633 MB (664124659 B)
/usr/bin/tar -xf /home/runner/work/_temp/005209fb-aa88-4145-a3ef-1[26]
(https://github.com/RamenDR/ramen/actions/runs/5609819817/job/15198156789#step:4:27)4e395e5c7/cache.tzst -P -C
/home/runner/work/ramen/ramen --use-compress-program unzstd
Error: /usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/yaml_test.go: Cannot open: File exists
/usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/LICENSE: Cannot open: File exists
/usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/code-of-conduct.md: Cannot open: File exists
Error: /usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/yaml.go: Cannot open: File exists

Tasks

  • Check if this is a known issue in the setup-go action github repo
  • Upgrade when the issue is solved, of if we have an easy workaround
@nirs nirs added test Testing related issue triage Issue needs triage labels Jul 24, 2023
Shwetha-Acharya added a commit to Shwetha-Acharya/ramen that referenced this issue Jul 26, 2023
@Shwetha-Acharya
CI: upgrade to setup-go v4 and disable cache with golangci
6214658 
Below errors were seen with setup-go@v4 in golangci Lint:
Error: /usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/yaml_
test.go: Cannot open: File exists
/usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/LICENSE:
Cannot open: File exists

Disabling Cache with golangci solves the problem and makes
sure that we are in a reecent setup-go as well.

Cache can be enabled once the resultant issue is fixed in
golangc lint action repo.
Issue that to be tracked:
golangci/golangci-lint-action#135

Updates: RamenDR#1000
Signed-off-by: Shwetha K Acharya <[email protected]>
@Shwetha-Acharya Shwetha-Acharya mentioned this issue Jul 26, 2023
Merged
@Shwetha-Acharya
Copy link
Contributor Author

Shwetha-Acharya commented Jul 26, 2023 •
edited
Loading

There is an issue already files on golangci Lint repo which is to be tracked:
golangci/golangci-lint-action#135

Upgraded to setup go @v4 with a workaround.

Shwetha-Acharya added a commit to Shwetha-Acharya/ramen that referenced this issue Jul 26, 2023
@Shwetha-Acharya
CI: upgrade to setup-go v4 and disable cache with golangci
8c2ddce 
Below errors were seen with setup-go@v4 in golangci Lint:
Error: /usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/yaml_
test.go: Cannot open: File exists
/usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/LICENSE:
Cannot open: File exists

Disabling Cache with golangci solves the problem and makes
sure that we are in a reecent setup-go as well.

Cache can be enabled once the resultant issue is fixed in
golangci lint action repo.
Issue that is to be tracked:
golangci/golangci-lint-action#135

Updates: RamenDR#1000
Signed-off-by: Shwetha K Acharya <[email protected]>
Shwetha-Acharya added a commit to Shwetha-Acharya/ramen that referenced this issue Jul 27, 2023
@Shwetha-Acharya
CI: upgrade to setup-go v4 and disable cache with golangci
8eb00f0 
Below errors were seen with setup-go@v4 in golangci Lint:
Error: /usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/yaml_
test.go: Cannot open: File exists
/usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/LICENSE:
Cannot open: File exists

Disabling Cache with golangci solves the problem and makes
sure that we are in a reecent setup-go as well.

Cache can be enabled once the resultant issue is fixed in
golangci lint action repo.
Issue that is to be tracked:
golangci/golangci-lint-action#135

Updates: RamenDR#1000
Signed-off-by: Shwetha K Acharya <[email protected]>
nirs pushed a commit that referenced this issue Jul 27, 2023
@Shwetha-Acharya @nirs
CI: upgrade to setup-go v4 and disable cache with golangci
9e91714 
Below errors were seen with setup-go@v4 in golangci Lint:
Error: /usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/yaml_
test.go: Cannot open: File exists
/usr/bin/tar: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/LICENSE:
Cannot open: File exists

Disabling Cache with golangci solves the problem and makes
sure that we are in a reecent setup-go as well.

Cache can be enabled once the resultant issue is fixed in
golangci lint action repo.
Issue that is to be tracked:
golangci/golangci-lint-action#135

Updates: #1000
Signed-off-by: Shwetha K Acharya <[email protected]>
@nirs nirs linked a pull request Jul 31, 2023 that will close this issue
CI: upgrade to setup-go v4 and disable cache with golangci #1005
Merged
@nirs nirs closed this as completed Jul 31, 2023
@torcolvin torcolvin mentioned this issue Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Testing related issue triage Issue needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: upgrade to setup-go v4 and disable cache with golangci Shwetha-Acharya/ramen
2 participants
@nirs @Shwetha-Acharya