Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BG translation for PD mode options #1941

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Update BG translation for PD mode options #1941

merged 4 commits into from
Jul 8, 2024

Conversation

ia
Copy link
Collaborator

@ia ia commented Jul 3, 2024

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Update RU translation for PD mode options.

  • What is the current behavior?
    Description for PD mode and its modes are not translated.

  • What is the new behavior (if this is a feature change)?
    Translated description for PD mode and for its modes.

  • Other information:
    Before submitting the patch I did make a set of custom builds to find the most adequate "adoption" to make it fit and to have it clear (as much as possible) at the same time for an average user.

Also, I tried to get some additional information about options and what exactly they do here in a form of code review comment. But I think I figured it out after all, more or less.

P.S. As always, I understand we all busy with our lives as well. But I still determine to keep dedicating some of my time to this project when I can with everything I can.

@Ralim
Copy link
Owner

Ralim commented Jul 3, 2024

The code review comment never posted? Did you make sure to submit it from pending?

@ia
Copy link
Collaborator Author

ia commented Jul 3, 2024

The code review comment never posted?

Oh... wait, indeed! It has "Label: Pending". I thought what it means is "now it's waiting for reply"! Oops... 😳

Did you make sure to submit it from pending?

I feel myself ashamed asking this but... how should I do that exactly? I don't see any "publish"/"submit" code comment button in that PR form. Is it possible that it's because that pull-request (#1917) is merged & closed already? Just curious.

UPD: Aaaaaa... I got this! Ufff, wow, now I see! My bad indeed. Will publish it in a couple minutes. Sorry.

@ia
Copy link
Collaborator Author

ia commented Jul 5, 2024

Status update: just don't merge this yet, please. I will prepare a little update in a day or so.

@ia
Copy link
Collaborator Author

ia commented Jul 7, 2024

Status update: just don't merge this yet, please. I will prepare a little update in a day or so.

Done. Now it should sound more clear.

@Ralim Ralim merged commit ac6994a into Ralim:dev Jul 8, 2024
17 checks passed
@ia ia deleted the lang-BG branch December 18, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants