Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand USB-PD mode option #1917

Merged
merged 9 commits into from
Jun 1, 2024
Merged

Expand USB-PD mode option #1917

merged 9 commits into from
Jun 1, 2024

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented May 25, 2024

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • [] There are no breaking changes
  • What kind of change does this PR introduce?

Fixes #1904 by providing user control for how we select input.

  • What is the new behavior (if this is a feature change)?

This expands the PD menu setting from enable/disable VDPO to instead have 3 options:

  1. Padding 0.5 ohm + PPS/EPR enabled
  2. No Padding 0.5 ohm + PPS/EPR enabled
  3. No Padding 0.5 + PPS/EPR disabled (just fixed PDO's)
  • Other information:

This is currently a solution to the problem. I can't make SRAM over hard-reset be reliable enough in all cases to do this magically easily. I also have supplies that do not fill out the overload bits 😓 .

Would love feedback, tests or reviews.

Note: shell_check CI action is breaking due to diff size, will be ignored for merge.

@Ralim Ralim force-pushed the extra-pd-option branch from d36ad2f to e7ba6e9 Compare May 25, 2024 13:23
@Ralim Ralim force-pushed the extra-pd-option branch from 3f9609a to 5f2992b Compare June 1, 2024 06:33
@Ralim Ralim merged commit 442dbd9 into dev Jun 1, 2024
16 of 17 checks passed
@Ralim Ralim deleted the extra-pd-option branch June 1, 2024 06:36
@ia ia mentioned this pull request Jul 3, 2024
2 tasks
@ia ia mentioned this pull request Jul 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinecil V2 negotiates too high PD voltage overloading 60W chargers and cables
2 participants